diff options
author | Simon McVittie <smcv@debian.org> | 2011-06-01 15:11:01 +0100 |
---|---|---|
committer | Simon McVittie <smcv@debian.org> | 2011-06-01 15:11:01 +0100 |
commit | e034e2bbd4352a21b7f5bf9d4d89f7a41c78cb03 (patch) | |
tree | 6dbcb05ff39c830bec9bb80e0a65aeb6679772d5 /HACKING | |
parent | b03dfc9ec734204fa8f5e2a6fa75ad2a1973e346 (diff) | |
download | dbus-e034e2bbd4352a21b7f5bf9d4d89f7a41c78cb03.tar.gz |
Imported Upstream version 1.4.10upstream/1.4.10
Diffstat (limited to 'HACKING')
-rw-r--r-- | HACKING | 17 |
1 files changed, 15 insertions, 2 deletions
@@ -298,6 +298,20 @@ rules are: - if there's a live unresolved controversy about a change, don't commit it while the argument is still raging. + - at their discretion, members of the reviewer group may also commit + branches/patches under these conditions: + + - the branch does not add or change API, ABI or wire-protocol + + - the branch solves a known problem and is covered by the regression tests + + - there are no objections from the rest of the review group within + a week of the patches being attached to Bugzilla + + - the committer gets a positive review on Bugzilla from someone they + consider qualified to review the change (e.g. a colleague with D-Bus + experience; not necessarily a member of the reviewer group) + - regardless of reviews, to commit a patch: - make check must pass - the test suite must be extended to cover the new code @@ -326,5 +340,4 @@ John Palmieri <johnp@redhat.com> Scott James Remnant <scott@netsplit.com> Will Thompson <will.thompson@collabora.co.uk> Simon McVittie <simon.mcvittie@collabora.co.uk> - - +David Zeuthen <davidz@redhat.com> |