dh: Optimize out dh_testdir as it is literally useless

As it turned out in 333376abf9c4d6e8f286a7cbda7e8c13307745f3,
dh_testdir is called too late to provide its "helpful" error message.
Accordingly, dh itself has to print it directly now (via getpackages())
for the user to get the correct error message.

This literally makes dh_testdir useless under dh in its default
configuration.  While it is possible to override dh_testdir and have
it check for other files, it is largely an unused feature - even more
under dh.

On the plus side, we seem to save 2x 0.040s by doing this per build.
Assuming 70% of the 25 000 source packages in Debian are using dh,
this translates into a 23 "core-minutes" saving on an single
architecture archive-wide rebuild (e.g. arch:amd64 plus arch:all).

Somehow, I hope I got the math wrong because it seems obscene...

Signed-off-by: Niels Thykier <niels@thykier.net>

0 files changed, 0 insertions, 0 deletions