perl: Use my-style lexical loop iterator variables

The variables used on a foreach loop are local to that block, so if
we wanted to use it after the loop is finished the last value would
be gone.

Fixes Variables::RequireLexicalLoopIterators.

Warned-by: perlcritic

1 files changed, 3 insertions, 4 deletions

diff --git a/dselect/methods/ftp/setup b/dselect/methods/ftp/setup
index 26da50d36..ae5d56571 100755
--- a/dselect/methods/ftp/setup
+++ b/dselect/methods/ftp/setup
@@ -123,15 +123,14 @@ sub download() {
 
     my @dists = @{$_->[2]};
 
-    my $dist;
-    foreach $dist (@dists) {
+    foreach my $dist (@dists) {
 	my $dir = "$dist/binary-$arch";
 	print "Checking $dir...\n";
 #	if (!$ftp->pasv()) { print $ftp->message . "\n"; die 'error'; }
 	my @dirlst = $ftp->ls("$dir/");
 	my $got_pkgfile = 0;
-	my $line = '';
-	foreach $line (@dirlst) {
+
+	foreach my $line (@dirlst) {
 	    if($line =~ /Packages/) {
 		$got_pkgfile=1;
 	    }