diff options
Diffstat (limited to 't')
| -rw-r--r-- | t/critic.t | 1 | ||||
| -rw-r--r-- | t/critic/perlcriticrc | 7 |
2 files changed, 3 insertions, 5 deletions
diff --git a/t/critic.t b/t/critic.t index 108f1217e..14e27bd50 100644 --- a/t/critic.t +++ b/t/critic.t @@ -97,7 +97,6 @@ my @policies = qw( ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator ValuesAndExpressions::ProhibitVersionStrings ValuesAndExpressions::RequireConstantVersion - ValuesAndExpressions::RequireNumberSeparators ValuesAndExpressions::RequireQuotedHeredocTerminator ValuesAndExpressions::RequireUpperCaseHeredocTerminator Variables::ProhibitAugmentedAssignmentInDeclaration diff --git a/t/critic/perlcriticrc b/t/critic/perlcriticrc index 1708e1f35..a968009ff 100644 --- a/t/critic/perlcriticrc +++ b/t/critic/perlcriticrc @@ -23,10 +23,6 @@ minimum_regex_length_to_complain_about = 60 # TODO: switch these to q{} ? allow_if_string_contains_single_quote = 1 -[ValuesAndExpressions::RequireNumberSeparators] -# Up to 5 digits considered visually clear. -min_value = 99999 - ## ## Disable tests ## @@ -127,3 +123,6 @@ min_value = 99999 # TODO: Check it out, some magic numbers are fine, octals for example. [-ValuesAndExpressions::ProhibitMagicNumbers] + +# FIXME: False positives on long hex numbers, even when separated. +[-ValuesAndExpressions::RequireNumberSeparators] |