Age | Commit message (Collapse) | Author | Files | Lines |
|
If the option has not been set, then the source format does not support
it and we should thus not recommend the --include-removal option in the
warning.
Closes: #913012
|
|
We initialized it already in the new constructor, no point in doing the
same twice.
|
|
Running code in the module scope means that anything importing the
module will execute that code, which is undesirable. Move the
initialization into a _select_objdump() sub, which gets assigned into
a state variable on demand.
|
|
The spawn() call was removed but not the matching import.
Fixes: commit 8ae966ae7d3635b8359829085db4262923ceae96
|
|
The default buildflags got moved from the Dpkg::BuildFlags module to
the Dpkg::Vendor::Debian, but this module was not adapted to match.
Instead of running the Debian hooks after the Ubuntu buildflags are set
up, run them first, and then modify/prepend the bits we need to change.
This fixes compiler optimization on ppc64el, and makes setting it more
future proof.
Fixes: commit d5374bc618310917557daa9c9ac2f4930515a0b2
Closes: #915881
Co-Author: Iain Lane <laney@ubuntu.com>
Co-Author: Adam Conrad <adconrad@ubuntu.com>
|
|
This makes several call sites more clear, as we move the logic inside
the function.
|
|
We should keep these and consider them as pseudo-EOF markers, and stop
processing once seen.
[lamby@debian.org:
- Initial test cases for dpkg-mergechangelogs functional tests. ]
Closes: #916056
|
|
|
|
Document inherited methods. Document the return values. Note which
arguments are optional. Reorder methods by their position in the stack.
|
|
|
|
Makes it more explicit what these variables actually mean.
Prompted-by: Axel Beckert <abe@debian.org>
|
|
|
|
It is not always entirely clear how each character class described
maps to the actual characters allowed. For example in some cases
alphanumeric includes only lower-case letters, sometimes both lower-case
and upper-case. Clarify it by appending the actual explicit range within
parenthesis.
Prompted-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
|
|
These commands use both the available database and the package
selections.
Prompted-by: Johannes Schauer <josch@debian.org>
|
|
Add a reference to deb-src-control(5). Remove invalid comment in
example, as this format does not allow it.
Prompted-by: Helmut Grohne <helmut@subdivi.de>
|
|
Make it clear what will be printed when no arguments are specified.
Closes: #917098
|
|
Describe when --remove is equivalent to --purge, and what data it will
cleanup and when.
Closes: #914478
|
|
Merge subsections and fix a typo.
|
|
Update to 2952t1f.
|
|
There's no point in creating and messing with the owner and permissions
for this file on each upgrade. This also makes it possible to workaround
a problem when installing dpkg with --force-not-root, as pre-creating
the log file will diasrm the failing chown and chmod calls.
Prompted-by: Johannes Schauer <josch@debian.org>
|
|
|
|
The test suite expects to run under the C locale.
Fixes: https://rt.cpan.org/Ticket/Display.html?id=127314
|
|
All these environment variables are only relevant while running the
test suite. Do not pollute the rest of the environment.
|
|
The cd commands might fail, so we should either check their return
values or globally make errors fatal. Let's do the latter.
Warned-by: shellcheck
|
|
Reported-by: Johannes Schauer <josch@debian.org>
Warned-by: shellcheck
|
|
This variable requires to be left unquoted, which makes it unsafe to
use. But at the same time is unnecessary as we can just use PERL5OPT
instead, so let's just remove it.
Warned-by: shellcheck
|
|
Warned-by: shellcheck
|
|
Warned-by: shellcheck
|
|
Warned-by: shellcheck
|
|
Update to 603t.
|
|
Update to 1116t.
|
|
|
|
|
|
Warned-by: codespell
|
|
|
|
|
|
|
|
This makes it possible to disable any pager usage from these programs.
For dpkg this also becomes a configuration option.
Closes: #909754
|
|
This way we will be able to forcefully disable it.
|
|
Force the output to fully buffered, because originally stdout was
a tty, so it was set as line buffered. This way we send as much as
possible to the pager, which will handle the output by itself.
|
|
If the pager quits early, the parent will receive a SIGPIPE as the write
end of the pipe will not be available anymore. Instead we ignore SIGPIPE
and also EPIPE errors when writing to stdout.
Otherwise if we quit the pager early, the program will exit with an
error code.
Reported-by: Holger Levsen <holger@layer-acht.org>
Ref: #909754
|
|
|
|
This makes it possible to use a dpkg specific pager.
Suggested-by: Craig Sanders <cas@taz.net.au>
Ref: #909754
|
|
There's no point in executing «cat», we are already dumping the contents
to stdout.
|
|
The PAGER environment variable is specified in POSIX as taking a pager
command and any number of arguments to be passed to «sh -c», so we have
to preserve that behavior or this breaks badly on systems where PAGER is
set that way.
This actually gets in the way of improving the pager command presence
detection, but we'll fix that later on, by making the scanning of the
environment variable smarter or by trying to execute the fallbacks.
Closes: #910009
|
|
Let's just handle opening the file and passing its data to the pager
ourselves, as that gives us more control, and then can decide not to
run a pager at all, and do not need to mess with arguments which might
need to be passed to «sh -c».
|
|
This makes it possible to use alternative installation directories.
And will make these commands honor those directories when specified
for dpkg, and passed down to the maintainer script via the DPKG_ROOT
environment variable.
|
|
This module handles setting and getting the filesystem root directory.
|
|
Ignore EPERM for chown and chmod based syscalls. And give a more
meaningful error message on chroot().
Closes: #614126
|
|
|