summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-11-26dselect: Remove methods state files on purgeGuillem Jover3-0/+37
Ref: #930788 Spotted-by: Sven Joachim <svenjoac@gmx.de>
2019-11-26dpkg: Use DPKG_ADMINDIR to set the admindirGuillem Jover3-1/+7
This was done in the name of security, but it does not make much sense as root should make sure to be running in a clean environment. This is problematic as it makes the interface hard to understand, and produces unexpected behavior as dpkg can be called from within itself, or as a wrapper for dpkg-query, which will then not inherit the admindir value. Closes: #900071
2019-11-26dpkg: Fix and clarify behavior for packages marked to be on “hold”Guillem Jover6-9/+18
A package marked to be on hold, denotes that the package should be kept in its current version and should not be automatically installed, upgraded or removed. The same applies to frontends. This behavior does not apply when the user explicitly requested one of these actions, or the --force-hold option is used. It should never prevent dpkg from processing these for configuration (if they were already in unpacked state) or from trigger processing, otherwise we might get into trigger loops. Some of the code was already doing this, but this was not consistently done. We update also the help output and documentation to clarify the fixed behavior. Closes: #926472
2019-11-26dpkg-gencontrol: Take hardlinks into account when computing Installed-SizeSven Joachim3-1/+12
We should not add up the size of each hardlink into the final sum, otherwise we will get a size in excess. Closes: #923475 Co-Authored-by: Guillem Jover <guillem@debian.org> Signed-off-by: Guillem Jover <guillem@debian.org>
2019-11-26dpkg-query: Try to use the description from the available file if not installedGuillem Jover5-2/+40
When we have been requested to load the available file, and that contains a description for a package that is not installed, we should use that instead of printing the confusing string stating that the description is not available. Closes: #43573
2019-11-26libdpkg: Add missing symbols to the version mapGuillem Jover2-0/+8
Several of these are used by the test suite.
2019-11-26debian: Replace custom rule for 'configure' with call to dh_autoreconfDan Streetman2-7/+5
Having this custom rule to create the «configure» file means that it might end up not being rebuilt if the timestamps of some other files are off compared to the debian/changelog date. Using dh_autoreconf guarantees that even if these timestamps got updated incorrectly, the file will always be rebuilt as expected. The historic rationale for not doing this before, even though this has been considered a best packaging practice, was that because dpkg needs explicit support for new architectures, which is the main reason to get autotools updated to pull in new config.* files, we would get reports so that we could add such support and release a new upstream version. But this has never happened, and it's causing other problems. Closes: #939516 Signed-off-by: Guillem Jover <guillem@debian.org>
2019-11-26po: Fix typo in Simplified Chinese programs translationMo Zhou2-1/+2
Closes: #942195 Signed-off-by: Guillem Jover <guillem@debian.org>
2019-11-26po: Update Portuguese programs translationMiguel Figueiredo2-145/+141
Closes: #935695 Signed-off-by: Guillem Jover <guillem@debian.org>
2019-11-05German dpkg translation updateSven Joachim2-150/+141
Update to 1135t.
2019-11-01Fix a typoHelge Kreutzmann2-3/+3
2019-11-01Update German translation of manual pagesHelge Kreutzmann1-69/+95
Update to 3000t.
2019-11-01Update German scripts translationHelge Kreutzmann2-16/+43
Update to 608t.
2019-10-30dpkg, u-a: Make variables staticGuillem Jover3-4/+14
Warned-by: sparse
2019-10-30test: Suppress new bogus cppcheck 1.89 false positivesGuillem Jover2-0/+14
Warned-by: cppcheck
2019-10-30dpkg: Remove redudant condition for sourcefile in updateavailable()Guillem Jover2-1/+2
The preceding “if” already checks exclusively whether this variable is NULL, so in this branch it will always be non-NULL. Warned-by: cppcheck Fixes: knownConditionTrueFalse
2019-10-30libdpkg: Use p instead of name in dpkg_arch_name_is_illegal()Guillem Jover2-1/+2
We assign name to p, which we operate on everywhere in this function except for the first check which we still perform on name. This confuses at least cppcheck, and it's in any case inconsistent. Warned-by: cppcheck Fixes: nullPointerRedundantCheck
2019-10-30dselect: Make baselist::draw_column_*() col arguments constGuillem Jover3-6/+7
Warned-by: cppcheck Fixes: constParameter
2019-10-30man: Split dselect(1) --color from --colour option itemsGuillem Jover5-10/+31
These become too long to fit in a 80-char terminal for many translations, so let's split them, as we do anyway for the preferred formatting to avoid the mandb warning.
2019-10-30man: Globally adjust left and disable hyphenationGuillem Jover56-13/+57
These were being applied in the SEE ALSO section, but not consistently. The output is more clear this way.
2019-10-30build: Bump minimal gettext version to 0.19.8Guillem Jover2-1/+3
The GNU gettext macros used to check for symbols that were only provided by the GNU gettext implementation, but not by other implementations such as the one in musl. Starting with GNU gettext 0.19.8 these internal symbols are not required anymore.
2019-10-30test: Update stopwords for codespell 1.16.0Guillem Jover2-0/+2
2019-10-30test: Skip build directories from codespellGuillem Jover2-0/+3
These contain files that are not currently skept, and might contain spelling errors from external sources. Warned-by: codespell
2019-10-30test: Fix typosGuillem Jover2-2/+2
Warned-by: codespell
2019-10-30libdpkg, dpkg: Use new versiondescribe_c() for non-localizable call sitesGuillem Jover5-8/+11
The output on log files must not be localized. Reported-by: Julien Cristau <jcristau@debian.org>
2019-10-30libdpkg: Add new versiondescribe_c() to force a C localeGuillem Jover4-0/+18
In some contexts we need output in the C locale, such as log files. We add a new versiondescribe_c() that wraps the locale-dependant versiondescribe() function and switches to the C locale and back to the previous one before returning.
2019-10-30libdpkg: Add new C locale switch over supportGuillem Jover13-0/+61
This will make it possible to select either the current locale or a specified one, currently only C is selectable. We use this because the uselocale(3) POSIX API is recent, and the system might not have it available, so we might need to fallback to use setlocale(3) instead, which even though is not thread-safe, it's better than nothing.
2019-10-30debian: Remove obsolete Breaks satisfied since oldstableGuillem Jover2-17/+2
2019-10-30scripts: Match ~deb also as a backport marker in versionsGuillem Jover3-4/+6
Closes: #934980
2019-10-30scripts: Remove support for ~vola versioningGuillem Jover3-6/+8
This was part of the volatile.debian.org archive, which was decommissioned some time ago. Ref: https://lists.debian.org/debian-volatile-announce/2012/msg00000.html
2019-10-30dpkg: Initialize flagdeppossi in check_conflict()Guillem Jover2-1/+2
We only use this variable as a sentinel pointer so that we can make sure the pdep pointer is not NULL in subsequent checks. But cppcheck gets confused, so let's initialize it to make the code more future-proof. Warned-by: cppcheck
2019-10-30dpkg-deb: Fold two adjacent if conditionals into a single oneGuillem Jover2-1/+3
Warned-by: cppcheck
2019-10-30dselect: Reduce scope of variableGuillem Jover2-2/+4
The variable was being assigned in one side of an if branch, but the result never used. Let's reduce the scope to the if branch that actually assigns and uses it. Warned-by: cppcheck
2019-10-30libdpkg: Use the totalwritten variable for a consistency checkGuillem Jover2-0/+3
The variable was written to but never used. Warned-by: cppcheck
2019-10-30libdpkg: Use the variable instead of a type as sizeof() argumentGuillem Jover2-2/+3
This is more future proof, and in this particular case it was tripping over cppcheck and emitting a false positive for constArgument. Warned-by: cppcheck
2019-10-30test: Clarify cppcheck va_list_usedBeforeStarted suppressionGuillem Jover2-1/+2
This is actually due to our local va_copy() compatibility code, which cppcheck does not understand. Using the same code w/o the local macro does not emit the false positive.
2019-10-30test: Remove perlcritic Documentation::RequirePodLinksIncludeText suppressionGuillem Jover2-3/+2
This bogus test has been removed from upstream perlcritic, and now the code complains about an uninstalled check. Warned-by: perlcritic
2019-10-30Dpkg::Changelog: Document methods provided by subclassesGuillem Jover2-0/+18
Reported-by: Felix Lechner <felix.lechner@lease-up.com>
2019-10-30Dpkg::Source::Package::V2: Emit a special patch header on single-debian-patchGuillem Jover2-0/+14
The previous default patch header does not make sense for a conglomerate patch. Instead provide a more suitable default, that can always be overridden with either the local-patch-header or patch-header files. Closes: #933152
2019-10-30Dpkg::BuildFlags: Add new unset() methodGuillem Jover2-1/+21
This makes it possible to unset variables, so that they do not get output by the various tools. Requested-by: Daniel Schepler <dschepler@gmail.com>
2019-10-30Dpkg::BuildFlags: Remove unused hash keysGuillem Jover2-2/+1
2019-10-30dpkg-shlibdeps: Document split_soname() functionGuillem Jover2-0/+6
Explain what each different pattern means, and what it maps to. Prompted-by: Christopher Crim <christopher.crim@quoininc.com>
2019-10-30man: Clarify that the pager is called via «$SHELL -c»Guillem Jover2-2/+4
2019-10-30man: Use a minus sign for a literal stringGuillem Jover2-1/+2
2019-10-30libdpkg: Clarify lock contender error messageGuillem Jover2-3/+19
Print the PID of the lock contender, switch the tense to past as the lock might not be locked anymore by the time we finish, and add a warning explaining that removing the lock file is never the correct solution.
2019-10-30build: Install m4 files into system aclocal directoryGuillem Jover2-0/+15
This makes it possible to publish these files so that other dpkg-related projects can use them, instead of either embedding copies, or duplicating the macros.
2019-10-30build: Add a serial versioning to the m4 filesGuillem Jover11-0/+11
aclocal uses this to determine whether it needs to update m4 files in local trees.
2019-10-30Dpkg::Source::Package: Verify original tarball signatures at build timeGuillem Jover4-2/+42
When we are building the source package, while detecting whether there is any original upstream tarball signature to be included in the .dsc, it's the best time to verify them, so that when the .dsc gets eventually signed there's a certification path for the maintainer that they are including what they expected to be there.
2019-10-30Dpkg::OpenPGP: Add support for importing an OpenPGP key into a keyringGuillem Jover2-0/+37
This is needed, for example, to verify original tarball signatures.
2019-10-30Dpkg::OpenPGP: Make it possible to verify detached signaturesGuillem Jover2-0/+2
This is required to be able to verify original upstream tarball signatures, as they are expected to be ASCII armored detached signatures for the upstream tarballs.