Age | Commit message (Collapse) | Author | Files | Lines |
|
These functions have never belonged in the filesdb module, but were put
there temporarily for convenience.
|
|
|
|
|
|
|
|
The colon is often used as a separator but it is always preceded and/or
followed by a space so that it's possible to distinguish between the
colon used as a separator and the colon embedded in a package name
(like in "libc6:amd64").
Based-on-patch-by: Raphaël Hertzog <hertzog@debian.org>
Patch-sponsored-by: Linaro Limited
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
This does not apply for package constructors.
|
|
Replace pkg->set->name with varbuf_add_pkgbin_name(), pkgbin_name() or
pkg_name(). This only changes informative output, so no behaviour change
should result from this.
Based-on-patch-by: Raphaël Hertzog <hertzog@debian.org>
Patch-sponsored-by: Linaro Limited
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
|
|
[hertzog@debian.org:
- Track pkgbin in struct trigfileint. ]
|
|
Use strict types instead of a ‘void *’ pointer.
|
|
Sponsored-by: Linaro Limited
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
The code does not do anything yet with this new argument, but it will
allow it to access the multiarch information, once the on-disk layout
is changed.
|
|
Remove now unused struct pkginfo name member.
|
|
The change in commit a36cadba41b19d5908bdfcb658cf01af07c1436a was wrongly
assuming that all packages would be in one of the states
triggers-awaited, triggers-pending or installed when
trig_transitional_activate kicks in.
That is not the case and the status reset should hence only be done when
the current status is already such that the trigger information are
meaningful. transitional_interest_callback_ro() is already taking care
to not add anything in the Triggers-Pending field when the status
is such that it would not make sense.
Reported-by: Hector Oron <hector.oron@gmail.com>
|
|
The current implementation demanded libdpkg users to define thisname
themselves, which is not really a nice interface to offer to programs.
Closes: #631757
|
|
Those variants do not put triggering packages in triggers-awaited status
and thus do not record the package with the corresponding pending triggers
in the Triggers-Awaited field.
This should be used for triggers which do not provide essential
functionality when we can safely consider that the triggering packages
are able to satisfy dependencies even if the trigger processing
has not yet happened.
|
|
trig_transitional_activate() is emptying Triggers-Pending without
ensuring that the status is set back to something which is not
triggers-pending. In theory it's ok because the trig_parse_ci()
call is supposed to reactivate all the triggers. But if there's no
triggers file any more then we're effectively introducing a skew
which is going to be fatal the next time we try to write down
the status file.
The disparition of the triggers file can happen with file system problems,
bad user manipulation or even an old dpkg bug that kept triggers alive
when in fact the trigger was dropped from the package. Or the triggers
file has effectively been removed in the package but the user has restored
an old status file with a triggers-pending status that the current package
should no longer be able to generate.
In other words, properly resetting the status in
trig_transitional_activate() makes dpkg more robust.
|
|
This allows the strings to be terminated, thus printable or accessed
through the standard C string functions, and at the same time
appendable.
|
|
Make the varbuf API a bit more consistent.
|
|
Make the varbuf API a bit more consistent.
|
|
Make the varbuf API a bit more consistent.
|
|
Remove trailing spaces. Remove blank lines not separating different code
blocks. Remove blank lines at the end of the file.
|
|
Global review, which includes the following changes to try to increase
consistency, update and improve the source code comments:
- Spelling fixes.
- Use American English forms.
- Uppercase NULL, NUL and ASCII.
- Use “Note: ” instead of the slightly cryptic “NB: ” form.
- Write comments as proper sentences, including capitalizations and
ending dots.
- Move comments before the code, function or variable they refer to.
- Move general function comments outside the body.
- Convert function and variable description comments to doxygen.
- Use one space before dot, exclamation and question marks.
- Use ‘’ or “” instead of `' style quoting.
- Remove author names from comments, already visible from “git blame”.
- Mark strings for translators with “TRANSLATORS: ”.
- Remove useless or outdated comments.
- Fix comment indentation.
- Standardize comment format:
/* Short text comment. */
/* Long text,
* comment. */
/*
* Section text.
*/
|
|
|
|
Remove obsolete and now unused push_error_handler compatibility macro.
|
|
|
|
Never print an error message when doing normal cleanup, as this is
something we always want to do.
|
|
This corrects the current program name printed by other tools.
|
|
|
|
Report these errors directly through status-fd, instead of reporting
later on errors which are a consequence of those first errors, which
can be pretty confusing for a front-end.
Closes: #574599
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
|
|
Make trigh static and create an overrider function for it.
|
|
The semantics of the pkq-queue module are more clear, so it makes the
code slightly easier to handle.
|
|
Add a missing “of the License” after “version 2”. Move “but” and “GNU”
at the end of line to the next line. This matches more closely the
paragraph found in the license text for the GPL version 2.
|
|
Use the <http://www.gnu.org/licenses/> URL, instead of in most cases
the outdated FSF address, which is way more stable, as the latter has
changed several times in the past.
|
|
Place first <config.h> and <compat.h>, then all <sys/*.h> sorted by
complexity, followed by the rest of the system headers, then <dpkg/*.h>
and finally the local "*.h" ones.
Move <dpkg/i18n.h> inclusion into libdpkg inclusion block, as the
<gettext.h> compatibility header already takes care of including
<locale.h> before <libintl.h> on environments were its probamatic.
Removed duplicated inclusions.
|
|
|
|
Free the trig_awaited_pend_head list now that it is a pkg_list and
it switched from being allocated with m_malloc instead of nfmalloc.
|
|
Tell automake not to add “-I.” to the preprocessor flags, to avoid
file collisions with system headers. Re-add the path where config.h
is located. Namespace and use bracketed file inclusions for libdpkg
headers, and use quoted inclusions for program headers.
|
|
|
|
|
|
|
|
|
|
|
|
Conflicts:
ChangeLog
configure.ac
debian/changelog
lib/fields.c
man/ChangeLog
man/dpkg-buildpackage.1
man/po/de.po
man/po/dpkg-man.pot
man/po/es.po
man/po/fr.po
man/po/hu.po
man/po/ja.po
man/po/pl.po
man/po/pt_BR.po
man/po/ru.po
man/po/sv.po
po/ChangeLog
po/ja.po
po/ko.po
po/ro.po
src/main.c
|
|
Closes: #495097
|
|
Some 'Copyright <year>' entries didn't have a copyright symbol.
Add it and switch the rest from '(C)' to '©', but we don't do this
on program output which for now should remain pure ascii.
|
|
|
|
Closes: #17243, #68981, #215374, #217622, #248693, #308285
|