Age | Commit message (Collapse) | Author | Files | Lines |
|
Warned-by: cppcheck
|
|
|
|
These contain files that are not currently skept, and might contain
spelling errors from external sources.
Warned-by: codespell
|
|
This is actually due to our local va_copy() compatibility code, which
cppcheck does not understand. Using the same code w/o the local macro
does not emit the false positive.
|
|
This bogus test has been removed from upstream perlcritic, and now the
code complains about an uninstalled check.
Warned-by: perlcritic
|
|
The Perl version in Debian stretch is 5.24.1, which is the release that
will be oldstable once 1.20.x gets uploaded to Debian unstable.
|
|
Warned-by: codespell
|
|
We do not really need to normalize the return code, which was confusing
the cppcheck for which we required a supression.
|
|
Supress false positives and intended code usage.
|
|
Having to refer to the documentation to know what these are about is
annoying, inline a brief description.
|
|
|
|
This makes it possible to use a dpkg specific pager.
Suggested-by: Craig Sanders <cas@taz.net.au>
Ref: #909754
|
|
Ignore EPERM for chown and chmod based syscalls. And give a more
meaningful error message on chroot().
Closes: #614126
|
|
The paths are different in the CPAN distribution, so we need to use a
glob to catch the file in both layouts.
|
|
We do not distribute the PO files yet for CPAN, so the checks should not
fail when they are missing, even when testing with AUTHOR_TESTING=1.
|
|
|
|
The previous regex was just turning the line into an empty one, but
we count the length to check whether there was any output. In this
particular case this did not trigger because we have a chomp, that
would get rid of the last empty line, which happened to be fine as
we currently only emit one such empty line per file. But this is not
future-proof, so let's fix it before it bites us.
|
|
Warned-by: perlcritic
Fixes: Subroutines::ProhibitAmpersandSigils
|
|
Thanks-to: Niels Thykier <niels@thykier.net> (for typo in dpkg(1))
|
|
|
|
Use i18nspector (if available) to check the .po and .pot files.
|
|
The current bool overload has broken semantics, because it considers the
version "0" to be false.
The bool overload used to have sane semantics (equivalent to is_valid())
before commit 5b9f353b2940de751df47036608afbe71992d622, but there it got
changed to return the stringified version if it was valid, or undef
otherwise, to fix a problem within dpkg-shlibdeps, instead of properly
fixing the local-only problem in the tool. This makes the overload hard
to use, and broke existing callers from external projects.
We will emit a warning until dpkg 1.20.x to notify of the semantic change
in case there is code relying on the broken semantics. For fixed code the
warning can then be quiesced with:
no warnings qw(Dpkg::Version::semantic_change::overload::bool);
Closes: #895004
|
|
We should check POD syntax in any perl script that contains it, not just
within the Dpkg perl modules.
|
|
Fixes: Subroutines::ProhibitManyArgs
Warned-by: perlcritic
|
|
This is not something that we can easily fix, those are all upstream
problems.
|
|
Fixes: commit 2378fb62a7b0985aef451beb9ff856a4df5dd715
|
|
|
|
This will check that the module $VERSION matches the newest entry
in the CHANGES section if there is any POD present.
|
|
|
|
Declare the minimum required POD sections.
|
|
|
|
Our current minimal Perl version contains a new enough List::Util module
implementing none and any, and several other functions.
|
|
The Perl version in Debian jessie is 5.20.2, which is the release that
will be oldstable once 1.19.x gets uploaded to Debian unstable.
|
|
This test produces false positives on long hex numbers, even when they
have been separated with underscores.
|
|
This makes using the module a bit easier.
|
|
This makes sure we will not forget to get them out of the ignore list
once they get documented.
|
|
The .buildinfo files are a new type of control files, similar to
the .changes files, meant to describe the environment of a build
and its artifacts. They are meant to be added to the Debian archive
to allow independent parties to reproduce a build and verify the
result.
Specifications for .buildinfo are available at:
<https://wiki.debian.org/ReproducibleBuilds/BuildinfoSpecification>
This patch adds support for .buildinfo files in Dpkg::Control,
adds new .buildinfo fields to Dpkg::Control::Fields, a new
builtin-system-build-paths Dpkg::Vendor hook, and adds a new script
named dpkg-genbuildinfo, that will now be called by dpkg-buildpackage
before generating the .changes file.
[ntyni@debian.org: small changes. ]
Closes: #138409
Based-on-patch-by: Jérémy Bobbio <lunar@debian.org>
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
The Dpkg::Arch and Dpkg::Source::Package modules are partially private,
and several of its functions are not yet documented as public. Ignore
these two for now to avoid the expected failures.
|
|
|
|
Emit an error when the source package uses this substvar.
|
|
|
|
Make sure all SYNOPSIS sections have compilable code.
|
|
Verify that the perl version we want to restrict ourselves in the coding
style is enforced through the test suite.
|
|
|
|
|
|
Up to 5 digits should be considered visually clear.
|
|
With «use warnings» some inermodule issues such as redefinitions of
symbols are not catched, because that is too late.
Define PERL in the unit test environment so that we can invoke the
detected interpreter.
And disable the now redundant syntax_ok() check from the strict.t unit
test.
|
|
|
|
We work primarily with ASCII, so we want to specify the exact characters
to match.
|
|
This should make the regular expressions easier to read and understand,
and allows to add comments describing specific parts.
Addresses RegularExpressions::RequireExtendedFormatting.
Warned-by: perlcritic
|