From 9581f11d5efb591cd95baeae38054ab37d30df8c Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Wed, 9 Jan 2013 19:54:47 +0100
Subject: dpkg-scansources: Use a foreach loop instead of a void map

Fixes BuiltinFunctions::ProhibitVoidMap.
---
 scripts/dpkg-scansources.pl | 8 +++-----
 test/100_critic.t           | 1 +
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/scripts/dpkg-scansources.pl b/scripts/dpkg-scansources.pl
index 905821601..671863b1d 100755
--- a/scripts/dpkg-scansources.pl
+++ b/scripts/dpkg-scansources.pl
@@ -338,12 +338,10 @@ sub main {
     close $find_fh or error(close_msg, 'find');
 
     if (@out) {
-        map {
-            $_->output(\*STDOUT);
+        foreach my $dsc (sort { $a->{Package} cmp $b->{Package} } @out) {
+            $dsc->output(\*STDOUT);
             print "\n";
-        } sort {
-            $a->{Package} cmp $b->{Package}
-        } @out;
+        }
     }
 
     return 0;
diff --git a/test/100_critic.t b/test/100_critic.t
index eaa8ff40f..4f867291d 100644
--- a/test/100_critic.t
+++ b/test/100_critic.t
@@ -41,6 +41,7 @@ my @policies = qw(
     BuiltinFunctions::ProhibitUniversalCan
     BuiltinFunctions::ProhibitUniversalIsa
     BuiltinFunctions::ProhibitVoidGrep
+    BuiltinFunctions::ProhibitVoidMap
     BuiltinFunctions::RequireGlobFunction
     BuiltinFunctions::RequireSimpleSortBlock
     ClassHierarchies::ProhibitAutoloading
-- 
cgit v1.2.3