From ca3e9ea4a3d218f1605757355ee88ca1572d5bb2 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Wed, 15 Jan 2014 19:11:41 +0100 Subject: Dpkg::Compression::FileHandle: Use croak instead of error on programming errors --- scripts/Dpkg/Compression/FileHandle.pm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/Dpkg/Compression/FileHandle.pm b/scripts/Dpkg/Compression/FileHandle.pm index a214ea4a2..391728c26 100644 --- a/scripts/Dpkg/Compression/FileHandle.pm +++ b/scripts/Dpkg/Compression/FileHandle.pm @@ -382,8 +382,11 @@ sub get_filehandle { sub open_for_write { my ($self) = @_; - error("Can't reopen an already opened compressed file") if exists *$self->{mode}; my $filehandle; + + croak 'cannot reopen an already opened compressed file' + if exists *$self->{mode}; + if ($self->use_compression()) { *$self->{compressor}->compress(from_pipe => \$filehandle, to_file => $self->get_filename()); @@ -397,8 +400,11 @@ sub open_for_write { sub open_for_read { my ($self) = @_; - error("Can't reopen an already opened compressed file") if exists *$self->{mode}; my $filehandle; + + croak 'cannot reopen an already opened compressed file' + if exists *$self->{mode}; + if ($self->use_compression()) { *$self->{compressor}->uncompress(to_pipe => \$filehandle, from_file => $self->get_filename()); -- cgit v1.2.3