From d33cf5c4aaf22345a320f292d2a3205e25986aaf Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Wed, 12 Sep 2012 07:43:16 +0200 Subject: Avoid assignments in C conditionals --- dpkg-deb/extract.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'dpkg-deb') diff --git a/dpkg-deb/extract.c b/dpkg-deb/extract.c index 7655158af..c90863a3c 100644 --- a/dpkg-deb/extract.c +++ b/dpkg-deb/extract.c @@ -366,7 +366,8 @@ controlextractvextract(int admin, enum dpkg_tar_options taroptions, { const char *debar, *dir; - if (!(debar= *argv++)) + debar = *argv++; + if (debar == NULL) badusage(_("--%s needs a .deb filename argument"),cipaction->olong); dir = *argv++; if (!dir) { @@ -387,7 +388,8 @@ do_fsystarfile(const char *const *argv) { const char *debar; - if (!(debar= *argv++)) + debar = *argv++; + if (debar == NULL) badusage(_("--%s needs a .deb filename argument"),cipaction->olong); if (*argv) badusage(_("--%s takes only one argument (.deb filename)"),cipaction->olong); -- cgit v1.2.3