From a2de4aa132890b97dbe3ec028322562bc2e5b033 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Fri, 27 Feb 2009 04:55:23 +0200 Subject: libdpkg: Do nothing when parsing a boolean field with an empty string The field should have been already initialized to 0 by blankpackageperfile, so no need to assign again. --- lib/fields.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/fields.c b/lib/fields.c index 31c9ae365..ce2b04846 100644 --- a/lib/fields.c +++ b/lib/fields.c @@ -130,10 +130,10 @@ void f_boolean(struct pkginfo *pigp, struct pkginfoperfile *pifp, enum parsedbflags flags, const char *filename, int lno, FILE *warnto, int *warncount, const char *value, const struct fieldinfo *fip) { - pifp->essential = *value ? - convert_string(filename, lno, _("yes/no in boolean field"), - -1, pigp, value, booleaninfos, NULL) : - 0; + if (!*value) + return; + pifp->essential = convert_string(filename, lno, _("yes/no in boolean field"), + -1, pigp, value, booleaninfos, NULL); } void f_section(struct pkginfo *pigp, struct pkginfoperfile *pifp, -- cgit v1.2.3