From f88c908b5f058d592d87f89b58d9c0b7f34d8194 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Tue, 30 Sep 2014 23:47:40 +0200 Subject: scripts: Unpack arguments just once Addresses Subroutines::RequireArgUnpacking. Warned-by: perlcritic --- scripts/Dpkg/Compression/Process.pm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'scripts/Dpkg/Compression/Process.pm') diff --git a/scripts/Dpkg/Compression/Process.pm b/scripts/Dpkg/Compression/Process.pm index 39753a68d..bb791f337 100644 --- a/scripts/Dpkg/Compression/Process.pm +++ b/scripts/Dpkg/Compression/Process.pm @@ -147,8 +147,9 @@ properly close the sub-process (and verify that it exited without error). =cut sub compress { - my $self = shift; - my %opts = $self->_sanity_check(@_); + my ($self, %opts) = @_; + + $self->_sanity_check(%opts); my @prog = $self->get_compress_cmdline(); $opts{exec} = \@prog; $self->{cmdline} = "@prog"; @@ -169,8 +170,9 @@ properly close the sub-process (and verify that it exited without error). =cut sub uncompress { - my $self = shift; - my %opts = $self->_sanity_check(@_); + my ($self, %opts) = @_; + + $self->_sanity_check(%opts); my @prog = $self->get_uncompress_cmdline(); $opts{exec} = \@prog; $self->{cmdline} = "@prog"; -- cgit v1.2.3