From d6851023a9ab87e3109fca3f2f9c6b5210575663 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Fri, 4 Jan 2013 02:51:56 +0100 Subject: Do not quote simple identifier hash keys in initializations Do not quote the keys for any hash which will always use simple identifiers, as that is taken care of by the => operator. So this does not apply to overload pragmas, version operators, field names, substvars, command line options or filenames. Addresses ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic --- scripts/Dpkg/Source/Functions.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'scripts/Dpkg/Source/Functions.pm') diff --git a/scripts/Dpkg/Source/Functions.pm b/scripts/Dpkg/Source/Functions.pm index d88b896cc..10a9d7af0 100644 --- a/scripts/Dpkg/Source/Functions.pm +++ b/scripts/Dpkg/Source/Functions.pm @@ -97,9 +97,9 @@ sub is_binary($) { # Use diff to check if it's a binary file my $diffgen; my $diff_pid = spawn( - 'exec' => [ 'diff', '-u', '--', '/dev/null', $file ], - 'env' => { LC_ALL => 'C', LANG => 'C', TZ => 'UTC0' }, - 'to_pipe' => \$diffgen + exec => [ 'diff', '-u', '--', '/dev/null', $file ], + env => { LC_ALL => 'C', LANG => 'C', TZ => 'UTC0' }, + to_pipe => \$diffgen, ); my $result = 0; local $_; -- cgit v1.2.3