From cdf22e3757608040460329b46db3fad73e159bcd Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Wed, 2 Oct 2019 04:15:24 +0200
Subject: dpkg: Remove redudant condition for sourcefile in updateavailable()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The preceding “if” already checks exclusively whether this variable
is NULL, so in this branch it will always be non-NULL.

Warned-by: cppcheck
Fixes: knownConditionTrueFalse
---
 src/update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/update.c b/src/update.c
index 313f09de9..4a9a95b5b 100644
--- a/src/update.c
+++ b/src/update.c
@@ -50,7 +50,7 @@ updateavailable(const char *const *argv)
   case act_avreplace: case act_avmerge:
     if (sourcefile == NULL)
       sourcefile = "-";
-    else if (sourcefile && argv[1])
+    else if (argv[1])
       badusage(_("--%s takes at most one Packages-file argument"),
                cipaction->olong);
     break;
-- 
cgit v1.2.3