From 90baddbae257b517cd09a3a6b5d03a40cadd58d6 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Fri, 4 Jan 2013 10:59:36 +0100 Subject: dpkg-shlibdeps: Do not use readline operator in a foreach loop These are very slow as the list context forces the operator to read the entire stream before starting the loop. Fixes InputOutput::ProhibitReadlineInForLoop. Warned-by: perlcritic --- test/100_critic.t | 1 + 1 file changed, 1 insertion(+) (limited to 'test') diff --git a/test/100_critic.t b/test/100_critic.t index c034c51e6..671c6d3ea 100644 --- a/test/100_critic.t +++ b/test/100_critic.t @@ -55,6 +55,7 @@ my @policies = qw( InputOutput::ProhibitInteractiveTest InputOutput::ProhibitJoinedReadline InputOutput::ProhibitOneArgSelect + InputOutput::ProhibitReadlineInForLoop InputOutput::ProhibitTwoArgOpen InputOutput::RequireEncodingWithUTF8Layer Miscellanea::ProhibitFormats -- cgit v1.2.3