From d54542f573336abe87676547f1b01cda5726c71e Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Thu, 9 Oct 2014 16:02:05 +0200 Subject: scripts: Do not modify the topic variable values in list functions Fixes ControlStructures::ProhibitMutatingListFunctions. Warned-by: perlcritic --- test/critic.t | 1 + test/critic/perlcriticrc | 3 +++ 2 files changed, 4 insertions(+) (limited to 'test') diff --git a/test/critic.t b/test/critic.t index 53e3714c9..5f7c5a894 100644 --- a/test/critic.t +++ b/test/critic.t @@ -57,6 +57,7 @@ my @policies = qw( CodeLayout::RequireConsistentNewlines ControlStructures::ProhibitCStyleForLoops ControlStructures::ProhibitLabelsWithSpecialBlockNames + ControlStructures::ProhibitMutatingListFunctions ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions ControlStructures::ProhibitUntilBlocks Documentation::RequirePackageMatchesPodName diff --git a/test/critic/perlcriticrc b/test/critic/perlcriticrc index b627a4ab6..05a50fc2e 100644 --- a/test/critic/perlcriticrc +++ b/test/critic/perlcriticrc @@ -3,6 +3,9 @@ severity = 1 verbose = %f %l:%c (Severity: %s)\n %P (%s)\n near '%r'\n%d\n program-extensions = .pl .t +[ControlStructures::ProhibitMutatingListFunctions] +add_list_funcs = Dpkg::Util::any Dpkg::Util::none + [RegularExpressions::ProhibitUnusualDelimiters] allow_all_brackets = 1 -- cgit v1.2.3