diff options
| author | Lukas Czerner <lczerner@redhat.com> | 2011-09-14 13:27:44 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2011-09-14 13:49:04 -0400 |
| commit | 9d10f017e2420119455f5fa46db698961786e578 (patch) | |
| tree | ea715e3c7e22595635e7b1ca1fe8da21e41bff63 /misc | |
| parent | 449c87a49cdc59271eb24ad3ecd6e7857b99a160 (diff) | |
| download | e2fsprogs-9d10f017e2420119455f5fa46db698961786e578.tar.gz | |
e2image: fix invalid lseek error detection
In flush_l2_cache() we are using ext2fs_llseek() however we do not
properly detect the error code returned from the function, because we
are assigning it into ULL variable, hence we will not see negative
values.
Fix this by changing the type of the variable to ext2_loff_t which is
signed and hence will store negative values.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'misc')
| -rw-r--r-- | misc/e2image.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/misc/e2image.c b/misc/e2image.c index 83a9d025..bf0c0d43 100644 --- a/misc/e2image.c +++ b/misc/e2image.c @@ -759,7 +759,8 @@ static void put_used_table(struct ext2_qcow2_image *img, static void flush_l2_cache(struct ext2_qcow2_image *image) { - blk64_t offset, seek = 0; + blk64_t seek = 0; + ext2_loff_t offset; struct ext2_qcow2_l2_cache *cache = image->l2_cache; struct ext2_qcow2_l2_table *table = cache->used_head; int fd = image->fd; |