From 598ff01414fc01bc12be69c0fa1e852c4a93864d Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Fri, 9 Dec 2005 19:16:40 -0500 Subject: Fix bogus spaces before '!' and '?' characters in unused programs. On Mon, Oct 31, 2005 at 01:23:53PM +0000, Martin Michlmayr wrote: > Package: e2fsprogs > Version: 1.38-2 > Severity: minor > > e2fsprogs isn't consistent in its use of spaces before an exclamation > mark. The patch below fixed this by removing some spaces. > (Interestingly, I couldn't find the error message in the sources where > I noticed this inconsistency, namely "group descriptors corrupted !"). Patch applied, but none of the source files you touched are actually compiled in e2fsprogs, and most of them weren't written by me. :-) Addresses Debian Bug #336604 Signed-off-by: "Theodore Ts'o" --- ext2ed/dir_com.c | 2 +- ext2ed/disk.c | 2 +- ext2ed/doc/ext2ed-design.sgml | 20 ++++++++++---------- ext2ed/doc/ext2fs-overview.sgml | 4 ++-- ext2ed/init.c | 2 +- misc/findsuper.c | 2 +- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ext2ed/dir_com.c b/ext2ed/dir_com.c index 211a5cf9..c6b194e0 100644 --- a/ext2ed/dir_com.c +++ b/ext2ed/dir_com.c @@ -19,7 +19,7 @@ the functions here are a superset of those in the file_com.c source. We assume that the user reached here using the dir command of the inode type and not by using settype dir, so that init_dir_info is indeed called to gather the required information. -type_data is not changed ! It still contains the inode of the file - We handle the directory in our own +type_data is not changed! It still contains the inode of the file - We handle the directory in our own variables, so that settype ext2_inode will "go back" to the inode of this directory. First written on: April 28 1995 diff --git a/ext2ed/disk.c b/ext2ed/disk.c index b754bf34..d29c7194 100644 --- a/ext2ed/disk.c +++ b/ext2ed/disk.c @@ -158,7 +158,7 @@ The hex bytes are converted to text, so that they will be readable with a standa original=(unsigned char *) malloc (length*sizeof (unsigned char)); if (original==NULL) { - wprintw (command_win,"Fatal error - Can\'t allocate %lu bytes !"); + wprintw (command_win,"Fatal error - Can\'t allocate %lu bytes!"); refresh_command_win ();fclose (fp);return (0); } diff --git a/ext2ed/doc/ext2ed-design.sgml b/ext2ed/doc/ext2ed-design.sgml index 8ac4fcb1..3eaca691 100644 --- a/ext2ed/doc/ext2ed-design.sgml +++ b/ext2ed/doc/ext2ed-design.sgml @@ -109,7 +109,7 @@ technology. However, I didn't have the luxury of choice when I started my project - -Linux is a relatively new (and great !) operating system. The extended-2 +Linux is a relatively new (and great!) operating system. The extended-2 filesystem is even newer - Its first release lies somewhere in 1993 - Only passed two years until I started working on my project. @@ -143,7 +143,7 @@ more than just the principles. -The kernel sources are a rare bonus ! You don't get everyday the full +The kernel sources are a rare bonus! You don't get everyday the full sources of the operating system. There is so much that can be learned from them, and it is the ultimate source - The exact answer how the kernel works is there, with all the fine details. At the first week I started to @@ -155,7 +155,7 @@ who starts to build a large puzzle. -However, this was exactly the interesting part ! It is frustrating to know +However, this was exactly the interesting part! It is frustrating to know it all from advance - I think that the discovery itself, bit by bit, is the key to a true learning and understanding. @@ -238,7 +238,7 @@ looking at the sources, of-course). I didn't know almost anything of the structure of the ext2 filesystem. Reading the sources was not enough - I needed to experiment. However, a tool -for experiments in the ext2 filesystem was exactly my project ! - Kind of a +for experiments in the ext2 filesystem was exactly my project! - Kind of a paradox. @@ -1106,7 +1106,7 @@ places at the code. The various commands are reached by the user through the dispatch function. This is not surprising. The fact that can be surprising, at least in a first look, is that you'll find the dispatch call in many of my -own functions !. +own functions!. @@ -2321,7 +2321,7 @@ cd command is a path from /. This is one of the best examples of the power of the object oriented design and of the dispatching mechanism. The operation is complicated, yet the -implementation is surprisingly short ! +implementation is surprisingly short! @@ -2355,7 +2355,7 @@ void type_ext2___cd (char *command_line) -Note the number of the dispatch calls ! +Note the number of the dispatch calls! @@ -2366,13 +2366,13 @@ a dir command "enters" the directory, and then we specific cd command to take us from there (The object is dir, so that dispatch will call the cd command of the dir type). Note that a symbolic link following could bring us back to the root directory, -thus the innocent calls above treats nicely such a recursive case ! +thus the innocent calls above treats nicely such a recursive case! I feel that the above is intuitive - I was expressing myself "in the language" of the ext2 filesystem - (Go to the inode, etc), and the code was -written exactly in this spirit ! +written exactly in this spirit! @@ -3136,7 +3136,7 @@ int action_count (struct struct_file_info *info) It will just CONTINUE until the last entry. The returned structure (of type struct_file_info) will have its number in the -dir_entry_num field, and this is exactly the required number ! +dir_entry_num field, and this is exactly the required number! diff --git a/ext2ed/doc/ext2fs-overview.sgml b/ext2ed/doc/ext2fs-overview.sgml index 487cc0a7..a6ebf5ab 100644 --- a/ext2ed/doc/ext2fs-overview.sgml +++ b/ext2ed/doc/ext2fs-overview.sgml @@ -126,7 +126,7 @@ ext2 filesystem in Linux 1.3, so stay tuned. -A filesystem - Why do we need it ? +A filesystem - Why do we need it? I thought that before we dive into the various small details, I'll reserve a @@ -139,7 +139,7 @@ A filesystem consists of two word - Everyone knows the meaning of the word file - A bunch of data put -somewhere. where ? This is an important question. I, for example, usually +somewhere. where? This is an important question. I, for example, usually throw almost everything into a single drawer, and have difficulties finding something later. diff --git a/ext2ed/init.c b/ext2ed/init.c index de504b41..f89d8934 100644 --- a/ext2ed/init.c +++ b/ext2ed/init.c @@ -476,7 +476,7 @@ void signal_SIGSEGV_handler (int sig_num) { prepare_to_close (); - printf ("Killed by signal %d !\n",sig_num); + printf ("Killed by signal %d!\n",sig_num); exit (1); } diff --git a/misc/findsuper.c b/misc/findsuper.c index 620f775c..5720f4f7 100644 --- a/misc/findsuper.c +++ b/misc/findsuper.c @@ -153,7 +153,7 @@ int main(int argc, char *argv[]) exit(1); } - /* Now, go looking for the superblock ! */ + /* Now, go looking for the superblock! */ printf(_("starting at %Ld, with %d byte increments\n"), sk, skiprate); printf(_(" thisoff block fs_blk_sz blksz grp last_mount\n")); for (; lseek64(fd, sk, SEEK_SET) != -1 && -- cgit v1.2.3