From fb2301db8e408458b542c1f5fa07b5b8a3a95395 Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Tue, 29 Nov 2022 20:04:28 +0200 Subject: 15258 libsmb: tautological-pointer-compare Reviewed by: Dan Cross Reviewed by: Gordon Ross Approved by: Dan McDonald --- usr/src/lib/smbsrv/libsmb/common/smb_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/src/lib/smbsrv/libsmb/common/smb_domain.c b/usr/src/lib/smbsrv/libsmb/common/smb_domain.c index 5b4a15a08f..e1c5109871 100644 --- a/usr/src/lib/smbsrv/libsmb/common/smb_domain.c +++ b/usr/src/lib/smbsrv/libsmb/common/smb_domain.c @@ -144,7 +144,7 @@ smb_domain_add(smb_domain_type_t type, smb_domain_t *di) { uint32_t res; - if ((di == NULL) || (di->di_sid == NULL)) + if (di == NULL || di->di_sid[0] == '\0') return (SMB_DOMAIN_INVALID_ARG); if ((res = smb_dcache_lock(SMB_DCACHE_WRLOCK)) == SMB_DOMAIN_SUCCESS) { -- cgit v1.2.3