From 5608cf052f6eabe370f15f49b6fa5d0d8be732af Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Mon, 27 Dec 2021 13:55:56 +0200 Subject: 14335 nscd: this 'if' clause does not guard... Reviewed by: Andrew Stormont Reviewed by: C Fraire Approved by: Dan McDonald --- usr/src/cmd/nscd/nscd_config.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'usr/src') diff --git a/usr/src/cmd/nscd/nscd_config.c b/usr/src/cmd/nscd/nscd_config.c index ae1066dde8..cba6c6b3aa 100644 --- a/usr/src/cmd/nscd/nscd_config.c +++ b/usr/src/cmd/nscd/nscd_config.c @@ -2351,14 +2351,13 @@ _nscd_cfg_str_to_data( else if (strcasecmp(str, "no") == 0) *(nscd_bool_t *)data = nscd_false; else { + (void) snprintf(msg, sizeof (msg), + gettext("data (%s) must be 'yes' or 'no' for %s"), + str, desc->id.name); - (void) snprintf(msg, sizeof (msg), - gettext("data (%s) must be 'yes' or 'no' for %s"), - str, desc->id.name); - - if (errorp != NULL) - *errorp = _nscd_cfg_make_error(NSCD_INVALID_ARGUMENT, - msg); + if (errorp != NULL) + *errorp = _nscd_cfg_make_error( + NSCD_INVALID_ARGUMENT, msg); _NSCD_LOG(NSCD_LOG_CONFIG, NSCD_LOG_LEVEL_ERROR) (me, "ERROR: %s\n", msg); -- cgit v1.2.3