diff options
| author | Toomas Soome <tsoome@me.com> | 2017-07-16 10:03:59 +0300 |
|---|---|---|
| committer | Gordon Ross <gwr@nexenta.com> | 2018-04-01 17:48:01 -0400 |
| commit | fff695d46af8deb863236b0569e68ea5a9bb6756 (patch) | |
| tree | d668948c881a080bec50ab47e99aea0d06d921a1 | |
| parent | c15ff06a5cef5880e0afc02c7a87c6b22455f848 (diff) | |
| download | illumos-joyent-fff695d46af8deb863236b0569e68ea5a9bb6756.tar.gz | |
9308 mdnsd: this statement may fall through
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
Approved by: Gordon Ross <gwr@nexenta.com>
| -rw-r--r-- | usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSCommon.c | 4 | ||||
| -rw-r--r-- | usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSDigest.c | 7 | ||||
| -rw-r--r-- | usr/src/cmd/cmd-inet/usr.lib/mdnsd/uDNS.c | 3 |
3 files changed, 12 insertions, 2 deletions
diff --git a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSCommon.c b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSCommon.c index 607293e838..e75f734e22 100644 --- a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSCommon.c +++ b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSCommon.c @@ -1536,8 +1536,8 @@ mDNSexport mDNSu32 RDataHashValue(const ResourceRecord *const rr) sum = DomainNameHashValue((domainname *)rdb->data); ptr += dlen; len -= dlen; - /* FALLTHROUGH */ } + /* FALLTHROUGH */ default: { @@ -4185,6 +4185,7 @@ decimal: if (!F.havePrecision) case 'p': F.havePrecision = F.lSize = 1; F.precision = sizeof(void*) * 2; // 8 characters on 32-bit; 16 characters on 64-bit + /* FALLTHROUGH */ case 'X': digits = "0123456789ABCDEF"; goto hexadecimal; case 'x': digits = "0123456789abcdef"; @@ -4278,6 +4279,7 @@ hexadecimal: if (F.lSize) n = va_arg(arg, unsigned long); default: s = mDNS_VACB; i = mDNS_snprintf(mDNS_VACB, sizeof(mDNS_VACB), "<<UNKNOWN FORMAT CONVERSION CODE %%%c>>", c); + /* FALLTHROUGH */ case '%': *sbuffer++ = (char)c; if (++nwritten >= buflen) goto exit; diff --git a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSDigest.c b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSDigest.c index e1aa82df11..6520ac6f6e 100644 --- a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSDigest.c +++ b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/DNSDigest.c @@ -610,16 +610,21 @@ void md5_block_data_order (MD5_CTX *c, const void *p,int num); #define HOST_p_c2l(c,l,n) { \ switch (n) { \ case 0: l =((unsigned long)(*((c)++))); \ + /* FALLTHROUGH */ \ case 1: l|=((unsigned long)(*((c)++)))<< 8; \ + /* FALLTHROUGH */ \ case 2: l|=((unsigned long)(*((c)++)))<<16; \ + /* FALLTHROUGH */ \ case 3: l|=((unsigned long)(*((c)++)))<<24; \ } } #define HOST_p_c2l_p(c,l,sc,len) { \ switch (sc) { \ case 0: l =((unsigned long)(*((c)++))); \ if (--len == 0) break; \ + /* FALLTHROUGH */ \ case 1: l|=((unsigned long)(*((c)++)))<< 8; \ if (--len == 0) break; \ + /* FALLTHROUGH */ \ case 2: l|=((unsigned long)(*((c)++)))<<16; \ } } /* NOTE the pointer is not incremented at the end of this */ @@ -627,7 +632,9 @@ void md5_block_data_order (MD5_CTX *c, const void *p,int num); l=0; (c)+=n; \ switch (n) { \ case 3: l =((unsigned long)(*(--(c))))<<16; \ + /* FALLTHROUGH */ \ case 2: l|=((unsigned long)(*(--(c))))<< 8; \ + /* FALLTHROUGH */ \ case 1: l|=((unsigned long)(*(--(c)))); \ } } #define _HOST_l2c(l,c) (*((c)++)=(unsigned char)(((l) )&0xff), \ diff --git a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/uDNS.c b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/uDNS.c index 6ce0158b56..56aced0180 100644 --- a/usr/src/cmd/cmd-inet/usr.lib/mdnsd/uDNS.c +++ b/usr/src/cmd/cmd-inet/usr.lib/mdnsd/uDNS.c @@ -2310,7 +2310,8 @@ mDNSlocal void UpdateOneSRVRecord(mDNS *m, AuthRecord *rr) case regState_NATError: if (!NATChanged) return; - // if nat changed, register if we have a target (below) + // if nat changed, register if we have a target (below) + /* FALLTHROUGH */ case regState_NoTarget: if (!newtarget->c[0]) |