9415 bnxe: this statement may fall through

Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Robert Mustacchi <rm@joyent.com>

6 files changed, 11 insertions, 5 deletions

diff --git a/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c b/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c
index f22f25c842..7e1afd9fd0 100644
--- a/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c
+++ b/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c
@@ -7023,6 +7023,7 @@ elink_status_t elink_set_led(struct elink_params *params,
 		 */
 		if (!vars->link_up)
 			break;
+		/* FALLTHROUGH */
 	case ELINK_LED_MODE_ON:
 		if (((params->phy[ELINK_EXT_PHY1].type ==
 			  PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727) ||
@@ -13309,11 +13310,13 @@ static void elink_phy_def_cfg(struct elink_params *params,
 	switch (link_config  & PORT_FEATURE_LINK_SPEED_MASK) {
 	case PORT_FEATURE_LINK_SPEED_10M_HALF:
 		phy->req_duplex = DUPLEX_HALF;
+		/* FALLTHROUGH */
 	case PORT_FEATURE_LINK_SPEED_10M_FULL:
 		phy->req_line_speed = ELINK_SPEED_10;
 		break;
 	case PORT_FEATURE_LINK_SPEED_100M_HALF:
 		phy->req_duplex = DUPLEX_HALF;
+		/* FALLTHROUGH */
 	case PORT_FEATURE_LINK_SPEED_100M_FULL:
 		phy->req_line_speed = ELINK_SPEED_100;
 		break;
diff --git a/usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c b/usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c
index 1ba65a2510..d9084da125 100644
--- a/usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c
+++ b/usr/src/uts/common/io/bnxe/577xx/drivers/common/ecore/ecore_sp_verbs.c
@@ -3389,7 +3389,7 @@ static int ecore_mcast_validate_e2(struct _lm_device_t *pdev,
 	/* DEL command deletes all currently configured MACs */
 	case ECORE_MCAST_CMD_DEL:
 		o->set_registry_size(o, 0);
-		/* Don't break */
+		/* FALLTHROUGH */
 
 	/* RESTORE command will restore the entire multicast configuration */
 	case ECORE_MCAST_CMD_RESTORE:
@@ -3695,7 +3695,7 @@ static int ecore_mcast_validate_e1(struct _lm_device_t *pdev,
 	/* DEL command deletes all currently configured MACs */
 	case ECORE_MCAST_CMD_DEL:
 		o->set_registry_size(o, 0);
-		/* Don't break */
+		/* FALLTHROUGH */
 
 	/* RESTORE command will restore the entire multicast configuration */
 	case ECORE_MCAST_CMD_RESTORE:
diff --git a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c
index adbc4b31ec..021abfaac6 100644
--- a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c
+++ b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_devinfo.c
@@ -2346,6 +2346,7 @@ static lm_status_t lm_get_shmem_mf_mac_info(lm_device_t *pdev)
                 break;
             }
         }
+	/* FALLTHROUGH */
     case MULTI_FUNCTION_SI:
     case MULTI_FUNCTION_AFEX:
         lm_get_shmem_ext_mac_addresses(pdev);
diff --git a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c
index 1410de16fd..deacbecdf1 100644
--- a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c
+++ b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c
@@ -4616,6 +4616,7 @@ lm_chip_init( struct _lm_device_t *pdev)
         {
             return lm_status;
         }
+        /* FALLTHROUGH */
     case LM_LOADER_RESPONSE_LOAD_COMMON:
 #ifdef _VBD_
         lm_fl_reset_clear_inprogress(pdev);
@@ -4643,6 +4644,7 @@ lm_chip_init( struct _lm_device_t *pdev)
 
         //Check if there is dbus work
         mm_dbus_start_if_enable(pdev);
+        /* FALLTHROUGH */
 
     case LM_LOADER_RESPONSE_LOAD_PORT:
 #ifdef _VBD_
@@ -4672,7 +4674,7 @@ lm_chip_init( struct _lm_device_t *pdev)
         init_port_part(pdev);
         lm_init_intmem_port(pdev);
 
-        // going to the function part - fall through
+        /* FALLTHROUGH */
     case LM_LOADER_RESPONSE_LOAD_FUNCTION:
 #ifdef _VBD_
     if (lm_is_function_after_flr(pdev))
diff --git a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c
index 4b5fd815d4..75fea255cd 100644
--- a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c
+++ b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/device/lm_resc.c
@@ -110,7 +110,7 @@ lm_clear_chain_sb_cons_idx(
         LM_INTMEM_WRITE32(PFDEV(pdev), CSTORM_HC_SYNC_LINE_DHC_OFFSET(hc_sb_info->hc_index_value, fw_sb_id), 0, BAR_CSTRORM_INTMEM);
         LM_INTMEM_READ32(PFDEV(pdev), CSTORM_HC_SYNC_LINE_DHC_OFFSET(hc_sb_info->hc_index_value, fw_sb_id), &rd_val_32, BAR_CSTRORM_INTMEM);
         DbgBreakIfAll(rd_val_32 != 0);
-        //Go to zeroing index value without break
+        /* FALLTHROUGH */
     case STATUS_BLOCK_NORMAL_TYPE:
         if (CHIP_IS_E1x(PFDEV(pdev))) {
             LM_INTMEM_WRITE16(PFDEV(pdev), CSTORM_HC_SYNC_LINE_INDEX_E1X_OFFSET(hc_sb_info->hc_index_value, fw_sb_id), 0, BAR_CSTRORM_INTMEM);
diff --git a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c
index 0caaff759e..db7e294fe2 100644
--- a/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c
+++ b/usr/src/uts/common/io/bnxe/577xx/drivers/common/lm/l5/lm_l5.c
@@ -1715,7 +1715,7 @@ lm_sc_service_eq_intr(
             cid = SW_CID(kcqe->iscsi_conn_context_id);
 
             lm_sc_handle_tcp_event(pdev, cid, kcqe->op_code);
-            /* Fast path events, no break on purpose */
+            /* FALLTHROUGH */
         default:
             if (l5_kcqe_start == NULL)
             {