diff options
| author | John Levon <john.levon@joyent.com> | 2018-12-16 23:29:00 +0000 |
|---|---|---|
| committer | Hans Rosenfeld <hans.rosenfeld@joyent.com> | 2019-01-09 11:47:40 +0100 |
| commit | b6b206fc7fb36f7b13b01acf70ed6e676e405998 (patch) | |
| tree | ee571acfcabf0de526b8abb772596982aab98313 | |
| parent | dc5e7685b131559c0b7c622baee25a9a0ae50ada (diff) | |
| download | illumos-joyent-b6b206fc7fb36f7b13b01acf70ed6e676e405998.tar.gz | |
10077 usr/src/uts/ Makefile changes for smatch
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Jason King <jason.brian.king@gmail.com>
Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
212 files changed, 960 insertions, 466 deletions
diff --git a/usr/src/uts/i86pc/acpi_drv/Makefile b/usr/src/uts/i86pc/acpi_drv/Makefile index ce5eb13317..da499c485e 100644 --- a/usr/src/uts/i86pc/acpi_drv/Makefile +++ b/usr/src/uts/i86pc/acpi_drv/Makefile @@ -23,7 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the acpi_drv @@ -65,6 +65,9 @@ CPPFLAGS += -DSUNDDI CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/acpi_video.o := SMOFF += all_func_returns + LDFLAGS += -dy -N misc/acpica # diff --git a/usr/src/uts/i86pc/acpidev/Makefile b/usr/src/uts/i86pc/acpidev/Makefile index b59e9501b1..f910150ec6 100644 --- a/usr/src/uts/i86pc/acpidev/Makefile +++ b/usr/src/uts/i86pc/acpidev/Makefile @@ -24,7 +24,7 @@ # Copyright (c) 2009, Intel Corporation. # All rights reserved. # -# Copyright 2016, Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ACPI device configuration # kernel module. @@ -66,6 +66,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/i86pc/acpinex/Makefile b/usr/src/uts/i86pc/acpinex/Makefile index 5269dc4115..4f6354af69 100644 --- a/usr/src/uts/i86pc/acpinex/Makefile +++ b/usr/src/uts/i86pc/acpinex/Makefile @@ -24,9 +24,9 @@ # Copyright (c) 2009, Intel Corporation. # All rights reserved. # -# Copyright 2016, Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # -# This makefile drives the production of the ACPI virtual nexus +# This makefile drives the production of the ACPI virtual nexus # kernel module. # # intel platform dependent @@ -64,6 +64,9 @@ LDFLAGS += -dy -N misc/acpica -N misc/acpidev CERRWARN += -_gcc=-Wno-unused-function +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/i86pc/apix/Makefile b/usr/src/uts/i86pc/apix/Makefile index 21df6e6098..383fff42a9 100644 --- a/usr/src/uts/i86pc/apix/Makefile +++ b/usr/src/uts/i86pc/apix/Makefile @@ -22,7 +22,7 @@ # uts/i86pc/apix/Makefile # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. -# Copyright 2017, Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the apix "mach" # kernel module. @@ -63,6 +63,11 @@ $(NOT_RELEASE_BUILD)DEBUG_DEFS += $(DEBUG_FLGS) # LDFLAGS += -dy -N misc/acpica +# needs work, real bug in apic_allocate_irq() +$(OBJS_DIR)/mp_platform_common.o := SMOFF += indenting +# needs work +$(OBJS_DIR)/psm_common.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/i86pc/dr/Makefile b/usr/src/uts/i86pc/dr/Makefile index 84d6ff1a4f..90d07cf914 100644 --- a/usr/src/uts/i86pc/dr/Makefile +++ b/usr/src/uts/i86pc/dr/Makefile @@ -25,10 +25,7 @@ # Copyright (c) 2010, Intel Corporation. # All rights reserved. # -# This makefile drives the production of the dr driver module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -72,6 +69,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-empty-body +# needs work +SMOFF += index_overflow + # # module dependencies # diff --git a/usr/src/uts/i86pc/i86hvm/Makefile.i86hvm b/usr/src/uts/i86pc/i86hvm/Makefile.i86hvm index 74d04631ab..18b0397f70 100644 --- a/usr/src/uts/i86pc/i86hvm/Makefile.i86hvm +++ b/usr/src/uts/i86pc/i86hvm/Makefile.i86hvm @@ -23,6 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. ROOT_HVM_DIR = $(ROOT_PLAT_DIR)/i86hvm ROOT_HVM_MOD_DIR = $(ROOT_HVM_DIR)/kernel @@ -58,3 +59,6 @@ LINT_LIB_DIR = $(UTSBASE)/$(PLATFORM)/lint-libs/$(OBJS_DIR) # CPPFLAGS += -DXPV_HVM_DRIVER -D_SOLARIS ASFLAGS += -DXPV_HVM_DRIVER + +# needs work +SMATCH=off diff --git a/usr/src/uts/i86pc/isa/Makefile b/usr/src/uts/i86pc/isa/Makefile index 9cfd72f370..40412e11b9 100644 --- a/usr/src/uts/i86pc/isa/Makefile +++ b/usr/src/uts/i86pc/isa/Makefile @@ -23,7 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ISA nexus driver # @@ -58,6 +58,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(OBJS_DIR)/isa.o := CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/i8237A.o := SMOFF += indenting + # # lint pass one enforcement # diff --git a/usr/src/uts/i86pc/pcie/Makefile b/usr/src/uts/i86pc/pcie/Makefile index 475ed19ff7..2451a9d8f0 100644 --- a/usr/src/uts/i86pc/pcie/Makefile +++ b/usr/src/uts/i86pc/pcie/Makefile @@ -24,12 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the kernel/misc/pcie module -# for PCI-E Error handling support in PCI-E nexus drivers. -# -# i86pc implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -69,6 +64,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function # safe +# needs work +SMOFF += all_func_returns,deref_check + # # Default build targets. # diff --git a/usr/src/uts/i86pc/pcplusmp/Makefile b/usr/src/uts/i86pc/pcplusmp/Makefile index 6795ea994a..ee597e2b3b 100644 --- a/usr/src/uts/i86pc/pcplusmp/Makefile +++ b/usr/src/uts/i86pc/pcplusmp/Makefile @@ -24,7 +24,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2017, Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # @@ -67,6 +67,11 @@ $(NOT_RELEASE_BUILD)DEBUG_DEFS += $(DEBUG_FLGS) # LDFLAGS += -dy -N misc/acpica +# needs work +$(OBJS_DIR)/mp_platform_common.o := SMOFF += indenting +# needs work +$(OBJS_DIR)/psm_common.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/i86pc/rootnex/Makefile b/usr/src/uts/i86pc/rootnex/Makefile index 63b027b90e..5f2410edef 100644 --- a/usr/src/uts/i86pc/rootnex/Makefile +++ b/usr/src/uts/i86pc/rootnex/Makefile @@ -24,10 +24,7 @@ # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the rootnex driver -# -# i86pc implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +71,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/immu_qinv.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/i86pc/unix/Makefile b/usr/src/uts/i86pc/unix/Makefile index da1238835b..c06ee0a7f6 100644 --- a/usr/src/uts/i86pc/unix/Makefile +++ b/usr/src/uts/i86pc/unix/Makefile @@ -18,15 +18,10 @@ # # CDDL HEADER END # - -# # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of unix (and unix.o). -# -# i86pc implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -162,6 +157,16 @@ CERRWARN += -_gcc=-Wno-clobbered CERRWARN += -_gcc=-Wno-empty-body CERRWARN += -_gcc=-Wno-unused-value +# false positives +SMOFF += index_overflow + +# needs work +SMOFF += all_func_returns,deref_check,signed + +$(OBJS_DIR)/fmsmb.o := SMOFF += indenting +$(OBJS_DIR)/zutil.o := SMOFF += indenting +$(OBJS_DIR)/bootrd_cpio.o := SMOFF += allocating_enough_data + # Ensure that lint sees 'struct cpu' containing a fully declared # embedded 'struct machcpu' # diff --git a/usr/src/uts/i86pc/uppc/Makefile b/usr/src/uts/i86pc/uppc/Makefile index 5e3dc71b4c..dbd949be09 100644 --- a/usr/src/uts/i86pc/uppc/Makefile +++ b/usr/src/uts/i86pc/uppc/Makefile @@ -23,7 +23,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the uppc mach # kernel module. @@ -63,6 +63,9 @@ CERRWARN += -_gcc=-Wno-unused-function DEBUG_FLGS = DEBUG_DEFS += $(DEBUG_FLGS) +# needs work +$(OBJS_DIR)/psm_common.o := SMOFF += deref_check + # # Depends on ACPI CA interpreter # diff --git a/usr/src/uts/i86xpv/isa/Makefile b/usr/src/uts/i86xpv/isa/Makefile index 04df9350d3..348a36ba23 100644 --- a/usr/src/uts/i86xpv/isa/Makefile +++ b/usr/src/uts/i86xpv/isa/Makefile @@ -23,7 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ISA nexus driver # @@ -58,6 +58,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(OBJS_DIR)/isa.o := CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/i8237A.o := SMOFF += indenting + # # lint pass one enforcement # diff --git a/usr/src/uts/i86xpv/unix/Makefile b/usr/src/uts/i86xpv/unix/Makefile index dae214bfa6..d078cd727e 100644 --- a/usr/src/uts/i86xpv/unix/Makefile +++ b/usr/src/uts/i86xpv/unix/Makefile @@ -23,6 +23,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. +# # This makefile drives the production of unix (and unix.o). # # i86xpv implementation architecture dependent @@ -148,6 +150,9 @@ CERRWARN += -_gcc=-Wno-clobbered CERRWARN += -_gcc=-Wno-unused-value CERRWARN += -_gcc=-Wno-empty-body +# needs work +SMATCH=off + # Ensure that lint sees 'struct cpu' containing a fully declared # embedded 'struct machcpu' # diff --git a/usr/src/uts/i86xpv/xnb/Makefile b/usr/src/uts/i86xpv/xnb/Makefile index 132ede9860..59d6c55882 100644 --- a/usr/src/uts/i86xpv/xnb/Makefile +++ b/usr/src/uts/i86xpv/xnb/Makefile @@ -23,12 +23,7 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the xnb -# network driver support module. -# -# i86xpv architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -78,6 +73,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += signed + # # Default build targets. # diff --git a/usr/src/uts/i86xpv/xnf/Makefile b/usr/src/uts/i86xpv/xnf/Makefile index 7bc5c8844f..e897ea37e2 100644 --- a/usr/src/uts/i86xpv/xnf/Makefile +++ b/usr/src/uts/i86xpv/xnf/Makefile @@ -25,13 +25,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the xve -# network driver kernel module. -# -# i86xpv architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -73,6 +67,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/i86xpv/xpv_psm/Makefile b/usr/src/uts/i86xpv/xpv_psm/Makefile index 23d1b62ba4..f971123f53 100644 --- a/usr/src/uts/i86xpv/xpv_psm/Makefile +++ b/usr/src/uts/i86xpv/xpv_psm/Makefile @@ -23,7 +23,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # @@ -81,6 +81,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-empty-body CERRWARN += -_gcc=-Wno-unused-function +# needs work +SMATCH=off + # Default build targets. # .KEEP_STATE: diff --git a/usr/src/uts/i86xpv/xpv_uppc/Makefile b/usr/src/uts/i86xpv/xpv_uppc/Makefile index 81537582ac..be887878b9 100644 --- a/usr/src/uts/i86xpv/xpv_uppc/Makefile +++ b/usr/src/uts/i86xpv/xpv_uppc/Makefile @@ -23,7 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the xpv_uppc mach # kernel module. @@ -64,6 +64,9 @@ DEBUG_DEFS += $(DEBUG_FLGS) CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/psm_common.o := SMOFF += deref_check + # # # Depends on ACPI CA interpreter diff --git a/usr/src/uts/intel/FSS/Makefile b/usr/src/uts/intel/FSS/Makefile index e5ccd5a9a0..dd4ea315d6 100644 --- a/usr/src/uts/intel/FSS/Makefile +++ b/usr/src/uts/intel/FSS/Makefile @@ -22,8 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/FSS/Makefile -# +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the FSS scheduling class @@ -66,6 +65,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/fss.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/aac/Makefile b/usr/src/uts/intel/aac/Makefile index d619d9fece..dc832d136e 100644 --- a/usr/src/uts/intel/aac/Makefile +++ b/usr/src/uts/intel/aac/Makefile @@ -23,6 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the aac driver kernel module. @@ -71,6 +72,9 @@ CERRWARN += -_gcc=-Wno-unused-value CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-switch +# needs work +$(OBJS_DIR)/aac.o := SMOFF += shift_to_zero + # # Default build targets. # diff --git a/usr/src/uts/intel/ac97/Makefile b/usr/src/uts/intel/ac97/Makefile index 2905c1a6ad..17e0293df5 100644 --- a/usr/src/uts/intel/ac97/Makefile +++ b/usr/src/uts/intel/ac97/Makefile @@ -24,7 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the ac97 support module. +# Copyright (c) 2018, Joyent, Inc. # # @@ -54,6 +54,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) LDFLAGS += -dy -Ndrv/audio +# needs work +$(OBJS_DIR)/ac97.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/acpica/Makefile b/usr/src/uts/intel/acpica/Makefile index a72d55bacb..e9ae57ab4c 100644 --- a/usr/src/uts/intel/acpica/Makefile +++ b/usr/src/uts/intel/acpica/Makefile @@ -2,7 +2,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# Copyright 2016 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # # # This makefile drives the production of the ACPI CA services @@ -54,6 +54,8 @@ CFLAGS += $(CCVERBOSE) -DPWRDMN -DACPI_USE_LOCAL_CACHE -DACPI_DEBUG_OUTPUT # CERRWARN += -erroff=E_STATEMENT_NOT_REACHED +SMOFF += all_func_returns + LINTFLAGS += -errchk=%none LINTFLAGS += -errhdr=%none LINTFLAGS += -erroff=%all diff --git a/usr/src/uts/intel/agpgart/Makefile b/usr/src/uts/intel/agpgart/Makefile index e80b1db6cf..85153fd65c 100644 --- a/usr/src/uts/intel/agpgart/Makefile +++ b/usr/src/uts/intel/agpgart/Makefile @@ -2,8 +2,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/agpgart/Makefile -# +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the framework of agp protocol @@ -39,6 +38,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/agpgart.o := SMOFF += deref_check + # # For now, disable these lint checks; maintainers should endeavor # to investigate and remove these for maximum lint coverage. diff --git a/usr/src/uts/intel/amd8111s/Makefile b/usr/src/uts/intel/amd8111s/Makefile index ae77fff1bf..1a6309b68e 100755 --- a/usr/src/uts/intel/amd8111s/Makefile +++ b/usr/src/uts/intel/amd8111s/Makefile @@ -22,11 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the AMD8111 -# Fast Ethernet (amd8111s) driver module in intel systems -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -62,6 +58,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) # LDFLAGS += -dy -N misc/mac +# seems wrong +$(OBJS_DIR)/amd8111s_hw.o := SMOFF += precedence + # # Default build targets. # diff --git a/usr/src/uts/intel/arcmsr/Makefile b/usr/src/uts/intel/arcmsr/Makefile index 286162de07..d389365c10 100644 --- a/usr/src/uts/intel/arcmsr/Makefile +++ b/usr/src/uts/intel/arcmsr/Makefile @@ -21,6 +21,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -46,6 +47,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/arcmsr.o := SMOFF += deref_check + # # Define targets. # diff --git a/usr/src/uts/intel/arn/Makefile b/usr/src/uts/intel/arn/Makefile index fc133828cd..f25a80418f 100644 --- a/usr/src/uts/intel/arn/Makefile +++ b/usr/src/uts/intel/arn/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # @@ -38,7 +39,7 @@ UTSBASE = ../.. # Define the module and object file sets. # MODULE = arn -OBJECTS = $(ARN_OBJS:%=$(OBJS_DIR)/%) +OBJECTS = $(ARN_OBJS:%=$(OBJS_DIR)/%) LINTS = $(ARN_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) @@ -65,6 +66,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-char-subscripts +# various issues +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/arp/Makefile b/usr/src/uts/intel/arp/Makefile index 9b91950434..33a2cbb716 100644 --- a/usr/src/uts/intel/arp/Makefile +++ b/usr/src/uts/intel/arp/Makefile @@ -24,10 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the arp driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -76,6 +73,9 @@ LDFLAGS += -dy -Ndrv/ip LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV +# false positive +SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/ath/Makefile b/usr/src/uts/intel/ath/Makefile index fbf5b7d6eb..30c72db1b4 100644 --- a/usr/src/uts/intel/ath/Makefile +++ b/usr/src/uts/intel/ath/Makefile @@ -22,6 +22,7 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This file makes the atheros driver for an intel system @@ -66,6 +67,9 @@ CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-empty-body +# needs work +$(OBJS_DIR)/ath_rate.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/atu/Makefile b/usr/src/uts/intel/atu/Makefile index 958ead1731..4418857ce5 100644 --- a/usr/src/uts/intel/atu/Makefile +++ b/usr/src/uts/intel/atu/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the atu driver kernel module. @@ -61,6 +62,9 @@ LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Nmisc/usba CERRWARN += -_gcc=-Wno-switch +# needs work +$(OBJS_DIR)/atu.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/audio/Makefile b/usr/src/uts/intel/audio/Makefile index 7a3ba33a11..6b9547d4b5 100644 --- a/usr/src/uts/intel/audio/Makefile +++ b/usr/src/uts/intel/audio/Makefile @@ -24,8 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the audio support module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -48,6 +47,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/audio_grc3.o := SMOFF += index_overflow + # # Define targets # diff --git a/usr/src/uts/intel/audioemu10k/Makefile b/usr/src/uts/intel/audioemu10k/Makefile index d0155c40fe..c115cc4024 100644 --- a/usr/src/uts/intel/audioemu10k/Makefile +++ b/usr/src/uts/intel/audioemu10k/Makefile @@ -24,8 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the audioemu10k driver. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -62,6 +61,9 @@ LDFLAGS += -dy -Ndrv/audio -Nmisc/ac97 CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns + $(OBJS_DIR)/%.o := CPPFLAGS += -I$(OBJS_DIR) $(OBJS_DIR)/%.ln := CPPFLAGS += -I$(OBJS_DIR) $(OBJS_DIR)/emu10k_gpr.h := ASM10KFLAGS = -v -0 -P gpr diff --git a/usr/src/uts/intel/audiosolo/Makefile b/usr/src/uts/intel/audiosolo/Makefile index d8eac43ea9..cc3e29e1ca 100644 --- a/usr/src/uts/intel/audiosolo/Makefile +++ b/usr/src/uts/intel/audiosolo/Makefile @@ -24,8 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the audiosolo driver. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -56,6 +55,9 @@ LDFLAGS += -dy -Ndrv/audio CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += assign_vs_compare + # # Default build targets. # diff --git a/usr/src/uts/intel/av1394/Makefile b/usr/src/uts/intel/av1394/Makefile index 9ccf35ed33..acf063f91e 100644 --- a/usr/src/uts/intel/av1394/Makefile +++ b/usr/src/uts/intel/av1394/Makefile @@ -22,6 +22,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree. @@ -74,6 +75,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-type-limits +# needs work +$(OBJS_DIR)/av1394_isoch.o := SMOFF += signed + # # depends on misc/s1394 LDFLAGS += -dy -Nmisc/s1394 diff --git a/usr/src/uts/intel/bge/Makefile b/usr/src/uts/intel/bge/Makefile index 661d2b4fb3..eedd8c38c6 100644 --- a/usr/src/uts/intel/bge/Makefile +++ b/usr/src/uts/intel/bge/Makefile @@ -22,6 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the Broadcom BCM57xx @@ -70,6 +71,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function +# 3rd party source +SMOFF += all_func_returns + # # Driver depends on MAC # diff --git a/usr/src/uts/intel/blowfish/Makefile b/usr/src/uts/intel/blowfish/Makefile index 97ddabc38e..dd40e59c1e 100644 --- a/usr/src/uts/intel/blowfish/Makefile +++ b/usr/src/uts/intel/blowfish/Makefile @@ -18,6 +18,8 @@ # # CDDL HEADER END # +# Copyright (c) 2018, Joyent, Inc. +# # Copyright 2014 Garrett D'Amore <garrett@damore.org> # # Copyright 2008 Sun Microsystems, Inc. All rights reserved. @@ -76,6 +78,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/blowfish_impl.o := SMOFF += precedence + # # Default build targets. # diff --git a/usr/src/uts/intel/bofi/Makefile b/usr/src/uts/intel/bofi/Makefile index 14a5fd7bc0..e419840e5f 100644 --- a/usr/src/uts/intel/bofi/Makefile +++ b/usr/src/uts/intel/bofi/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the bofi driver @@ -70,6 +71,9 @@ CPPFLAGS += -I../../sun4 CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/bofi.o := SMOFF += signed_integer_overflow_check,deref_check + # # For now, disable these lint checks; maintainers should endeavor # to investigate and remove these for maximum lint coverage. diff --git a/usr/src/uts/intel/bpf/Makefile b/usr/src/uts/intel/bpf/Makefile index b7136e61db..e96a03d04b 100644 --- a/usr/src/uts/intel/bpf/Makefile +++ b/usr/src/uts/intel/bpf/Makefile @@ -22,10 +22,12 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. +# # uts/intel/bpf/Makefile # # -# This makefile drives the production of the bpf driver +# This makefile drives the production of the bpf driver # kernel module. # # intel architecture dependent @@ -73,6 +75,9 @@ LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/bpf.o := SMOFF += all_func_returns + # # Default build targets. # @@ -88,7 +93,7 @@ clobber: $(CLOBBER_DEPS) lint: $(LINT_DEPS) -modlintlib: $(MODLINTLIB_DEPS) +modlintlib: $(MODLINTLIB_DEPS) clean.lint: $(CLEAN_LINT_DEPS) diff --git a/usr/src/uts/intel/cardbus/Makefile b/usr/src/uts/intel/cardbus/Makefile index 4b5fa7e764..a6eba6f056 100644 --- a/usr/src/uts/intel/cardbus/Makefile +++ b/usr/src/uts/intel/cardbus/Makefile @@ -22,8 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/cardbus/Makefile -# +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the cardbus kernel module. @@ -56,7 +55,7 @@ ALL_TARGET = $(BINARY) LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) -# +# # Include sun4u specific header files # INC_PATH += -I$(UTSBASE)/sun4u -I$(UTSBASE)/sun4 -I$(UTSBASE)/i86pc @@ -87,6 +86,8 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-unused-variable +SMOFF += indenting,no_if_block + # # Default build targets. # diff --git a/usr/src/uts/intel/chxge/Makefile b/usr/src/uts/intel/chxge/Makefile index 052bd467d2..fd082067f7 100644 --- a/usr/src/uts/intel/chxge/Makefile +++ b/usr/src/uts/intel/chxge/Makefile @@ -22,6 +22,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the Chelsio N110 @@ -104,6 +105,11 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-parentheses +SMOFF += indenting,all_func_returns,no_if_block + +# needs work +$(OBJS_DIR)/sge.o := SMOFF += index_overflow + # # # Default build targets. diff --git a/usr/src/uts/intel/clone/Makefile b/usr/src/uts/intel/clone/Makefile index f2018b056e..06c6223eb7 100644 --- a/usr/src/uts/intel/clone/Makefile +++ b/usr/src/uts/intel/clone/Makefile @@ -25,12 +25,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -#pragma ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the clone driver -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -58,6 +53,9 @@ ALL_TARGET = $(BINARY) $(SRC_CONFILE) LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) +# needs work +$(OBJS_DIR)/clone.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/cmlb/Makefile b/usr/src/uts/intel/cmlb/Makefile index 45158fec56..8e09b5c030 100644 --- a/usr/src/uts/intel/cmlb/Makefile +++ b/usr/src/uts/intel/cmlb/Makefile @@ -23,11 +23,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the cmlb "misc" -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -80,6 +77,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/cmlb.o := SMOFF += signed + # # Default build targets. # diff --git a/usr/src/uts/intel/cpqary3/Makefile b/usr/src/uts/intel/cpqary3/Makefile index 245a86c8cb..a2f1207c25 100644 --- a/usr/src/uts/intel/cpqary3/Makefile +++ b/usr/src/uts/intel/cpqary3/Makefile @@ -10,7 +10,7 @@ # # -# Copyright 2013 Joyent, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -46,6 +46,8 @@ CPPFLAGS += -I$(UTSBASE)/common/io/cpqary3 # LDFLAGS += -dy -Nmisc/scsi +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/ctfs/Makefile b/usr/src/uts/intel/ctfs/Makefile index cbe7dd1c34..03934580b6 100644 --- a/usr/src/uts/intel/ctfs/Makefile +++ b/usr/src/uts/intel/ctfs/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the contract file system @@ -64,6 +65,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/ctfs_root.o := SMOFF += signed_integer_overflow_check + # # Default build targets. # diff --git a/usr/src/uts/intel/cxgbe/t4nex/Makefile b/usr/src/uts/intel/cxgbe/t4nex/Makefile index 8185b52238..20ddeb8cf7 100644 --- a/usr/src/uts/intel/cxgbe/t4nex/Makefile +++ b/usr/src/uts/intel/cxgbe/t4nex/Makefile @@ -12,6 +12,7 @@ # # Copyright (c) 2013 by Chelsio Communications, Inc. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the Chelsio Terminator 4 10G Ethernet @@ -90,6 +91,9 @@ LINTTAGS += -erroff=E_FUNC_RET_MAYBE_IGNORED2 LINTTAGS += -erroff=E_CASE_FALLTHRU LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/dadk/Makefile b/usr/src/uts/intel/dadk/Makefile index 85c6ff48be..d64833d0be 100644 --- a/usr/src/uts/intel/dadk/Makefile +++ b/usr/src/uts/intel/dadk/Makefile @@ -24,11 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the dadk "misc" -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -75,6 +71,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += all_func_returns,signed + # # Default build targets. # diff --git a/usr/src/uts/intel/daplt/Makefile b/usr/src/uts/intel/daplt/Makefile index 3dcf2d7e07..ef99701369 100644 --- a/usr/src/uts/intel/daplt/Makefile +++ b/usr/src/uts/intel/daplt/Makefile @@ -23,6 +23,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -74,6 +75,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/daplt.o := SMOFF += all_func_returns,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/dca/Makefile b/usr/src/uts/intel/dca/Makefile index 034e2019c3..60cd04cd96 100644 --- a/usr/src/uts/intel/dca/Makefile +++ b/usr/src/uts/intel/dca/Makefile @@ -25,6 +25,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the DCA kCF provider. @@ -40,7 +41,7 @@ UTSBASE = ../.. # # Define the module and object file sets. # -MODULE = dca +MODULE = dca OBJECTS = $(DCA_OBJS:%=$(OBJS_DIR)/%) LINTS = $(DCA_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) @@ -69,6 +70,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/dca_rsa.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/devfs/Makefile b/usr/src/uts/intel/devfs/Makefile index c2a5b33098..9989fd4510 100644 --- a/usr/src/uts/intel/devfs/Makefile +++ b/usr/src/uts/intel/devfs/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # uts/intel/devfs/Makefile @@ -51,6 +52,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/devfs_vnops.o := SMOFF += signed + # # Define targets # diff --git a/usr/src/uts/intel/devinfo/Makefile b/usr/src/uts/intel/devinfo/Makefile index f9dd3056dd..98219434c6 100644 --- a/usr/src/uts/intel/devinfo/Makefile +++ b/usr/src/uts/intel/devinfo/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the devinfo kernel @@ -65,6 +66,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-clobbered +# needs work +$(OBJS_DIR)/devinfo.o := SMOFF += deref_check,strcpy_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/dld/Makefile b/usr/src/uts/intel/dld/Makefile index e0b736c8d2..a46b6046e9 100644 --- a/usr/src/uts/intel/dld/Makefile +++ b/usr/src/uts/intel/dld/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -71,6 +72,10 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/dld_proto.o := SMOFF += signed +$(OBJS_DIR)/dld_drv.o := SMOFF += cast_assign + # # Default build targets. # diff --git a/usr/src/uts/intel/dls/Makefile b/usr/src/uts/intel/dls/Makefile index dfa1cd74ec..8a267c7a1a 100644 --- a/usr/src/uts/intel/dls/Makefile +++ b/usr/src/uts/intel/dls/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -67,6 +68,10 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/dls_link.o := SMOFF += all_func_returns + + # # Default build targets. # diff --git a/usr/src/uts/intel/dnet/Makefile b/usr/src/uts/intel/dnet/Makefile index e793392b1f..ea395c5f63 100644 --- a/usr/src/uts/intel/dnet/Makefile +++ b/usr/src/uts/intel/dnet/Makefile @@ -24,11 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the dnet -# network driver kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -67,6 +63,10 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/dnet.o := SMOFF += index_overflow +$(OBJS_DIR)/dnet_mii.o := SMOFF += all_func_returns + LDFLAGS += -dy -N misc/mac # diff --git a/usr/src/uts/intel/doorfs/Makefile b/usr/src/uts/intel/doorfs/Makefile index f0bfcbee8b..289992ea9f 100644 --- a/usr/src/uts/intel/doorfs/Makefile +++ b/usr/src/uts/intel/doorfs/Makefile @@ -23,6 +23,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the doorfs driver kernel module. @@ -76,6 +77,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/door_sys.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/drm/Makefile b/usr/src/uts/intel/drm/Makefile index 1e48127d53..69182b1531 100644 --- a/usr/src/uts/intel/drm/Makefile +++ b/usr/src/uts/intel/drm/Makefile @@ -23,6 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the DRM (Direct Rendering @@ -56,6 +57,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-variable +# needs work +SMOFF += precedence,indenting,deref_check,all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/dtrace/Makefile b/usr/src/uts/intel/dtrace/Makefile index aeabf4a7e3..b3b5dd18ad 100644 --- a/usr/src/uts/intel/dtrace/Makefile +++ b/usr/src/uts/intel/dtrace/Makefile @@ -22,6 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. UTSBASE = ../.. @@ -49,6 +50,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/dtrace.o := SMOFF += signed_integer_overflow_check,deref_check + CPPFLAGS += -I$(SRC)/common/util ALL_TARGET = $(BINARY) $(SRC_CONFILE) diff --git a/usr/src/uts/intel/e1000g/Makefile b/usr/src/uts/intel/e1000g/Makefile index 7492e30935..9a82a0e698 100644 --- a/usr/src/uts/intel/e1000g/Makefile +++ b/usr/src/uts/intel/e1000g/Makefile @@ -22,13 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/e1000g/Makefile -# -# This makefile drives the production of the iprb -# network driver kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -71,6 +65,8 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_cc=-erroff=E_STATEMENT_NOT_REACHED +SMOFF += all_func_returns,indenting,shift_to_zero + LINTTAGS += -erroff=E_CONSTANT_CONDITION # diff --git a/usr/src/uts/intel/ecc/Makefile b/usr/src/uts/intel/ecc/Makefile index 3302d43e23..04db887bcc 100644 --- a/usr/src/uts/intel/ecc/Makefile +++ b/usr/src/uts/intel/ecc/Makefile @@ -24,11 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the ECc kef provider. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -76,6 +72,12 @@ CERRWARN += -_gcc=-Wno-empty-body CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-parentheses +# false positive +$(OBJS_DIR)/ecdecode.o := SMOFF += assign_vs_compare +$(OBJS_DIR)/ec.o := SMOFF += assign_vs_compare + +SMOFF += indenting,all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/ehci/Makefile b/usr/src/uts/intel/ehci/Makefile index 59ca760453..acae04f03c 100644 --- a/usr/src/uts/intel/ehci/Makefile +++ b/usr/src/uts/intel/ehci/Makefile @@ -22,9 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the ehci driver kernel module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -48,6 +46,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-switch +# needs work +SMOFF += deref_check,shift_to_zero + # # depends on misc/usba # diff --git a/usr/src/uts/intel/eibnx/Makefile b/usr/src/uts/intel/eibnx/Makefile index dfcbf6bdc7..417c96518d 100644 --- a/usr/src/uts/intel/eibnx/Makefile +++ b/usr/src/uts/intel/eibnx/Makefile @@ -22,6 +22,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the EoIB Nexus driver @@ -77,6 +78,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/enx_ibt.o := SMOFF += deref_check + # # Default build targets # diff --git a/usr/src/uts/intel/emlxs/Makefile b/usr/src/uts/intel/emlxs/Makefile index 46594b4d60..4910ca9fdd 100644 --- a/usr/src/uts/intel/emlxs/Makefile +++ b/usr/src/uts/intel/emlxs/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the emlxs driver kernel module. # @@ -95,6 +96,11 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +SMOFF += indenting,deref_check,all_func_returns + +# seems definitely wrong +$(OBJS_DIR)/emlxs_fcf.o := SMOFF += logical_instead_of_bitwise + # # Default build targets. # diff --git a/usr/src/uts/intel/emul64/Makefile b/usr/src/uts/intel/emul64/Makefile index da916f1dbc..f7fdba6865 100644 --- a/usr/src/uts/intel/emul64/Makefile +++ b/usr/src/uts/intel/emul64/Makefile @@ -21,6 +21,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the emul64 kernel # driver to testing hotplugging operations @@ -70,6 +71,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += indenting,shift_to_zero + # # Depends on scsi # diff --git a/usr/src/uts/intel/eoib/Makefile b/usr/src/uts/intel/eoib/Makefile index f650f1eeac..f9097dfa01 100644 --- a/usr/src/uts/intel/eoib/Makefile +++ b/usr/src/uts/intel/eoib/Makefile @@ -22,6 +22,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the EoIB Nexus driver @@ -66,6 +67,9 @@ CFLAGS += $(CCVERBOSE) CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/eib_ibt.o := SMOFF += deref_check + # # Depends on misc/ibtl # diff --git a/usr/src/uts/intel/fcip/Makefile b/usr/src/uts/intel/fcip/Makefile index f7187b5c4d..fd21612a52 100644 --- a/usr/src/uts/intel/fcip/Makefile +++ b/usr/src/uts/intel/fcip/Makefile @@ -23,10 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of fcip driver kernel module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +71,9 @@ LINTTAGS += -erroff=E_INCONS_VAL_TYPE_USED2 CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/fcoei/Makefile b/usr/src/uts/intel/fcoei/Makefile index 4f4c80292f..3a4aa6785c 100644 --- a/usr/src/uts/intel/fcoei/Makefile +++ b/usr/src/uts/intel/fcoei/Makefile @@ -22,8 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the fcoei driver for -# LEADVILLE. +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -40,6 +39,9 @@ LINTS = $(FCOEI_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) CONF_SRCDIR = $(UTSBASE)/common/io/fibre-channel/fca/fcoei +# needs work +SMOFF += all_func_returns + # # Include common rules. # diff --git a/usr/src/uts/intel/fcoet/Makefile b/usr/src/uts/intel/fcoet/Makefile index b253318455..8f214649f9 100644 --- a/usr/src/uts/intel/fcoet/Makefile +++ b/usr/src/uts/intel/fcoet/Makefile @@ -22,8 +22,7 @@ # # Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the fcoet driver for COMSTAR. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -39,6 +38,9 @@ OBJECTS = $(FCOET_OBJS:%=$(OBJS_DIR)/%) LINTS = $(FCOET_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) +# needs work +SMOFF += all_func_returns,shift_to_zero + # # Include common rules. # diff --git a/usr/src/uts/intel/fcp/Makefile b/usr/src/uts/intel/fcp/Makefile index 9f22448393..1dfb19035f 100644 --- a/usr/src/uts/intel/fcp/Makefile +++ b/usr/src/uts/intel/fcp/Makefile @@ -23,8 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of fcp driver kernel module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -69,6 +68,8 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/fct/Makefile b/usr/src/uts/intel/fct/Makefile index b61a18873d..ba4aa67b61 100644 --- a/usr/src/uts/intel/fct/Makefile +++ b/usr/src/uts/intel/fct/Makefile @@ -21,8 +21,7 @@ # # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the fct driver for -# COMSTAR. +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +73,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += strcpy_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/fctl/Makefile b/usr/src/uts/intel/fctl/Makefile index e325f915e2..5d6dd01b08 100644 --- a/usr/src/uts/intel/fctl/Makefile +++ b/usr/src/uts/intel/fctl/Makefile @@ -23,12 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "@(#)Makefile 1.10 08/07/25 SMI" -# -# This makefile drives the production of fctl driver kernel module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -70,6 +65,9 @@ LINTTAGS += -erroff=E_SUSPICIOUS_COMPARISON CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/fctl.o := SMOFF += all_func_returns,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/fd/Makefile b/usr/src/uts/intel/fd/Makefile index 31f7be3535..fd08395482 100644 --- a/usr/src/uts/intel/fd/Makefile +++ b/usr/src/uts/intel/fd/Makefile @@ -24,12 +24,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# -# This makefile drives the production of the floppy driver -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -72,6 +67,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/fd.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/fp/Makefile b/usr/src/uts/intel/fp/Makefile index 55f405d69f..63bb075df0 100644 --- a/usr/src/uts/intel/fp/Makefile +++ b/usr/src/uts/intel/fp/Makefile @@ -23,12 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "@(#)Makefile 1.10 08/07/25 SMI" -# -# This makefile drives the production of fp driver kernel module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -79,6 +74,9 @@ LINTTAGS += -erroff=E_STATIC_UNUSED CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/fp.o := SMOFF += all_func_returns,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/gen_drv/Makefile b/usr/src/uts/intel/gen_drv/Makefile index 7776a6d08b..bf58c6b4d7 100644 --- a/usr/src/uts/intel/gen_drv/Makefile +++ b/usr/src/uts/intel/gen_drv/Makefile @@ -22,11 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# -# This makefile drives the production of the gen_drv kernel -# driver to testing hotplugging operations -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -64,6 +60,9 @@ LINTTAGS += -erroff=E_STATIC_UNUSED CERRWARN += -_gcc=-Wno-unused-variable +# needs work +$(OBJS_DIR)/gen_drv.o := SMOFF += indenting,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/genunix/Makefile b/usr/src/uts/intel/genunix/Makefile index 897789505c..3603bce20a 100644 --- a/usr/src/uts/intel/genunix/Makefile +++ b/usr/src/uts/intel/genunix/Makefile @@ -23,6 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the generic @@ -110,6 +111,24 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-clobbered CERRWARN += -_gcc=-Wno-empty-body +# false positives +SMOFF += index_overflow +$(OBJS_DIR)/seg_vn.o := SMOFF += deref_check +$(OBJS_DIR)/ddi_intr_irm.o := SMOFF += deref_check + +# need work still +SMOFF += signed,indenting,all_func_returns +$(OBJS_DIR)/clock_highres.o := SMOFF += signed_integer_overflow_check +$(OBJS_DIR)/evchannels.o := SMOFF += allocating_enough_data +$(OBJS_DIR)/klpd.o := SMOFF += cast_assign +$(OBJS_DIR)/lookup.o := SMOFF += strcpy_overflow +$(OBJS_DIR)/process.o := SMOFF += or_vs_and +$(OBJS_DIR)/sunpci.o := SMOFF += deref_check +$(OBJS_DIR)/timers.o := SMOFF += signed_integer_overflow_check + +# definitely wrong +$(OBJS_DIR)/acl_common.o := SMOFF += or_vs_and + # # Ensure that lint sees 'struct cpu' containing a fully declared # embedded 'struct machcpu' diff --git a/usr/src/uts/intel/hermon/Makefile b/usr/src/uts/intel/hermon/Makefile index 1949d8f6ec..bfcc27f547 100644 --- a/usr/src/uts/intel/hermon/Makefile +++ b/usr/src/uts/intel/hermon/Makefile @@ -23,12 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the hermon InfiniBand module -# -# intel architecture dependent -# -# uts/intel/hermon/Makefile -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -78,6 +73,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/hme/Makefile b/usr/src/uts/intel/hme/Makefile index ab1f31df18..d84a20ab87 100644 --- a/usr/src/uts/intel/hme/Makefile +++ b/usr/src/uts/intel/hme/Makefile @@ -24,9 +24,8 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the hme driver -# kernel module. -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -63,6 +62,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/hme.o := SMOFF += indenting,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/hook/Makefile b/usr/src/uts/intel/hook/Makefile index 91d0bda783..ab9f0b8e04 100644 --- a/usr/src/uts/intel/hook/Makefile +++ b/usr/src/uts/intel/hook/Makefile @@ -24,6 +24,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the hook driver kernel module. @@ -52,6 +53,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/hook.o := SMOFF += all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/hpcsvc/Makefile b/usr/src/uts/intel/hpcsvc/Makefile index 9aae68f8f1..0a219218ce 100644 --- a/usr/src/uts/intel/hpcsvc/Makefile +++ b/usr/src/uts/intel/hpcsvc/Makefile @@ -24,13 +24,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# -# This makefile drives the production of the hpcsvc "misc" -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -65,6 +59,9 @@ DEBUG_DEFS += $(DEBUG_FLGS) CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/hpcsvc.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/hsfs/Makefile b/usr/src/uts/intel/hsfs/Makefile index 09099a698c..10452c9754 100644 --- a/usr/src/uts/intel/hsfs/Makefile +++ b/usr/src/uts/intel/hsfs/Makefile @@ -25,11 +25,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the hsfs file system -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -79,6 +75,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-switch +# needs work +$(OBJS_DIR)/hsfs_vnops.o := SMOFF += 64bit_shift,signed + # # Default build targets. # diff --git a/usr/src/uts/intel/hxge/Makefile b/usr/src/uts/intel/hxge/Makefile index 3f2444702f..18e7597c86 100644 --- a/usr/src/uts/intel/hxge/Makefile +++ b/usr/src/uts/intel/hxge/Makefile @@ -22,9 +22,8 @@ # # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the Sun -# 10G hxge Ethernet leaf driver kernel module. -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -87,6 +86,8 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +SMOFF += deref_check,logical_instead_of_bitwise + # # Driver depends on mac & IP # diff --git a/usr/src/uts/intel/i40e/Makefile b/usr/src/uts/intel/i40e/Makefile index 9d6bf553ec..dd7a4940a6 100644 --- a/usr/src/uts/intel/i40e/Makefile +++ b/usr/src/uts/intel/i40e/Makefile @@ -10,7 +10,7 @@ # # -# Copyright 2017 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # UTSBASE = ../.. @@ -43,6 +43,9 @@ LINTTAGS += -erroff=E_ENUM_VAL_OVERFLOWS_INT_MAX # CERRWARN += -_cc=-erroff=E_ENUM_VAL_OVERFLOWS_INT_MAX +# 3rd party code +SMOFF += all_func_returns + LDFLAGS += -dy -N misc/mac .KEEP_STATE: diff --git a/usr/src/uts/intel/i8042/Makefile b/usr/src/uts/intel/i8042/Makefile index 0a67c8d5b0..0f0062d1f6 100644 --- a/usr/src/uts/intel/i8042/Makefile +++ b/usr/src/uts/intel/i8042/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the i8042 nexus driver @@ -64,6 +65,9 @@ LINTTAGS += -erroff=E_STATIC_UNUSED CERRWARN += -_gcc=-Wno-unused-function +# needs work +$(OBJS_DIR)/i8042.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/i915/Makefile b/usr/src/uts/intel/i915/Makefile index e0c2a3002b..b71b8a2072 100644 --- a/usr/src/uts/intel/i915/Makefile +++ b/usr/src/uts/intel/i915/Makefile @@ -23,6 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # uts/intel/drm/Makefile @@ -59,6 +60,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMATCH=off + # # Re-define targets # diff --git a/usr/src/uts/intel/ibcm/Makefile b/usr/src/uts/intel/ibcm/Makefile index 16799ca83f..38b6520778 100644 --- a/usr/src/uts/intel/ibcm/Makefile +++ b/usr/src/uts/intel/ibcm/Makefile @@ -22,11 +22,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/ibcm/Makefile -# -# This makefile drives the production of the ibcm kernel -# module. SPARC architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -70,6 +66,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-value +# needs work +SMATCH=off + # # depends on misc/ibtl and misc/ibmf # diff --git a/usr/src/uts/intel/ibmf/Makefile b/usr/src/uts/intel/ibmf/Makefile index 6a8efa3937..8fe06342ed 100644 --- a/usr/src/uts/intel/ibmf/Makefile +++ b/usr/src/uts/intel/ibmf/Makefile @@ -22,11 +22,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# This makefile drives the production of the ibmf kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -75,6 +71,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/ibp/Makefile b/usr/src/uts/intel/ibp/Makefile index f9525a17d2..536aae0c8f 100644 --- a/usr/src/uts/intel/ibp/Makefile +++ b/usr/src/uts/intel/ibp/Makefile @@ -21,7 +21,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -62,6 +62,9 @@ LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-switch +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/ibtl/Makefile b/usr/src/uts/intel/ibtl/Makefile index ecf5bdd849..7d0343b89c 100644 --- a/usr/src/uts/intel/ibtl/Makefile +++ b/usr/src/uts/intel/ibtl/Makefile @@ -22,12 +22,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# -# This makefile drives the production of the ibtl kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -58,9 +53,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) # Overrides. # -# -# lint pass one enforcement -# +# +# lint pass one enforcement +# CFLAGS += $(CCVERBOSE) # @@ -80,6 +75,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-value +# needs work +$(OBJS_DIR)/ibtl_impl.o := SMOFF += precedence + # # Default build targets. # diff --git a/usr/src/uts/intel/icmp/Makefile b/usr/src/uts/intel/icmp/Makefile index 259530f9dc..4a88d2a885 100644 --- a/usr/src/uts/intel/icmp/Makefile +++ b/usr/src/uts/intel/icmp/Makefile @@ -23,6 +23,7 @@ # # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the icmp IP driver # @@ -77,6 +78,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV +# needs work +$(OBJS_DIR)/icmpddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/icmp6/Makefile b/usr/src/uts/intel/icmp6/Makefile index 0ee98acb50..19b3f4374e 100644 --- a/usr/src/uts/intel/icmp6/Makefile +++ b/usr/src/uts/intel/icmp6/Makefile @@ -23,12 +23,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the icmp6 IP driver -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -61,6 +56,8 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) # LDFLAGS += -dy -Ndrv/ip -Ndrv/ip6 -Ndrv/icmp +# needs work +$(OBJS_DIR)/icmp6ddi.o := SMOFF += index_overflow # # Default build targets. # diff --git a/usr/src/uts/intel/idm/Makefile b/usr/src/uts/intel/idm/Makefile index 99f4bb5cc3..703ca57dd3 100644 --- a/usr/src/uts/intel/idm/Makefile +++ b/usr/src/uts/intel/idm/Makefile @@ -24,11 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the idm kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -66,6 +62,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # Include INC_PATH += -I$(SRC)/common/hdcrc diff --git a/usr/src/uts/intel/igb/Makefile b/usr/src/uts/intel/igb/Makefile index 2d4a1f3556..da31ce8a0a 100644 --- a/usr/src/uts/intel/igb/Makefile +++ b/usr/src/uts/intel/igb/Makefile @@ -22,13 +22,7 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/igb/Makefile -# -# This makefile drives the production of the igb -# network driver kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -58,6 +52,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_cc=-erroff=E_STATEMENT_NOT_REACHED +# needs work +SMOFF += all_func_returns,indenting + CFLAGS += -I$(UTSBASE)/common/io/e1000api CFLAGS += -I$(UTSBASE)/common/io/igb diff --git a/usr/src/uts/intel/intel_nb5000/Makefile b/usr/src/uts/intel/intel_nb5000/Makefile index 55ee9be813..54c012824e 100644 --- a/usr/src/uts/intel/intel_nb5000/Makefile +++ b/usr/src/uts/intel/intel_nb5000/Makefile @@ -21,6 +21,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # Intel 5000/5100/5400/7300 chipset memory controller hub (MCH) module @@ -63,6 +64,9 @@ LDFLAGS += -dy -N drv/smbios CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/ip/Makefile b/usr/src/uts/intel/ip/Makefile index c0acd57445..db2647e0a3 100644 --- a/usr/src/uts/intel/ip/Makefile +++ b/usr/src/uts/intel/ip/Makefile @@ -22,8 +22,9 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # -# This makefile drives the production of the ip driver +# This makefile drives the production of the ip driver # kernel module. # # intel implementation architecture dependent @@ -68,6 +69,19 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits +# false positives +SMOFF += index_overflow + +# need work still +$(OBJS_DIR)/igmp.o := SMOFF += shift_to_zero +$(OBJS_DIR)/tnet.o := SMOFF += shift_to_zero +SMOFF += signed,all_func_returns +SMOFF += signed_integer_overflow_check + +# definitely wrong +$(OBJS_DIR)/ip_input.o := SMOFF += or_vs_and +$(OBJS_DIR)/ip6_input.o := SMOFF += or_vs_and + # # To get the BPF header files included by ipnet.h # @@ -78,7 +92,7 @@ INC_PATH += -I$(UTSBASE)/common/io/bpf # swrand as it needs random numbers early on during boot before # kCF subsystem can load swrand. # -LDFLAGS += -dy -Nmisc/md5 -Ncrypto/swrand -Nmisc/hook -Nmisc/neti +LDFLAGS += -dy -Nmisc/md5 -Ncrypto/swrand -Nmisc/hook -Nmisc/neti # # For now, disable these lint checks; maintainers should endeavor diff --git a/usr/src/uts/intel/ip6/Makefile b/usr/src/uts/intel/ip6/Makefile index 0e245bcd4a..c45b28ffa0 100644 --- a/usr/src/uts/intel/ip6/Makefile +++ b/usr/src/uts/intel/ip6/Makefile @@ -23,13 +23,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the ip6 driver -# kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -62,6 +56,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) # LDFLAGS += -dy -Ndrv/ip +# needs work +$(OBJS_DIR)/ip6ddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/ipf/Makefile b/usr/src/uts/intel/ipf/Makefile index 046a6c223d..78cd65310f 100644 --- a/usr/src/uts/intel/ipf/Makefile +++ b/usr/src/uts/intel/ipf/Makefile @@ -22,13 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/ipf/Makefile -# -# This makefile drives the production of the ipf driver -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -78,6 +72,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-empty-body +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/ipgpc/Makefile b/usr/src/uts/intel/ipgpc/Makefile index 5b005a0022..6de28b7aed 100644 --- a/usr/src/uts/intel/ipgpc/Makefile +++ b/usr/src/uts/intel/ipgpc/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the IP generic packet classifier @@ -72,6 +73,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/filters.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/ipsecah/Makefile b/usr/src/uts/intel/ipsecah/Makefile index 90870c6a0a..1111d5fe5d 100644 --- a/usr/src/uts/intel/ipsecah/Makefile +++ b/usr/src/uts/intel/ipsecah/Makefile @@ -23,9 +23,10 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # -# This makefile drives the production of the ipsecah driver +# This makefile drives the production of the ipsecah driver # kernel module. # # intel implementation architecture dependent @@ -76,6 +77,11 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/ipsecahddi.o := SMOFF += index_overflow +$(OBJS_DIR)/ipsecah.o := SMOFF += deref_check +$(OBJS_DIR)/sadb.o := SMOFF += signed_integer_overflow_check,deref_check,indenting,shift_to_zero + # # Default build targets. # diff --git a/usr/src/uts/intel/ipsecesp/Makefile b/usr/src/uts/intel/ipsecesp/Makefile index 68cf590888..7e779dd409 100644 --- a/usr/src/uts/intel/ipsecesp/Makefile +++ b/usr/src/uts/intel/ipsecesp/Makefile @@ -23,6 +23,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ipsecesp driver @@ -74,6 +75,10 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/ipsecespddi.o := SMOFF += index_overflow +$(OBJS_DIR)/ipsecesp.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/ipw/Makefile b/usr/src/uts/intel/ipw/Makefile index 4363bc43c4..8b29857bda 100644 --- a/usr/src/uts/intel/ipw/Makefile +++ b/usr/src/uts/intel/ipw/Makefile @@ -22,6 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ipw driver kernel module. @@ -37,7 +38,7 @@ UTSBASE = ../.. # # Define the module and object file sets. # -MODULE = ipw +MODULE = ipw OBJECTS = $(IPW_OBJS:%=$(OBJS_DIR)/%) LINTS = $(IPW_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) @@ -52,6 +53,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/ipw2100.o := SMOFF += deref_check + # # Define targets # diff --git a/usr/src/uts/intel/iscsi/Makefile b/usr/src/uts/intel/iscsi/Makefile index ea010ebcc0..a9f2dc2140 100644 --- a/usr/src/uts/intel/iscsi/Makefile +++ b/usr/src/uts/intel/iscsi/Makefile @@ -23,6 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of iSCSI initiator Driver @@ -74,6 +75,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/iscsit/Makefile b/usr/src/uts/intel/iscsit/Makefile index 73b9139ec9..94bb0e9091 100644 --- a/usr/src/uts/intel/iscsit/Makefile +++ b/usr/src/uts/intel/iscsit/Makefile @@ -21,14 +21,11 @@ # # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the iscsit pseudo-driver for -# COMSTAR. +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). # - - UTSBASE = ../.. ARCHDIR:sh = cd ..; basename `pwd` @@ -66,6 +63,10 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMOFF += cast_assign,strcpy_overflow + + # # Default build targets. # diff --git a/usr/src/uts/intel/iser/Makefile b/usr/src/uts/intel/iser/Makefile index d3e7ffc8e2..0a8f4a2e2f 100644 --- a/usr/src/uts/intel/iser/Makefile +++ b/usr/src/uts/intel/iser/Makefile @@ -22,6 +22,8 @@ # # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. +# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -45,6 +47,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/iser_ib.o := SMOFF += deref_check + # # Define targets # diff --git a/usr/src/uts/intel/iwi/Makefile b/usr/src/uts/intel/iwi/Makefile index 4caf4cf69c..926600b957 100755 --- a/usr/src/uts/intel/iwi/Makefile +++ b/usr/src/uts/intel/iwi/Makefile @@ -22,13 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the ipw driver kernel module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -38,7 +32,7 @@ UTSBASE = ../.. # # Define the module and object file sets. # -MODULE = iwi +MODULE = iwi OBJECTS = $(IWI_OBJS:%=$(OBJS_DIR)/%) LINTS = $(IWI_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) @@ -56,7 +50,10 @@ LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) CPPFLAGS += -I. -D_KERNEL -LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Ndrv/random -Ndrv/ip +LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Ndrv/random -Ndrv/ip + +# needs work +$(OBJS_DIR)/ipw2200.o := SMOFF += deref_check # # Default build targets. diff --git a/usr/src/uts/intel/iwk/Makefile b/usr/src/uts/intel/iwk/Makefile index 91668f9b3c..9cb38a51b0 100644 --- a/usr/src/uts/intel/iwk/Makefile +++ b/usr/src/uts/intel/iwk/Makefile @@ -22,6 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the iwk driver kernel module. @@ -37,7 +38,7 @@ UTSBASE = ../.. # # Define the module and object file sets. # -MODULE = iwk +MODULE = iwk OBJECTS = $(IWK_OBJS:%=$(OBJS_DIR)/%) LINTS = $(IWK_OBJS:%.o=$(LINTS_DIR)/%.ln) ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE) @@ -61,11 +62,14 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CPPFLAGS += -I. -D_KERNEL -DIWL=4965 -LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Ndrv/random -Ndrv/ip +LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Ndrv/random -Ndrv/ip CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/iwk2.o := SMOFF += precedence + # # Default build targets. # diff --git a/usr/src/uts/intel/iwn/Makefile b/usr/src/uts/intel/iwn/Makefile index 29ce82f9ac..9cc64b5c37 100644 --- a/usr/src/uts/intel/iwn/Makefile +++ b/usr/src/uts/intel/iwn/Makefile @@ -12,6 +12,7 @@ # # Copyright 2016 Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the iwn driver kernel module. @@ -55,6 +56,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOTFIRMWARE) LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Ndrv/random -Ndrv/ip +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/ixgbe/Makefile b/usr/src/uts/intel/ixgbe/Makefile index c0408d0667..4b4cc45f6e 100644 --- a/usr/src/uts/intel/ixgbe/Makefile +++ b/usr/src/uts/intel/ixgbe/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # Copyright 2016 OmniTI Computer Consulting, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # uts/intel/ixgbe/Makefile # @@ -60,6 +61,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-value CERRWARN += -_cc=-erroff=E_STATEMENT_NOT_REACHED +# 3rd party code +SMOFF += all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/kcf/Makefile b/usr/src/uts/intel/kcf/Makefile index 1e3354a29e..3357077237 100644 --- a/usr/src/uts/intel/kcf/Makefile +++ b/usr/src/uts/intel/kcf/Makefile @@ -22,11 +22,7 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the Kernel Cryptographic -# Framework core module. -# -# Intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +70,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMOFF += all_func_returns,signed_integer_overflow_check + # # Default build targets. # diff --git a/usr/src/uts/intel/keysock/Makefile b/usr/src/uts/intel/keysock/Makefile index 99a1f7b1d8..2670a2e7b6 100644 --- a/usr/src/uts/intel/keysock/Makefile +++ b/usr/src/uts/intel/keysock/Makefile @@ -23,9 +23,10 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # -# This makefile drives the production of the keysock driver +# This makefile drives the production of the keysock driver # kernel module. # # intel implementation architecture dependent @@ -75,6 +76,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-unused-variable +# needs work +$(OBJS_DIR)/keysockddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/kgssapi/Makefile b/usr/src/uts/intel/kgssapi/Makefile index d5c69eb049..ff27600ef6 100644 --- a/usr/src/uts/intel/kgssapi/Makefile +++ b/usr/src/uts/intel/kgssapi/Makefile @@ -25,10 +25,8 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the kgssapi kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -70,6 +68,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/gssd_clnt_stubs.o := SMOFF += indenting,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/kiconv_ja/Makefile b/usr/src/uts/intel/kiconv_ja/Makefile index a72ae6e2a0..739a1768b6 100644 --- a/usr/src/uts/intel/kiconv_ja/Makefile +++ b/usr/src/uts/intel/kiconv_ja/Makefile @@ -24,12 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the kiconv_ja kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -68,6 +63,9 @@ CFLAGS += $(CCVERBOSE) # LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW +# smatch not happy with this source +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/klmmod/Makefile b/usr/src/uts/intel/klmmod/Makefile index 43e24b29b1..1ccdaf6b1e 100644 --- a/usr/src/uts/intel/klmmod/Makefile +++ b/usr/src/uts/intel/klmmod/Makefile @@ -24,11 +24,7 @@ # # Copyright (c) 2012 by Delphix. All rights reserved. # -# This makefile drives the production of the network lock manager server -# specific kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -67,6 +63,9 @@ CTFMRGFLAGS += -f # CERRWARN += -_gcc=-Wno-switch +# needs work +$(OBJS_DIR)/nlm_service.o := SMOFF += signed_integer_overflow_check + # # Default build targets. # diff --git a/usr/src/uts/intel/kmech_krb5/Makefile b/usr/src/uts/intel/kmech_krb5/Makefile index 1423cbc758..27b311c000 100644 --- a/usr/src/uts/intel/kmech_krb5/Makefile +++ b/usr/src/uts/intel/kmech_krb5/Makefile @@ -24,6 +24,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # This makefile drives the production of the gl_kmech_krb5 kernel module. # @@ -73,6 +74,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/llc1/Makefile b/usr/src/uts/intel/llc1/Makefile index cd5a74a1d7..1ad058e06c 100644 --- a/usr/src/uts/intel/llc1/Makefile +++ b/usr/src/uts/intel/llc1/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the Sound-Blaster driver @@ -68,6 +69,9 @@ LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/llc1.o := SMOFF += no_if_block,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/mac/Makefile b/usr/src/uts/intel/mac/Makefile index 93d232cad2..652e90aa67 100644 --- a/usr/src/uts/intel/mac/Makefile +++ b/usr/src/uts/intel/mac/Makefile @@ -22,10 +22,8 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the mac driver -# kernel module. -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -67,6 +65,13 @@ CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-unused-variable +# needs work +SMOFF += all_func_returns +$(OBJS_DIR)/mac.o := SMOFF += deref_check +$(OBJS_DIR)/mac_util.o := SMOFF += signed + +# false positive +$(OBJS_DIR)/mac_sched.o := SMOFF += assign_vs_compare # # Default build targets. # diff --git a/usr/src/uts/intel/mega_sas/Makefile b/usr/src/uts/intel/mega_sas/Makefile index 20e4cf8e5d..3011ffa0f9 100644 --- a/usr/src/uts/intel/mega_sas/Makefile +++ b/usr/src/uts/intel/mega_sas/Makefile @@ -21,6 +21,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # uts/intel/mega_sas/Makefile @@ -63,6 +64,9 @@ LDFLAGS += -dy -Nmisc/scsi CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/megaraid_sas.o := SMOFF += snprintf_overflow,all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/mii/Makefile b/usr/src/uts/intel/mii/Makefile index 7f2167f18c..cd987a3a31 100644 --- a/usr/src/uts/intel/mii/Makefile +++ b/usr/src/uts/intel/mii/Makefile @@ -24,8 +24,7 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the mii support module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -57,6 +56,9 @@ LDFLAGS += -dy -N misc/mac CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/mpt_sas/Makefile b/usr/src/uts/intel/mpt_sas/Makefile index 9886d6ccd5..53e66fc2f2 100644 --- a/usr/src/uts/intel/mpt_sas/Makefile +++ b/usr/src/uts/intel/mpt_sas/Makefile @@ -21,10 +21,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the mpt_sas driver kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -59,6 +56,10 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/mptsas_raid.o := SMOFF += index_overflow +$(OBJS_DIR)/mptsas.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/mr_sas/Makefile b/usr/src/uts/intel/mr_sas/Makefile index a3dbbd5f89..d2771c91c9 100644 --- a/usr/src/uts/intel/mr_sas/Makefile +++ b/usr/src/uts/intel/mr_sas/Makefile @@ -23,10 +23,7 @@ # # uts/intel/mr_sas/Makefile # -# This makefile drives the production of the mr_sas driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -63,6 +60,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/mwl/Makefile b/usr/src/uts/intel/mwl/Makefile index 2c268ad0b6..3606a28511 100644 --- a/usr/src/uts/intel/mwl/Makefile +++ b/usr/src/uts/intel/mwl/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the rwd driver kernel module. @@ -67,6 +68,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-value +# needs work +SMOFF += return_cast + # # Default build targets. # diff --git a/usr/src/uts/intel/myri10ge/Makefile b/usr/src/uts/intel/myri10ge/Makefile index 761dcf6bf1..b12ef0d581 100644 --- a/usr/src/uts/intel/myri10ge/Makefile +++ b/usr/src/uts/intel/myri10ge/Makefile @@ -21,6 +21,7 @@ # # Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -55,7 +56,8 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) # LINTTAGS += -DSOLARIS_S11 -erroff=E_STATIC_UNUSED -#COPTIMIZE = -xO4 +# needs work +SMATCH=off INC_PATH += -I$(UTSBASE)/common/io/myri10ge -I$(UTSBASE)/common/io/myri10ge/firmware diff --git a/usr/src/uts/intel/nca/Makefile b/usr/src/uts/intel/nca/Makefile index beb7e0457f..457ac86abc 100644 --- a/usr/src/uts/intel/nca/Makefile +++ b/usr/src/uts/intel/nca/Makefile @@ -24,13 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the nca driver -# kernel module. -# -# Intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -71,6 +65,9 @@ LDFLAGS += -dy -Nfs/sockfs -Ndrv/ip # LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN +# needs work +$(OBJS_DIR)/ncaddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/net80211/Makefile b/usr/src/uts/intel/net80211/Makefile index a08ee52384..525570481e 100644 --- a/usr/src/uts/intel/net80211/Makefile +++ b/usr/src/uts/intel/net80211/Makefile @@ -23,6 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This file makes the atheros driver for an intel system @@ -69,6 +70,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/nfs/Makefile b/usr/src/uts/intel/nfs/Makefile index e3524c9718..c7eb9b02a1 100644 --- a/usr/src/uts/intel/nfs/Makefile +++ b/usr/src/uts/intel/nfs/Makefile @@ -25,11 +25,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the nfs file system -# kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -90,6 +86,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-empty-body +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/nfs_dlboot/Makefile b/usr/src/uts/intel/nfs_dlboot/Makefile index fcd505e38e..896762d6ab 100644 --- a/usr/src/uts/intel/nfs_dlboot/Makefile +++ b/usr/src/uts/intel/nfs_dlboot/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the dlboot_proto @@ -75,6 +76,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/nfs_dlinet.o := SMOFF += indenting,all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/nfssrv/Makefile b/usr/src/uts/intel/nfssrv/Makefile index 8cd5005557..5b2d459a8f 100644 --- a/usr/src/uts/intel/nfssrv/Makefile +++ b/usr/src/uts/intel/nfssrv/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the nfs server-specific @@ -82,6 +83,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-switch +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/nge/Makefile b/usr/src/uts/intel/nge/Makefile index d2be242a1c..fbca64a4cb 100644 --- a/usr/src/uts/intel/nge/Makefile +++ b/usr/src/uts/intel/nge/Makefile @@ -22,9 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the nvidia toe/ge -# driver. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +72,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/nsmb/Makefile b/usr/src/uts/intel/nsmb/Makefile index c277170dc1..891de62ff4 100644 --- a/usr/src/uts/intel/nsmb/Makefile +++ b/usr/src/uts/intel/nsmb/Makefile @@ -24,6 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # intel architecture dependent @@ -99,6 +100,12 @@ LINTTAGS += -erroff=E_BAD_FORMAT_ARG_TYPE2 LGREP.nsmb = egrep -v ' ignored: (mb_init|mb_put|md_get)' LTAIL += 2>&1 | $(LGREP.2) | $(LGREP.nsmb) || true +# same for smatch +SMOFF += all_func_returns + +# needs work +SMOFF += signed,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/ntxn/Makefile b/usr/src/uts/intel/ntxn/Makefile index 8843e8bfe5..092861743e 100644 --- a/usr/src/uts/intel/ntxn/Makefile +++ b/usr/src/uts/intel/ntxn/Makefile @@ -23,10 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the Neterion Xframe -# 10G Ethernet (XGE) driver module in x86 systems -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -73,6 +70,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMOFF += all_func_returns + # # # Default build targets. diff --git a/usr/src/uts/intel/nv_sata/Makefile b/usr/src/uts/intel/nv_sata/Makefile index 9723cca3cc..df6a1b50fd 100644 --- a/usr/src/uts/intel/nv_sata/Makefile +++ b/usr/src/uts/intel/nv_sata/Makefile @@ -23,6 +23,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -75,6 +77,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/nv_sata.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/nxge/Makefile b/usr/src/uts/intel/nxge/Makefile index 7346a0b84b..61e3982ef5 100644 --- a/usr/src/uts/intel/nxge/Makefile +++ b/usr/src/uts/intel/nxge/Makefile @@ -22,10 +22,8 @@ # # Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved. # -# -# This makefile drives the production of the Sun NIU -# 10G/1G Ethernet leaf driver kernel module. -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -92,6 +90,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMATCH=off + # # Driver depends on mac & IP # diff --git a/usr/src/uts/intel/objfs/Makefile b/usr/src/uts/intel/objfs/Makefile index 9c8a6e9bbd..fad14923da 100644 --- a/usr/src/uts/intel/objfs/Makefile +++ b/usr/src/uts/intel/objfs/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the object file system @@ -72,6 +73,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/objfs_vfs.o := SMOFF += signed_integer_overflow_check + # # Default build targets. # diff --git a/usr/src/uts/intel/openeepr/Makefile b/usr/src/uts/intel/openeepr/Makefile index 762cd55a0c..1f7608e4ec 100644 --- a/usr/src/uts/intel/openeepr/Makefile +++ b/usr/src/uts/intel/openeepr/Makefile @@ -23,6 +23,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the openeepr driver @@ -68,6 +69,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/openprom.o := SMOFF += cast_assign,strcpy_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/pcfs/Makefile b/usr/src/uts/intel/pcfs/Makefile index 59d2650970..a9e4f7b085 100644 --- a/usr/src/uts/intel/pcfs/Makefile +++ b/usr/src/uts/intel/pcfs/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the DOS file system @@ -68,6 +69,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-function +# needs work +SMATCH=off + # # Define targets # diff --git a/usr/src/uts/intel/pcic/Makefile b/usr/src/uts/intel/pcic/Makefile index 100973ecf1..5312ac7c21 100644 --- a/usr/src/uts/intel/pcic/Makefile +++ b/usr/src/uts/intel/pcic/Makefile @@ -23,6 +23,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the PCIC style PCMCIA adapter @@ -78,6 +79,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += no_if_block,indenting,all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/pcicfg/Makefile b/usr/src/uts/intel/pcicfg/Makefile index 90e0ba1970..68e00c9d1f 100644 --- a/usr/src/uts/intel/pcicfg/Makefile +++ b/usr/src/uts/intel/pcicfg/Makefile @@ -23,12 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the kernel/misc/pcicfg module -# (PCI configurator module) for PCI hotplug support in PCI nexus -# drivers. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -80,6 +75,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/pcicfg.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/pcieb/Makefile b/usr/src/uts/intel/pcieb/Makefile index be0357f8b2..3b9f363520 100644 --- a/usr/src/uts/intel/pcieb/Makefile +++ b/usr/src/uts/intel/pcieb/Makefile @@ -24,9 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the pcieb driver kernel -# module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -77,6 +75,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-unused-value +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/pcihp/Makefile b/usr/src/uts/intel/pcihp/Makefile index 6b8a0df43a..2d2b09a417 100644 --- a/usr/src/uts/intel/pcihp/Makefile +++ b/usr/src/uts/intel/pcihp/Makefile @@ -23,13 +23,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -#ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the kernel/misc/pcihp module -# for PCI hotplug support in PCI nexus drivers. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -69,6 +63,9 @@ LDFLAGS += -dy -Nmisc/busra -Nmisc/hpcsvc LINTTAGS += -erroff=E_SUSPICIOUS_COMPARISON LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN +# needs work +SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/pcmcia/Makefile b/usr/src/uts/intel/pcmcia/Makefile index b50059c5ed..d48374ff64 100644 --- a/usr/src/uts/intel/pcmcia/Makefile +++ b/usr/src/uts/intel/pcmcia/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This file makes the pcmcia nexus for an intel system @@ -83,6 +84,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/pmcs/Makefile b/usr/src/uts/intel/pmcs/Makefile index 3bc177d9cf..62243ffa9f 100644 --- a/usr/src/uts/intel/pmcs/Makefile +++ b/usr/src/uts/intel/pmcs/Makefile @@ -20,11 +20,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the pmcs driver kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -72,6 +68,8 @@ CERRWARN += -_gcc=-Wno-unused-value CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off # # Default build targets. diff --git a/usr/src/uts/intel/portfs/Makefile b/usr/src/uts/intel/portfs/Makefile index acd107022c..2d784dcb70 100644 --- a/usr/src/uts/intel/portfs/Makefile +++ b/usr/src/uts/intel/portfs/Makefile @@ -23,6 +23,8 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # This makefile drives the production of the portfs driver kernel module. @@ -75,6 +77,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/port_fop.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/procfs/Makefile b/usr/src/uts/intel/procfs/Makefile index 21057b40d8..1e5fc27935 100644 --- a/usr/src/uts/intel/procfs/Makefile +++ b/usr/src/uts/intel/procfs/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the procfs file system @@ -76,6 +77,15 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized + +# needs work +$(OBJS_DIR)/prsubr.o := SMOFF += all_func_returns +$(OBJS_DIR)/prcontrol.o := SMOFF += all_func_returns +$(OBJS_DIR)/prioctl.o := SMOFF += signed + +# false positives +$(OBJS_DIR)/prvnops.o := SMOFF += strcpy_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/qede/Makefile b/usr/src/uts/intel/qede/Makefile index 3976cef74b..1ac554f074 100644 --- a/usr/src/uts/intel/qede/Makefile +++ b/usr/src/uts/intel/qede/Makefile @@ -10,7 +10,7 @@ # # -# Copyright (c) 2017 Joyent, Inc. +# Copyright (c) 2018, Joyent, Inc. # UTSBASE = ../.. @@ -48,6 +48,12 @@ CPPFLAGS += -I$(UTSBASE)/common/io/qede/579xx/hsi/mcp CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function +# 3rd party module +SMOFF += all_func_returns,indenting,no_if_block,deref_check,testing_index_after_use + +# real bug in qede_multicast() +$(OBJS_DIR)/qede_gld.o := SMOFF += assign_vs_compare + ALL_TARGET = $(BINARY) $(CONFMOD) INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) diff --git a/usr/src/uts/intel/qlc/Makefile b/usr/src/uts/intel/qlc/Makefile index c9071abe6a..22661960b6 100644 --- a/usr/src/uts/intel/qlc/Makefile +++ b/usr/src/uts/intel/qlc/Makefile @@ -22,7 +22,8 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of qlc driver kernel module. +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -81,6 +82,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/qlge/Makefile b/usr/src/uts/intel/qlge/Makefile index d9951b0d1a..425923a037 100644 --- a/usr/src/uts/intel/qlge/Makefile +++ b/usr/src/uts/intel/qlge/Makefile @@ -22,7 +22,8 @@ # Copyright 2010 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the qlge driver kernel module. +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -66,6 +67,9 @@ C99LMODE= -Xc99=%all CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/qlge.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/rdsv3/Makefile b/usr/src/uts/intel/rdsv3/Makefile index 1250b9c42f..7ef904de97 100644 --- a/usr/src/uts/intel/rdsv3/Makefile +++ b/usr/src/uts/intel/rdsv3/Makefile @@ -21,6 +21,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -65,6 +66,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off + # # Define targets # diff --git a/usr/src/uts/intel/rge/Makefile b/usr/src/uts/intel/rge/Makefile index aaa493f044..51ade3de5b 100644 --- a/usr/src/uts/intel/rge/Makefile +++ b/usr/src/uts/intel/rge/Makefile @@ -22,10 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the Realtek -# Gigabit Ethernet (BGE) driver module in intel systems -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -71,6 +68,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# looks like a real bug in rge_phy_update() ! +$(OBJS_DIR)/rge_chip.o := SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/rpcib/Makefile b/usr/src/uts/intel/rpcib/Makefile index f90003d045..ce04217815 100644 --- a/usr/src/uts/intel/rpcib/Makefile +++ b/usr/src/uts/intel/rpcib/Makefile @@ -22,6 +22,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the kernel @@ -77,6 +78,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/rpcmod/Makefile b/usr/src/uts/intel/rpcmod/Makefile index ae92a0a983..db4e739b07 100644 --- a/usr/src/uts/intel/rpcmod/Makefile +++ b/usr/src/uts/intel/rpcmod/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the rpcmod streams kernel @@ -89,6 +90,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-unused-function +# needs work +SMOFF += all_func_returns,indenting,no_if_block,deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/rpcsec/Makefile b/usr/src/uts/intel/rpcsec/Makefile index 3dd8a5e003..843d7dc880 100644 --- a/usr/src/uts/intel/rpcsec/Makefile +++ b/usr/src/uts/intel/rpcsec/Makefile @@ -25,10 +25,8 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the kernel rpcsec module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -71,6 +69,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/auth_des.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/rsm/Makefile b/usr/src/uts/intel/rsm/Makefile index 26c3c45282..c828628870 100644 --- a/usr/src/uts/intel/rsm/Makefile +++ b/usr/src/uts/intel/rsm/Makefile @@ -23,6 +23,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the rsm kernel agent @@ -81,6 +82,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/rts/Makefile b/usr/src/uts/intel/rts/Makefile index 8e8ec349a5..d0ca2cd069 100644 --- a/usr/src/uts/intel/rts/Makefile +++ b/usr/src/uts/intel/rts/Makefile @@ -24,10 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the rts IP driver -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -77,6 +74,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV +# needs work +$(OBJS_DIR)/rtsddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/s1394/Makefile b/usr/src/uts/intel/s1394/Makefile index aa1961414b..f7f8fd3299 100644 --- a/usr/src/uts/intel/s1394/Makefile +++ b/usr/src/uts/intel/s1394/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the s1394 kernel module. @@ -83,6 +84,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/sata/Makefile b/usr/src/uts/intel/sata/Makefile index 9d4e9bb2fc..9b0540e56b 100644 --- a/usr/src/uts/intel/sata/Makefile +++ b/usr/src/uts/intel/sata/Makefile @@ -23,6 +23,8 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # uts/intel/io/sata/Makefile @@ -91,6 +93,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-empty-body +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/scsa1394/Makefile b/usr/src/uts/intel/scsa1394/Makefile index 8e07952219..2545171295 100644 --- a/usr/src/uts/intel/scsa1394/Makefile +++ b/usr/src/uts/intel/scsa1394/Makefile @@ -22,6 +22,8 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree. @@ -65,6 +67,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/sbp2_driver.o := SMOFF += indenting + # Default build targets. # .KEEP_STATE: diff --git a/usr/src/uts/intel/scsa2usb/Makefile b/usr/src/uts/intel/scsa2usb/Makefile index 61acb5215e..342cc1f0fa 100644 --- a/usr/src/uts/intel/scsa2usb/Makefile +++ b/usr/src/uts/intel/scsa2usb/Makefile @@ -25,9 +25,7 @@ # # Copyright 2014 Garrett D'Amore <garrett@damore.org> # -# This makefile drives the production of the scsa2usb driver -# kernel module. intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -76,6 +74,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/scsa2usb.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/scsi/Makefile b/usr/src/uts/intel/scsi/Makefile index 5aeaf4c0f1..60577c36d7 100644 --- a/usr/src/uts/intel/scsi/Makefile +++ b/usr/src/uts/intel/scsi/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the scsi kernel module. @@ -75,6 +76,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/scsi_vhci/Makefile b/usr/src/uts/intel/scsi_vhci/Makefile index f18133d8dd..80191c40e0 100644 --- a/usr/src/uts/intel/scsi_vhci/Makefile +++ b/usr/src/uts/intel/scsi_vhci/Makefile @@ -23,6 +23,7 @@ # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of SCSI vHCI Driver @@ -52,6 +53,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMATCH=off + # # Define targets. # diff --git a/usr/src/uts/intel/sd/Makefile b/usr/src/uts/intel/sd/Makefile index cfa86ca4e5..1cdd67cd86 100644 --- a/usr/src/uts/intel/sd/Makefile +++ b/usr/src/uts/intel/sd/Makefile @@ -24,10 +24,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the sd -# kernel module. -# -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -74,6 +71,9 @@ LINTTAGS += -erroff=E_STATIC_UNUSED LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV +# needs work +SMOFF += index_overflow,shift_to_zero,signed + # # Depends on scsi and cmlb # diff --git a/usr/src/uts/intel/sda/Makefile b/usr/src/uts/intel/sda/Makefile index 7d0073b031..20be2108ad 100644 --- a/usr/src/uts/intel/sda/Makefile +++ b/usr/src/uts/intel/sda/Makefile @@ -22,6 +22,8 @@ # # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. + # # uts/intel/sda/Makefile @@ -76,6 +78,9 @@ MAPFILE = $(UTSBASE)/common/io/sdcard/impl/mapfile LDFLAGS += -dy -Ndrv/blkdev -B reduce -M $(MAPFILE) CTFMRGFLAGS += -f +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/sfe/Makefile b/usr/src/uts/intel/sfe/Makefile index 00aaa13a71..e0b2b5e461 100644 --- a/usr/src/uts/intel/sfe/Makefile +++ b/usr/src/uts/intel/sfe/Makefile @@ -22,6 +22,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # This makefile drives the production of NS/SiS @@ -78,6 +80,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns + # # Driver depends on MAC & IP # diff --git a/usr/src/uts/intel/sfxge/Makefile b/usr/src/uts/intel/sfxge/Makefile index 4db3a4dd22..5a7e71ff8c 100644 --- a/usr/src/uts/intel/sfxge/Makefile +++ b/usr/src/uts/intel/sfxge/Makefile @@ -12,6 +12,7 @@ # # Copyright 2016 Garrett D'Amore <garrett@damore.org> # +# Copyright (c) 2018, Joyent, Inc. UTSBASE = ../.. @@ -52,6 +53,10 @@ CFLAGS += $(CCVERBOSE) # LDFLAGS += -dy -N misc/mac +# needs work +$(OBJS_DIR)/sfxge_ev.o := SMOFF += index_overflow +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/smbfs/Makefile b/usr/src/uts/intel/smbfs/Makefile index 6defe60e32..5a23cf0c54 100644 --- a/usr/src/uts/intel/smbfs/Makefile +++ b/usr/src/uts/intel/smbfs/Makefile @@ -24,11 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the smbfs (Server -# message block file system) kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -70,6 +66,9 @@ LINTTAGS += -erroff=E_BAD_FORMAT_ARG_TYPE2 CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns,signed,deref_check + # The mb_put/md_get functions are intentionally used with and without # return value checks, so filter those out like LGREP.2 does. LGREP.nsmb = egrep -v ' ignored: (mb_init|mb_put|md_get)' diff --git a/usr/src/uts/intel/smbios/Makefile b/usr/src/uts/intel/smbios/Makefile index bc7c770bf5..ae91d18a7a 100644 --- a/usr/src/uts/intel/smbios/Makefile +++ b/usr/src/uts/intel/smbios/Makefile @@ -24,7 +24,8 @@ # Copyright 2005 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -#ident "%Z%%M% %I% %E% SMI" +# Copyright (c) 2018, Joyent, Inc. + UTSBASE = ../.. @@ -40,6 +41,9 @@ ALL_TARGET = $(BINARY) $(SRC_CONFILE) LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) +# needs work +SMOFF += signed_integer_overflow_check + .KEEP_STATE: def: $(DEF_DEPS) diff --git a/usr/src/uts/intel/smbsrv/Makefile b/usr/src/uts/intel/smbsrv/Makefile index 5dfe45a19c..8d7647c756 100644 --- a/usr/src/uts/intel/smbsrv/Makefile +++ b/usr/src/uts/intel/smbsrv/Makefile @@ -24,6 +24,7 @@ # # Copyright 2014 Nexenta Systems, Inc. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the cifs server file system @@ -74,6 +75,9 @@ INC_PATH += -I$(SRC)/common CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-switch +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/sockfs/Makefile b/usr/src/uts/intel/sockfs/Makefile index 31ae52d1cc..a62b4eaf0a 100644 --- a/usr/src/uts/intel/sockfs/Makefile +++ b/usr/src/uts/intel/sockfs/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the sockfs file system @@ -93,6 +94,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/sockpfp/Makefile b/usr/src/uts/intel/sockpfp/Makefile index ab2f16a0b3..2179fd50ff 100644 --- a/usr/src/uts/intel/sockpfp/Makefile +++ b/usr/src/uts/intel/sockpfp/Makefile @@ -22,11 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the nca driver -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -71,6 +67,9 @@ LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/sol_ofs/Makefile b/usr/src/uts/intel/sol_ofs/Makefile index 8f1e756ee3..133af5c292 100644 --- a/usr/src/uts/intel/sol_ofs/Makefile +++ b/usr/src/uts/intel/sol_ofs/Makefile @@ -21,7 +21,8 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # -# +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -64,6 +65,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-unused-variable +# needs work +$(OBJS_DIR)/sol_cma.o := SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/sol_ucma/Makefile b/usr/src/uts/intel/sol_ucma/Makefile index 4b51aae13c..7069d920b4 100644 --- a/usr/src/uts/intel/sol_ucma/Makefile +++ b/usr/src/uts/intel/sol_ucma/Makefile @@ -21,7 +21,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -64,6 +64,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW LINTTAGS += -erroff=E_STATIC_UNUSED +# needs work +SMOFF += all_func_returns,logical_instead_of_bitwise + # # Default build targets. # diff --git a/usr/src/uts/intel/sol_uverbs/Makefile b/usr/src/uts/intel/sol_uverbs/Makefile index 548d80aad3..0a9fdbada8 100644 --- a/usr/src/uts/intel/sol_uverbs/Makefile +++ b/usr/src/uts/intel/sol_uverbs/Makefile @@ -21,7 +21,7 @@ # # Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. # -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -64,6 +64,9 @@ CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-unused-label +# really broken +SMOFF += logical_instead_of_bitwise,or_vs_and + # # Default build targets. # diff --git a/usr/src/uts/intel/spdsock/Makefile b/usr/src/uts/intel/spdsock/Makefile index 8517e4882a..63a2aeb834 100644 --- a/usr/src/uts/intel/spdsock/Makefile +++ b/usr/src/uts/intel/spdsock/Makefile @@ -23,11 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the spdsock driver -# kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -73,6 +69,10 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/spdsockddi.o := SMOFF += index_overflow +$(OBJS_DIR)/spdsock.o := SMOFF += no_if_block + # # Default build targets. # diff --git a/usr/src/uts/intel/specfs/Makefile b/usr/src/uts/intel/specfs/Makefile index 8ff48afa63..ea18e2e9b7 100644 --- a/usr/src/uts/intel/specfs/Makefile +++ b/usr/src/uts/intel/specfs/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the specfs file system @@ -75,6 +76,9 @@ LINTTAGS += -erroff=E_SUSPICIOUS_COMPARISON CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/specvnops.o := SMOFF += signed + # # Default build targets. # diff --git a/usr/src/uts/intel/spppcomp/Makefile b/usr/src/uts/intel/spppcomp/Makefile index 31476b0589..1d3d2b3918 100644 --- a/usr/src/uts/intel/spppcomp/Makefile +++ b/usr/src/uts/intel/spppcomp/Makefile @@ -25,11 +25,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the spppcomp STREAMS -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -78,6 +74,9 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += indenting + # # Depends on sppp # diff --git a/usr/src/uts/intel/srpt/Makefile b/usr/src/uts/intel/srpt/Makefile index 424e85470e..e06aed2c91 100644 --- a/usr/src/uts/intel/srpt/Makefile +++ b/usr/src/uts/intel/srpt/Makefile @@ -21,8 +21,7 @@ # # Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the srpt pseudo-driver for -# COMSTAR. +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -64,6 +63,9 @@ C99LMODE= -Xc99=%all CERRWARN += -_gcc=-Wno-unused-label +# needs work +$(OBJS_DIR)/srpt_stp.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/st/Makefile b/usr/src/uts/intel/st/Makefile index 96ec74eb2f..7dbef2c9db 100644 --- a/usr/src/uts/intel/st/Makefile +++ b/usr/src/uts/intel/st/Makefile @@ -24,11 +24,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the st driver -# kernel module. -# -# intel implementation architecture independent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -75,6 +71,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMATCH=off + # # Depends on scsi # diff --git a/usr/src/uts/intel/stmf/Makefile b/usr/src/uts/intel/stmf/Makefile index 50ec544cbb..32eb938f7b 100644 --- a/usr/src/uts/intel/stmf/Makefile +++ b/usr/src/uts/intel/stmf/Makefile @@ -21,8 +21,7 @@ # # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. # -# This makefile drives the production of the stmf driver for -# COMSTAR. +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -58,6 +57,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) MODSTUBS_DIR = $(OBJS_DIR) CERRWARN += -erroff=E_STATEMENT_NOT_REACHED +# needs work +SMATCH=off + C99LMODE= -Xc99=%all # diff --git a/usr/src/uts/intel/strategy/Makefile b/usr/src/uts/intel/strategy/Makefile index 80a819601d..68733ccbd5 100644 --- a/usr/src/uts/intel/strategy/Makefile +++ b/usr/src/uts/intel/strategy/Makefile @@ -25,6 +25,7 @@ # Copyright 2005 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the strategy "misc" @@ -53,6 +54,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/strategy.o := SMOFF += all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/tavor/Makefile b/usr/src/uts/intel/tavor/Makefile index fd0923b3c8..397e2c3f5f 100644 --- a/usr/src/uts/intel/tavor/Makefile +++ b/usr/src/uts/intel/tavor/Makefile @@ -23,12 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the tavor InfiniBand module -# -# intel architecture dependent -# -# uts/intel/tavor/Makefile -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -86,6 +81,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/tcp/Makefile b/usr/src/uts/intel/tcp/Makefile index d083460646..f617552559 100644 --- a/usr/src/uts/intel/tcp/Makefile +++ b/usr/src/uts/intel/tcp/Makefile @@ -24,11 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the tcp driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -77,6 +73,9 @@ CFLAGS += $(CINLINES) # LDFLAGS += -dy -Ndrv/ip -Ncrypto/md5 -Nfs/sockfs +# needs work +$(OBJS_DIR)/tcpddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/tcp6/Makefile b/usr/src/uts/intel/tcp6/Makefile index 7612d1d551..386ddd9008 100644 --- a/usr/src/uts/intel/tcp6/Makefile +++ b/usr/src/uts/intel/tcp6/Makefile @@ -23,12 +23,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the tcp6 driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -51,6 +46,9 @@ CONF_SRCDIR = $(UTSBASE)/common/inet/tcp IP_CHECK_OBJS = $(IP_OBJS:ipddi.o=ip.o) EXTRA_CHECK_OBJS = $(IP_CHECK_OBJS:%=../ip/$(OBJS_DIR)/%) +# needs work +SMOFF += index_overflow + # # Include common rules. # diff --git a/usr/src/uts/intel/timerfd/Makefile b/usr/src/uts/intel/timerfd/Makefile index 28cf8fd41e..ed7e847842 100644 --- a/usr/src/uts/intel/timerfd/Makefile +++ b/usr/src/uts/intel/timerfd/Makefile @@ -10,7 +10,7 @@ # # -# Copyright (c) 2015 Joyent, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -34,6 +34,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/timod/Makefile b/usr/src/uts/intel/timod/Makefile index 4dc824c8b6..1ffbfc0353 100644 --- a/usr/src/uts/intel/timod/Makefile +++ b/usr/src/uts/intel/timod/Makefile @@ -24,13 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -#ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the timod streams kernel -# module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -65,6 +59,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN LINTTAGS += -erroff=E_PTRDIFF_OVERFLOW +# needs work +SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/tl/Makefile b/usr/src/uts/intel/tl/Makefile index 83d7faeaad..c820c5b179 100644 --- a/usr/src/uts/intel/tl/Makefile +++ b/usr/src/uts/intel/tl/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the tl driver @@ -77,6 +78,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/tlimod/Makefile b/usr/src/uts/intel/tlimod/Makefile index 3e0f5f1fdd..73584a9145 100644 --- a/usr/src/uts/intel/tlimod/Makefile +++ b/usr/src/uts/intel/tlimod/Makefile @@ -24,13 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -#ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the tlimod -# kernel module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -57,6 +51,9 @@ ALL_TARGET = $(BINARY) LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) +# needs work +SMOFF += indenting + # # Default build targets. # diff --git a/usr/src/uts/intel/tmpfs/Makefile b/usr/src/uts/intel/tmpfs/Makefile index 7d94dba6e8..bfc9769c6d 100644 --- a/usr/src/uts/intel/tmpfs/Makefile +++ b/usr/src/uts/intel/tmpfs/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the tmpfs file system @@ -69,6 +70,9 @@ CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-unused-value +# needs work +$(OBJS_DIR)/tmp_vnops.o := SMOFF += signed + # # Default build targets. # diff --git a/usr/src/uts/intel/tnf/Makefile b/usr/src/uts/intel/tnf/Makefile index 99ea51b39f..de264140d0 100644 --- a/usr/src/uts/intel/tnf/Makefile +++ b/usr/src/uts/intel/tnf/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # tnf (kernel trace driver) Makefile @@ -68,6 +69,10 @@ LINTTAGS += -erroff=E_ASSIGN_NARROW_CONV CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized + +# needs work +$(OBJS_DIR)/tnf_writer.o := SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/tpm/Makefile b/usr/src/uts/intel/tpm/Makefile index c87048cceb..185ddd6c68 100644 --- a/usr/src/uts/intel/tpm/Makefile +++ b/usr/src/uts/intel/tpm/Makefile @@ -21,9 +21,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the TPM driver kernel -# module. -# +# Copyright (c) 2018, Joyent, Inc. UTSBASE = $(SRC)/uts @@ -65,6 +63,9 @@ CPPFLAGS += -I$(ADJUNCT_PROTO)/usr/include CERRWARN += -_gcc=-Wno-parentheses +# needs work +$(OBJS_DIR)/tpm.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/trill/Makefile b/usr/src/uts/intel/trill/Makefile index 4ef89d3a1d..bc9f9ed05f 100644 --- a/usr/src/uts/intel/trill/Makefile +++ b/usr/src/uts/intel/trill/Makefile @@ -24,11 +24,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the TRILL socket kernel -# module. -# -# intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -50,6 +46,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += all_func_returns + # # Define targets # diff --git a/usr/src/uts/intel/udfs/Makefile b/usr/src/uts/intel/udfs/Makefile index a1d5d5daaa..244123e4f3 100644 --- a/usr/src/uts/intel/udfs/Makefile +++ b/usr/src/uts/intel/udfs/Makefile @@ -23,11 +23,7 @@ # Use is subject to license terms. # Copyright (c) 2011 Bayard G. Bell. All rights reserved. # -# This makefile drives the production of the udfs file system -# kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -83,6 +79,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/udmf/Makefile b/usr/src/uts/intel/udmf/Makefile index f43cb3268e..a4a5495d5e 100644 --- a/usr/src/uts/intel/udmf/Makefile +++ b/usr/src/uts/intel/udmf/Makefile @@ -10,7 +10,7 @@ # # -# Copyright (c) 2014 Joyent, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -47,6 +47,9 @@ LINTTAGS += -erroff=E_STATIC_UNUSED LINTTAGS += -erroff=E_FUNC_RET_ALWAYS_IGNOR2 LINTTAGS += -erroff=E_FUNC_SET_NOT_USED +# needs work +$(OBJS_DIR)/udmf_usbgem.o := SMOFF += indenting + # # Define targets # diff --git a/usr/src/uts/intel/udp/Makefile b/usr/src/uts/intel/udp/Makefile index c6238ebd8c..5ae4cfe6e1 100644 --- a/usr/src/uts/intel/udp/Makefile +++ b/usr/src/uts/intel/udp/Makefile @@ -24,10 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the udp driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -68,6 +65,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOTLINK) $(ROOT_CONFFILE) # LDFLAGS += -dy -Ndrv/ip -Nfs/sockfs +# needs work +$(OBJS_DIR)/udpddi.o := SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/udp6/Makefile b/usr/src/uts/intel/udp6/Makefile index 8a6b71160a..28a6e8f978 100644 --- a/usr/src/uts/intel/udp6/Makefile +++ b/usr/src/uts/intel/udp6/Makefile @@ -23,12 +23,7 @@ # Copyright 2004 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the udp6 driver kernel module. -# -# intel implementation architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -61,6 +56,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE) # LDFLAGS += -dy -Ndrv/udp -Ndrv/ip -Ndrv/ip6 +# needs work +SMOFF += index_overflow + # # Default build targets. # diff --git a/usr/src/uts/intel/ufs/Makefile b/usr/src/uts/intel/ufs/Makefile index b7127a0e23..0264031fcd 100644 --- a/usr/src/uts/intel/ufs/Makefile +++ b/usr/src/uts/intel/ufs/Makefile @@ -24,6 +24,7 @@ # Copyright 2006 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the ufs file system @@ -82,6 +83,9 @@ CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMATCH=off + # # Default build targets. # diff --git a/usr/src/uts/intel/upf/Makefile b/usr/src/uts/intel/upf/Makefile index 25f7e577db..c9b724ff24 100644 --- a/usr/src/uts/intel/upf/Makefile +++ b/usr/src/uts/intel/upf/Makefile @@ -10,7 +10,7 @@ # # -# Copyright (c) 2014 Joyent, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -41,6 +41,9 @@ CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-label +# needs work +$(OBJS_DIR)/upf_usbgem.o := SMOFF += all_func_returns + LINTTAGS += -erroff=E_FUNC_VAR_UNUSED LINTTAGS += -erroff=E_FUNC_ARG_UNUSED LINTTAGS += -erroff=E_STATIC_UNUSED diff --git a/usr/src/uts/intel/ural/Makefile b/usr/src/uts/intel/ural/Makefile index 33a44df7b7..de779ab288 100644 --- a/usr/src/uts/intel/ural/Makefile +++ b/usr/src/uts/intel/ural/Makefile @@ -22,13 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # - -# ident "%Z%%M% %I% %E% SMI" -# -# This makefile drives the production of the ural driver kernel module. -# -# i86pc architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -60,6 +54,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) # LDFLAGS += -dy -Nmisc/mac -Nmisc/net80211 -Nmisc/usba +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/urtw/Makefile b/usr/src/uts/intel/urtw/Makefile index a7b03b6bb3..76d86130c7 100644 --- a/usr/src/uts/intel/urtw/Makefile +++ b/usr/src/uts/intel/urtw/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the urtw driver kernel module. @@ -64,6 +65,9 @@ CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-char-subscripts CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check,no_if_block,all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/usb_ac/Makefile b/usr/src/uts/intel/usb_ac/Makefile index f2852a17c0..43e880c9ee 100644 --- a/usr/src/uts/intel/usb_ac/Makefile +++ b/usr/src/uts/intel/usb_ac/Makefile @@ -24,11 +24,7 @@ # # Copyright 2014 Garrett D'Amore <garrett@damore.org> # -# uts/intel/usb_ac/Makefile -# -# This makefile drives the production of the usb_ac driver -# kernel module. Intel architecture dependent -# +# Copyright (c) 2018, Joyent, Inc. # @@ -68,6 +64,9 @@ CERRWARN += -_gcc=-Wno-type-limits CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +$(OBJS_DIR)/usb_ac.o := SMOFF += deref_check,indenting,testing_index_after_use + # # depends on misc/usba # diff --git a/usr/src/uts/intel/usba/Makefile b/usr/src/uts/intel/usba/Makefile index fbd834917a..ae74e680d1 100644 --- a/usr/src/uts/intel/usba/Makefile +++ b/usr/src/uts/intel/usba/Makefile @@ -23,9 +23,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the usba kernel module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -52,6 +50,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-unused-value CERRWARN += -_gcc=-Wno-unused-variable +# needs work +SMOFF += all_func_returns,deref_check + # # Define targets # diff --git a/usr/src/uts/intel/usbecm/Makefile b/usr/src/uts/intel/usbecm/Makefile index 3ee8f01ef6..b9687406f9 100644 --- a/usr/src/uts/intel/usbecm/Makefile +++ b/usr/src/uts/intel/usbecm/Makefile @@ -25,8 +25,8 @@ # # Copyright 2014 Garrett D'Amore <garrett@damore.org> # -# This makefile drives the production of Abstract Control Model of -# USB Communication Devices Class dirver. +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -54,6 +54,9 @@ ALL_TARGET = $(BINARY) LINT_TARGET = $(MODULE).lint INSTALL_TARGET = $(BINARY) $(ROOTMODULE) +# needs work +SMOFF += deref_check + .KEEP_STATE: all: $(ALL_DEPS) diff --git a/usr/src/uts/intel/usbgem/Makefile b/usr/src/uts/intel/usbgem/Makefile index 6ec0666264..3d9bfe6e6e 100644 --- a/usr/src/uts/intel/usbgem/Makefile +++ b/usr/src/uts/intel/usbgem/Makefile @@ -10,7 +10,7 @@ # # -# Copyright (c) 2014 Joyent, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -49,6 +49,9 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-unused-function +# needs work +SMOFF += all_func_returns + LINTTAGS += -erroff=E_FUNC_VAR_UNUSED LINTTAGS += -erroff=E_FUNC_ARG_UNUSED LINTTAGS += -erroff=E_STATIC_UNUSED diff --git a/usr/src/uts/intel/usbms/Makefile b/usr/src/uts/intel/usbms/Makefile index 2cf550f26c..0a184975d0 100644 --- a/usr/src/uts/intel/usbms/Makefile +++ b/usr/src/uts/intel/usbms/Makefile @@ -23,9 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the usbms driver kernel module. -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -73,6 +71,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-parentheses CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/usbsacm/Makefile b/usr/src/uts/intel/usbsacm/Makefile index 23da8c76d0..09cc016b1f 100644 --- a/usr/src/uts/intel/usbsacm/Makefile +++ b/usr/src/uts/intel/usbsacm/Makefile @@ -23,9 +23,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of Abstract Control Model of -# USB Communication Devices Class dirver. +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -48,6 +47,9 @@ LDFLAGS += -dy -Nmisc/usba -Nmisc/usbser CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Define targets # diff --git a/usr/src/uts/intel/usbser/Makefile b/usr/src/uts/intel/usbser/Makefile index 9022579ae6..7932c9894f 100644 --- a/usr/src/uts/intel/usbser/Makefile +++ b/usr/src/uts/intel/usbser/Makefile @@ -22,7 +22,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# uts/intel/usbser/Makefile +# Copyright (c) 2018, Joyent, Inc. # @@ -65,6 +65,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) # LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN +# needs work +SMOFF += all_func_returns + .KEEP_STATE: all: $(ALL_DEPS) diff --git a/usr/src/uts/intel/usbvc/Makefile b/usr/src/uts/intel/usbvc/Makefile index 303a025e1e..364d5f3139 100644 --- a/usr/src/uts/intel/usbvc/Makefile +++ b/usr/src/uts/intel/usbvc/Makefile @@ -25,6 +25,7 @@ # # Copyright 2014 Garrett D'Amore <garrett@damore.org> # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the usbvc driver kernel module. @@ -74,6 +75,9 @@ LINTTAGS += -erroff=E_BAD_PTR_CAST_ALIGN CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/virtio/Makefile b/usr/src/uts/intel/virtio/Makefile index 10418db2cc..1f6548a135 100644 --- a/usr/src/uts/intel/virtio/Makefile +++ b/usr/src/uts/intel/virtio/Makefile @@ -21,6 +21,7 @@ # # Copyright (c) 2012 Nexenta Systems, Inc. All rights reserved. +# Copyright (c) 2018, Joyent, Inc. # # @@ -59,6 +60,9 @@ INC_PATH += -I$(UTSBASE)/common/io/virtio # CFLAGS += $(CCVERBOSE) +# needs work +SMOFF += all_func_returns + # # Default build targets. # diff --git a/usr/src/uts/intel/vnic/Makefile b/usr/src/uts/intel/vnic/Makefile index 15ee8a885c..357600fa72 100644 --- a/usr/src/uts/intel/vnic/Makefile +++ b/usr/src/uts/intel/vnic/Makefile @@ -22,6 +22,8 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. + # # Path to the base of the uts directory tree (usually /usr/src/uts). # @@ -57,6 +59,9 @@ LDFLAGS += -dy -Ndrv/dld -Nmisc/mac -Nmisc/dls CERRWARN += -_gcc=-Wno-switch CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/vr/Makefile b/usr/src/uts/intel/vr/Makefile index 85e97f4f6b..05f33305b7 100644 --- a/usr/src/uts/intel/vr/Makefile +++ b/usr/src/uts/intel/vr/Makefile @@ -22,6 +22,7 @@ # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # This makefile drives the production of the VIA Rhine Ethernet # (vr) driver module in intel systems @@ -59,6 +60,9 @@ INSTALL_TARGET = $(BINARY) $(ROOTMODULE) CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += array_condition + # # Driver depends on GLD # diff --git a/usr/src/uts/intel/vuid2ps2/Makefile b/usr/src/uts/intel/vuid2ps2/Makefile index 207f0c1d45..47f7c4fcd7 100644 --- a/usr/src/uts/intel/vuid2ps2/Makefile +++ b/usr/src/uts/intel/vuid2ps2/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the vuid2ps2 streams kernel @@ -53,6 +54,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += deref_check + # # Define targets # diff --git a/usr/src/uts/intel/vuid3ps2/Makefile b/usr/src/uts/intel/vuid3ps2/Makefile index b6d28fc856..28664ccd9e 100644 --- a/usr/src/uts/intel/vuid3ps2/Makefile +++ b/usr/src/uts/intel/vuid3ps2/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the vuid3ps2 streams kernel @@ -53,6 +54,9 @@ include $(UTSBASE)/intel/Makefile.intel CERRWARN += -_gcc=-Wno-uninitialized CERRWARN += -_gcc=-Wno-parentheses +# needs work +SMOFF += deref_check + # # Define targets # diff --git a/usr/src/uts/intel/vuidm3p/Makefile b/usr/src/uts/intel/vuidm3p/Makefile index 2d068a6e05..8084cbc35a 100644 --- a/usr/src/uts/intel/vuidm3p/Makefile +++ b/usr/src/uts/intel/vuidm3p/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the vuidm3p streams kernel @@ -64,6 +65,9 @@ ALL_DEFS += -DVUIDM3P CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/vuidm4p/Makefile b/usr/src/uts/intel/vuidm4p/Makefile index 0fe311ad2f..23f2265cdd 100644 --- a/usr/src/uts/intel/vuidm4p/Makefile +++ b/usr/src/uts/intel/vuidm4p/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the vuidm4p streams kernel @@ -64,6 +65,9 @@ ALL_DEFS += -DVUIDM4P CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/vuidm5p/Makefile b/usr/src/uts/intel/vuidm5p/Makefile index f127056424..4ddc855e60 100644 --- a/usr/src/uts/intel/vuidm5p/Makefile +++ b/usr/src/uts/intel/vuidm5p/Makefile @@ -24,6 +24,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # +# Copyright (c) 2018, Joyent, Inc. # # This makefile drives the production of the vuidm5p streams kernel @@ -61,6 +62,9 @@ ALL_DEFS += -DVUIDM5P CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/wc/Makefile b/usr/src/uts/intel/wc/Makefile index d84d5a4faa..b855fa56bc 100644 --- a/usr/src/uts/intel/wc/Makefile +++ b/usr/src/uts/intel/wc/Makefile @@ -23,12 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# -# This makefile drives the production of the wc driver -# kernel module. -# -# intel implementation architecture independent -# +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -63,6 +58,9 @@ LDFLAGS += -dy -Nmisc/tem -Ndacf/consconfig_dacf CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += deref_check + # # Default build targets. # diff --git a/usr/src/uts/intel/xge/Makefile b/usr/src/uts/intel/xge/Makefile index 7df734d75d..1c9b0e2e2b 100644 --- a/usr/src/uts/intel/xge/Makefile +++ b/usr/src/uts/intel/xge/Makefile @@ -23,9 +23,7 @@ # Copyright 2008 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # -# This makefile drives the production of the Neterion Xframe -# 10G Ethernet (XGE) driver module in x86 systems -# +# Copyright (c) 2018, Joyent, Inc. # # Paths to the base of the uts directory trees @@ -112,6 +110,9 @@ CERRWARN += -_gcc=-Wno-unused-label CERRWARN += -_gcc=-Wno-empty-body CERRWARN += -_gcc=-Wno-uninitialized +# needs work +SMOFF += indenting,all_func_returns,no_if_block + # # # Default build targets. diff --git a/usr/src/uts/intel/zfs/Makefile b/usr/src/uts/intel/zfs/Makefile index a4a2f4a561..b5955cfe7a 100644 --- a/usr/src/uts/intel/zfs/Makefile +++ b/usr/src/uts/intel/zfs/Makefile @@ -29,6 +29,7 @@ # # Copyright (c) 2016 by Delphix. All rights reserved. # +# Copyright (c) 2018, Joyent, Inc. # # Path to the base of the uts directory tree (usually /usr/src/uts). @@ -93,6 +94,18 @@ CERRWARN += -_gcc=-Wno-unused-variable CERRWARN += -_gcc=-Wno-unused-function CERRWARN += -_gcc=-Wno-unused-label +# needs work +SMOFF += all_func_returns,indenting +$(OBJS_DIR)/llex.o := SMOFF += index_overflow +$(OBJS_DIR)/metaslab.o := SMOFF += no_if_block +$(OBJS_DIR)/zfs_vnops.o := SMOFF += signed +# needs work +$(OBJS_DIR)/zvol.o := SMOFF += deref_check,signed + +# false positives +$(OBJS_DIR)/zfs_ctldir.o := SMOFF += strcpy_overflow +$(OBJS_DIR)/zfs_ioctl.o := SMOFF += strcpy_overflow + # # Default build targets. # |