11736 Stop using $VERSION for the genunix label

Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Robert Mustacchi <rm@fingolfin.org>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Approved by: Dan McDonald <danmcd@joyent.com>

10 files changed, 32 insertions, 45 deletions

diff --git a/usr/src/Makefile.master b/usr/src/Makefile.master
index 892c447a49..57c163179f 100644
--- a/usr/src/Makefile.master
+++ b/usr/src/Makefile.master
@@ -1073,6 +1073,7 @@ RELEASE_DATE=	release date not set
 PATCH_DATE=	$(RELEASE_DATE)
 RELEASE_CM=	"@($(POUND_SIGN))SunOS $(RELEASE) $(PATCHID) $(PATCH_DATE)"
 DEV_CM=		"@($(POUND_SIGN))SunOS Internal Development: non-nightly build"
+UTS_LABEL=	$(RELEASE)
 
 PROCESS_COMMENT=  @?${MCS} -d -a $(RELEASE_CM) -a $(DEV_CM)
 $(RELEASE_BUILD)PROCESS_COMMENT=   @?${MCS} -d -a $(RELEASE_CM)
diff --git a/usr/src/cmd/mdb/Makefile.kmdb.targ b/usr/src/cmd/mdb/Makefile.kmdb.targ
index 920a560320..5605a6d9fd 100644
--- a/usr/src/cmd/mdb/Makefile.kmdb.targ
+++ b/usr/src/cmd/mdb/Makefile.kmdb.targ
@@ -22,6 +22,8 @@
 # Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
 # Use is subject to license terms.
 #
+# Copyright 2019 Joyent, Inc.
+#
 
 ROOTTERMINFO = $(ROOTSHLIB)/terminfo
 
@@ -31,7 +33,7 @@ $(PROG).core: $(OBJS) $(KMDBLIBS) $(MAPFILE)
 
 $(PROG): $(PROG).core $(KCTLOBJS)
 	$(LD) -dy -r -o $@ $@.core -Nmisc/ctf $(KCTLOBJS)
-	$(CTFMERGE) -L VERSION -o $@ $(OBJS) $(KCTLOBJS)
+	$(CTFMERGE) -l "$(UTS_LABEL)" -o $@ $(OBJS) $(KCTLOBJS)
 	$(KMDB_FPTEST)
 	$(POST_PROCESS)
 	$(SETDYNFLAG) -f DF_1_IGNMULDEF,DF_1_NOKSYMS $@
@@ -54,7 +56,7 @@ dmods:
 #
 # Specialized object construction
 #
-kmdb_terminfo.c: 	../../../common/mdb/mdb_termio.c \
+kmdb_terminfo.c:	../../../common/mdb/mdb_termio.c \
 			../../../common/kmdb/kmdb_terminfo_skel.c \
 			$(ROOTTERMINFO)
 	TERMINFO=$(ROOTTERMINFO) $(TIGEN) -s \
diff --git a/usr/src/cmd/mdb/Makefile.module b/usr/src/cmd/mdb/Makefile.module
index f77b935e47..b61ed79ad4 100644
--- a/usr/src/cmd/mdb/Makefile.module
+++ b/usr/src/cmd/mdb/Makefile.module
@@ -25,7 +25,7 @@
 # Copyright (c) 2013 by Delphix. All rights reserved.
 # Copyright (c) 2019 Carlos Neira <cneirabustos@gmail.com>
 # Copyright 2019 OmniOS Community Edition (OmniOSce) Association.
-# Copyright (c) 2019, Joyent, Inc.
+# Copyright 2019 Joyent, Inc.
 #
 
 .KEEP_STATE:
@@ -211,7 +211,7 @@ $(KMODFILE): kmod .WAIT $(KMODOBJS) $(MAPFILE)
 	$(STANDOBJS)
 	$(KMDB_LINKTEST_CMD)
 	$(KMDB_FPTEST_CMD)
-	$(CTFMERGE) -f -L VERSION -o $@ $(KMODOBJS)
+	$(CTFMERGE) -l "$(UTS_LABEL)" -o $@ $(KMODOBJS)
 	$(POST_PROCESS)
 	$(SETDYNFLAG) -f DF_1_NOKSYMS $@
 
diff --git a/usr/src/uts/Makefile.uts b/usr/src/uts/Makefile.uts
index e20d768803..c0a6b2476c 100644
--- a/usr/src/uts/Makefile.uts
+++ b/usr/src/uts/Makefile.uts
@@ -337,6 +337,17 @@ INS.conffile= \
 	$(RM) $@; $(INS) -s -m $(CFILEMODE) -f $(@D) $(SRC_CONFFILE)
 
 #
+# By default, instead of $VERSION, we use $(UTS_LABEL), which is by
+# default set to $RELEASE aka "5.11".
+#
+# $VERSION changes when the git HEAD changes, leading to annoying merge
+# uniquification conflicts when doing partial builds during development.
+# The information from $VERSION is available via "buildversion" anyway.
+#
+CTFCVTFLAGS = -X -l "$(UTS_LABEL)"
+CTFMRGFLAGS += -l "$(UTS_LABEL)"
+
+#
 # The CTF merge of child kernel modules is performed against one of the genunix
 # modules.  For Intel builds, all modules will be used with a single genunix:
 # the one built in intel/genunix.  For SPARC builds, a given
@@ -354,26 +365,26 @@ CTFMERGE_GENUNIX	= \
 	$(UTSBASE)/$(CTFMERGE_GUDIR)/genunix/$(OBJS_DIR)/genunix
 
 #
-# Used to uniquify a non-genunix module against genunix. $VERSION is used
-# for the label.
+# Used to uniquify a non-genunix module against genunix.
 #
 # For the ease of developers dropping modules onto possibly unrelated systems,
 # you can set NO_GENUNIX_UNIQUIFY= in the environment to skip uniquifying
 # against genunix.
 #
+#
 NO_GENUNIX_UNIQUIFY=$(POUND_SIGN)
 CTFMERGE_GENUNIX_DFLAG=-d $(CTFMERGE_GENUNIX)
 $(NO_GENUNIX_UNIQUIFY)CTFMERGE_GENUNIX_DFLAG=
 
-CTFMERGE_UNIQUIFY_AGAINST_GENUNIX	= \
-	$(CTFMERGE) $(CTFMRGFLAGS) -L VERSION \
-	$(CTFMERGE_GENUNIX_DFLAG) -o $@ $(OBJECTS) $(CTFEXTRAOBJS)
+CTFMERGE_UNIQUIFY_AGAINST_GENUNIX = \
+	$(CTFMERGE) $(CTFMRGFLAGS) $(CTFMERGE_GENUNIX_DFLAG) \
+	-o $@ $(OBJECTS) $(CTFEXTRAOBJS)
 
 #
 # Used to merge the genunix module.
 #
-CTFMERGE_GENUNIX_MERGE		= \
-	$(CTFMERGE) $(CTFMRGFLAGS) -L VERSION -o $@ \
+CTFMERGE_GENUNIX_MERGE = \
+	$(CTFMERGE) $(CTFMRGFLAGS) -o $@ \
 	$(OBJECTS) $(CTFEXTRAOBJS) $(IPCTF_TARGET)
 
 #
@@ -662,11 +673,3 @@ PRIVS_DEF = $(SRC)/uts/common/os/priv_defs
 #
 USBDEVS_AWK =	$(SRC)/uts/common/io/usb/usbdevs2h.awk
 USBDEVS_DATA =	$(SRC)/uts/common/io/usb/usbdevs
-
-
-#
-# If we're using the newer CTF tools, then we need to make sure that we
-# are building with the private -X option to ctfconvert which allows us
-# to fixup the struct cpu to account for machcpu.
-#
-$(BUILD_NEW_CTF_TOOLS)CTFCVTFLAGS += -X
diff --git a/usr/src/uts/common/Makefile.rules b/usr/src/uts/common/Makefile.rules
index 688faf0000..2ab56e0245 100644
--- a/usr/src/uts/common/Makefile.rules
+++ b/usr/src/uts/common/Makefile.rules
@@ -1613,7 +1613,7 @@ $(OBJS_DIR)/%.o:		$(UTSBASE)/common/zmod/%.c
 $(OBJS_DIR)/zlib_obj.o:		$(ZLIB_OBJS:%=$(OBJS_DIR)/%)
 	$(LD) -r -Breduce -M$(UTSBASE)/common/zmod/mapfile -o $@ \
 	    $(ZLIB_OBJS:%=$(OBJS_DIR)/%)
-	$(CTFMERGE) -t -f -L VERSION -o $@ $(ZLIB_OBJS:%=$(OBJS_DIR)/%)
+	$(CTFMERGE) $(CTFMRGFLAGS) -o $@ $(ZLIB_OBJS:%=$(OBJS_DIR)/%)
 
 $(OBJS_DIR)/%.o:		$(UTSBASE)/common/io/hxge/%.c
 	$(COMPILE.c) -o $@ $<
diff --git a/usr/src/uts/intel/klmmod/Makefile b/usr/src/uts/intel/klmmod/Makefile
index 1ccdaf6b1e..1786f91a08 100644
--- a/usr/src/uts/intel/klmmod/Makefile
+++ b/usr/src/uts/intel/klmmod/Makefile
@@ -24,7 +24,7 @@
 #
 # Copyright (c) 2012 by Delphix. All rights reserved.
 #
-# Copyright (c) 2018, Joyent, Inc.
+# Copyright 2019 Joyent, Inc.
 
 #
 #	Path to the base of the uts directory tree (usually /usr/src/uts).
@@ -56,7 +56,6 @@ INSTALL_TARGET	= $(BINARY) $(ROOTMODULE)
 #
 LDFLAGS		+= -dy -Nstrmod/rpcmod -Nfs/nfs
 LDFLAGS		+= -M $(UTSBASE)/common/klm/mapfile-mod
-CTFMRGFLAGS	+= -f
 
 #
 # Code generated by rpcgen triggers the -Wswitch warning.
diff --git a/usr/src/uts/intel/klmops/Makefile b/usr/src/uts/intel/klmops/Makefile
index e62d6ce160..77deddcf2c 100644
--- a/usr/src/uts/intel/klmops/Makefile
+++ b/usr/src/uts/intel/klmops/Makefile
@@ -23,11 +23,7 @@
 # Use is subject to license terms.
 #
 # Copyright (c) 2012 by Delphix. All rights reserved.
-#
-#	This makefile drives the production of the network lock manager client
-#	side module.
-#
-#	intel implementation architecture dependent
+# Copyright 2019 Joyent, Inc.
 #
 
 #
@@ -60,7 +56,6 @@ INSTALL_TARGET	= $(BINARY) $(ROOTMODULE)
 #
 LDFLAGS		+= -dy -Nstrmod/rpcmod -Nfs/nfs -Nmisc/klmmod
 LDFLAGS		+= -M $(UTSBASE)/common/klm/mapfile-ops
-CTFMRGFLAGS	+= -f
 
 #
 #	Default build targets.
diff --git a/usr/src/uts/intel/sda/Makefile b/usr/src/uts/intel/sda/Makefile
index 20be2108ad..3aa5279c60 100644
--- a/usr/src/uts/intel/sda/Makefile
+++ b/usr/src/uts/intel/sda/Makefile
@@ -22,7 +22,7 @@
 #
 # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
 #
-# Copyright (c) 2018, Joyent, Inc.
+# Copyright 2019 Joyent, Inc.
 
 
 #
@@ -67,16 +67,14 @@ DEBUG_DEFS	+= $(DEBUG_FLGS)
 
 #
 # lint pass one enforcement
-#  
+#
 CFLAGS += $(CCVERBOSE)
 
 #
 # dependency on blkdev module, scope limiting mapfile
-# Note that we have to allow CTFMERGE to use fuzzy matching
 #
 MAPFILE		= $(UTSBASE)/common/io/sdcard/impl/mapfile
 LDFLAGS		+= -dy -Ndrv/blkdev -B reduce -M $(MAPFILE)
-CTFMRGFLAGS	+= -f
 
 # needs work
 SMOFF += all_func_returns
diff --git a/usr/src/uts/sparc/klmmod/Makefile b/usr/src/uts/sparc/klmmod/Makefile
index ed0ac4c675..a3523ab775 100644
--- a/usr/src/uts/sparc/klmmod/Makefile
+++ b/usr/src/uts/sparc/klmmod/Makefile
@@ -23,11 +23,7 @@
 # Use is subject to license terms.
 #
 # Copyright (c) 2012 by Delphix. All rights reserved.
-#
-#	This makefile drives the production of the server-side network lock
-#	manager kernel module.
-#
-#	sparc architecture dependent
+# Copyright 2019 Joyent, Inc.
 #
 
 #
@@ -61,7 +57,6 @@ INSTALL_TARGET	= $(BINARY) $(ROOTMODULE)
 CFLAGS		+= $(CCVERBOSE)
 LDFLAGS		+= -dy -Nstrmod/rpcmod -Nfs/nfs
 LDFLAGS		+= -M $(UTSBASE)/common/klm/mapfile-mod
-CTFMRGFLAGS	+= -f
 
 #
 # Code generated by rpcgen triggers the -Wswitch warning.
diff --git a/usr/src/uts/sparc/klmops/Makefile b/usr/src/uts/sparc/klmops/Makefile
index 6c44483c85..be0b805e5e 100644
--- a/usr/src/uts/sparc/klmops/Makefile
+++ b/usr/src/uts/sparc/klmops/Makefile
@@ -23,12 +23,7 @@
 # Use is subject to license terms.
 #
 # Copyright (c) 2012 by Delphix. All rights reserved.
-#
-#	This makefile drives the production of the client-side network lock
-#	manager kernel module.
-#
-#	sparc architecture dependent
-#
+# Copyright 2019 Joyent, Inc.
 
 #
 #	Path to the base of the uts directory tree (usually /usr/src/uts).
@@ -61,7 +56,6 @@ INSTALL_TARGET	= $(BINARY) $(ROOTMODULE)
 CFLAGS		+= $(CCVERBOSE)
 LDFLAGS		+= -dy -Nstrmod/rpcmod -Nfs/nfs
 LDFLAGS		+= -M $(UTSBASE)/common/klm/mapfile-ops
-CTFMRGFLAGS	+= -f
 
 #
 #	Default build targets.