summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorToomas Soome <tsoome@me.com>2020-01-31 08:33:05 +0200
committerToomas Soome <tsoome@me.com>2020-06-05 08:56:51 +0300
commit6b9ce6a49498244ac078b078afa3601c92b66d76 (patch)
treedfda7000da17c85ff156f6c751f92599fad47ee3
parent6523a3aa7f325d64841382707603be7a86e68147 (diff)
downloadillumos-joyent-6b9ce6a49498244ac078b078afa3601c92b66d76.tar.gz
12566 seeprom: NULL pointer errors
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Yuri Pankov <ypankov@tintri.com> Approved by: Dan McDonald <danmcd@joyent.com>
-rw-r--r--usr/src/uts/sun4u/io/i2c/clients/seeprom.c2
-rw-r--r--usr/src/uts/sun4u/seeprom/Makefile20
2 files changed, 1 insertions, 21 deletions
diff --git a/usr/src/uts/sun4u/io/i2c/clients/seeprom.c b/usr/src/uts/sun4u/io/i2c/clients/seeprom.c
index 176051db4c..ece73f2863 100644
--- a/usr/src/uts/sun4u/io/i2c/clients/seeprom.c
+++ b/usr/src/uts/sun4u/io/i2c/clients/seeprom.c
@@ -167,7 +167,7 @@ seeprom_do_attach(dev_info_t *dip)
"%s%d", ddi_driver_name(dip), instance);
if (ddi_create_minor_node(dip, ddi_node_name(dip), S_IFCHR,
- instance, SEEPROM_NODE_TYPE, NULL) == DDI_FAILURE) {
+ instance, SEEPROM_NODE_TYPE, 0) == DDI_FAILURE) {
cmn_err(CE_WARN, "%s ddi_create_minor_node failed for '%s'",
unitp->seeprom_name, ddi_node_name(dip));
ddi_soft_state_free(seepromsoft_statep, instance);
diff --git a/usr/src/uts/sun4u/seeprom/Makefile b/usr/src/uts/sun4u/seeprom/Makefile
index 92b51e0417..b4d887a3bc 100644
--- a/usr/src/uts/sun4u/seeprom/Makefile
+++ b/usr/src/uts/sun4u/seeprom/Makefile
@@ -35,7 +35,6 @@ UTSBASE = ../..
#
MODULE = seeprom
OBJECTS = $(SEEPROM_OBJS:%=$(OBJS_DIR)/%)
-LINTS = $(SEEPROM_OBJS:%.o=$(LINTS_DIR)/%.ln)
ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
#
@@ -43,27 +42,14 @@ ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
#
include $(UTSBASE)/sun4u/Makefile.sun4u
-#
-# lint pass one enforcement
-#
-CFLAGS += $(CCVERBOSE)
-
LDFLAGS += -dy -N misc/i2c_svc
-#
-# For now, disable these lint checks; maintainers should endeavor
-# to investigate and remove these for maximum lint coverage.
-# Please do not carry these forward to new Makefiles.
-#
-LINTTAGS += -erroff=E_SUPPRESSION_DIRECTIVE_UNUSED
-
CERRWARN += $(CNOWARN_UNINIT)
#
# Define targets
#
ALL_TARGET = $(BINARY)
-LINT_TARGET = $(MODULE).lint
INSTALL_TARGET = $(BINARY) $(ROOTMODULE)
.KEEP_STATE:
@@ -76,12 +62,6 @@ clean: $(CLEAN_DEPS)
clobber: $(CLOBBER_DEPS)
-lint: $(LINT_DEPS)
-
-modlintlib: $(MODLINTLIB_DEPS)
-
-clean.lint: $(CLEAN_LINT_DEPS)
-
install: $(INSTALL_DEPS)
#