summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorToomas Soome <tsoome@me.com>2020-01-31 08:36:02 +0200
committerToomas Soome <tsoome@me.com>2020-06-05 23:21:19 +0300
commit734d822d17e7f65e682ac175dbcb29382b39620b (patch)
tree86da2ea42bff0e69afcc149e7f9b6221e49a8ac7
parentfa4e72b04e6507456698cd5d25ff74f4ab5d2056 (diff)
downloadillumos-joyent-734d822d17e7f65e682ac175dbcb29382b39620b.tar.gz
12568 tda8444: NULL pointer errors
Reviewed by: Yuri Pankov <ypankov@tintri.com> Approved by: Dan McDonald <danmcd@joyent.com>
-rw-r--r--usr/src/uts/sun4u/io/i2c/clients/tda8444.c2
-rw-r--r--usr/src/uts/sun4u/tda8444/Makefile13
2 files changed, 1 insertions, 14 deletions
diff --git a/usr/src/uts/sun4u/io/i2c/clients/tda8444.c b/usr/src/uts/sun4u/io/i2c/clients/tda8444.c
index 97f0c0c60d..bed11a1262 100644
--- a/usr/src/uts/sun4u/io/i2c/clients/tda8444.c
+++ b/usr/src/uts/sun4u/io/i2c/clients/tda8444.c
@@ -225,7 +225,7 @@ tda8444_do_attach(dev_info_t *dip)
minor = TDA8444_CHANNEL_TO_MINOR(i) |
TDA8444_DEVINST_TO_MINOR(instance);
if (ddi_create_minor_node(dip, name, S_IFCHR, minor,
- TDA8444_NODE_TYPE, NULL) == DDI_FAILURE) {
+ TDA8444_NODE_TYPE, 0) == DDI_FAILURE) {
cmn_err(CE_WARN, "%s ddi_create_minor_node failed",
unitp->tda8444_name);
ddi_soft_state_free(tda8444_soft_statep, instance);
diff --git a/usr/src/uts/sun4u/tda8444/Makefile b/usr/src/uts/sun4u/tda8444/Makefile
index 544faf4462..08f8e697c9 100644
--- a/usr/src/uts/sun4u/tda8444/Makefile
+++ b/usr/src/uts/sun4u/tda8444/Makefile
@@ -35,7 +35,6 @@ UTSBASE = ../..
#
MODULE = tda8444
OBJECTS = $(TDA8444_OBJS:%=$(OBJS_DIR)/%)
-LINTS = $(TDA8444_OBJS:%.o=$(LINTS_DIR)/%.ln)
ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
#
@@ -43,18 +42,12 @@ ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
#
include $(UTSBASE)/sun4u/Makefile.sun4u
-#
-# lint pass one enforcement
-#
-CFLAGS += $(CCVERBOSE)
-
LDFLAGS += -dy -N misc/i2c_svc
#
# Define targets
#
ALL_TARGET = $(BINARY)
-LINT_TARGET = $(MODULE).lint
INSTALL_TARGET = $(BINARY) $(ROOTMODULE)
.KEEP_STATE:
@@ -67,12 +60,6 @@ clean: $(CLEAN_DEPS)
clobber: $(CLOBBER_DEPS)
-lint: $(LINT_DEPS)
-
-modlintlib: $(MODLINTLIB_DEPS)
-
-clean.lint: $(CLEAN_LINT_DEPS)
-
install: $(INSTALL_DEPS)
#