diff options
| author | Toomas Soome <tsoome@me.com> | 2020-01-18 11:44:12 -0800 |
|---|---|---|
| committer | Toomas Soome <tsoome@me.com> | 2020-05-01 09:43:40 +0300 |
| commit | ef9416a894c90df5d46b888dbe2908c7f00fd409 (patch) | |
| tree | cac294b6d79d4b7b76357f90c86da8d3d963658e /usr/src/common/acl/acl_common.c | |
| parent | 9f9cceb6f1158940244c35cecdbc93f9a386a4b8 (diff) | |
| download | illumos-joyent-ef9416a894c90df5d46b888dbe2908c7f00fd409.tar.gz | |
12296 unix: access_mask_check() warn: bitwise AND condition is false here
Reviewed by: Matthias Scheler <mscheler@tintri.com>
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Approved by: Gordon Ross <gordon.w.ross@gmail.com>
Diffstat (limited to 'usr/src/common/acl/acl_common.c')
| -rw-r--r-- | usr/src/common/acl/acl_common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr/src/common/acl/acl_common.c b/usr/src/common/acl/acl_common.c index 765d6cef12..3b4f9bdec8 100644 --- a/usr/src/common/acl/acl_common.c +++ b/usr/src/common/acl/acl_common.c @@ -875,8 +875,8 @@ access_mask_check(ace_t *acep, int mask_bit, int isowner) set_allow = ACL_WRITE_ATTRS_WRITER_SET_ALLOW; err_allow = ACL_WRITE_ATTRS_WRITER_ERR_ALLOW; } else { - if ((acep->a_access_mask & mask_bit) && - (acep->a_type & ACE_ACCESS_ALLOWED_ACE_TYPE)) { + if (((acep->a_access_mask & mask_bit) != 0) && + (acep->a_type == ACE_ACCESS_ALLOWED_ACE_TYPE)) { return (ENOTSUP); } return (0); |