12175 i86xpv: variable may be used uninitialized

Reviewed by: Andy Stormont <astormont@racktopsystems.com>
Reviewed by: Gergő Doma <domag02@gmail.com>
Approved by: Dan McDonald <danmcd@joyent.com>

11 files changed, 13 insertions, 5 deletions

diff --git a/usr/src/uts/common/xen/dtrace/xdt.c b/usr/src/uts/common/xen/dtrace/xdt.c
index 37cb920932..b26e9128bc 100644
--- a/usr/src/uts/common/xen/dtrace/xdt.c
+++ b/usr/src/uts/common/xen/dtrace/xdt.c
@@ -702,6 +702,7 @@ xdt_process_rec(uint_t cpuid, struct t_rec *rec)
 	ASSERT(rec != NULL);
 	ASSERT(xdt_ncpus == xpv_nr_phys_cpus());
 
+	eid = 0;
 	if (cpuid >= xdt_ncpus) {
 		tbuf.stat_spurious_cpu++;
 		goto done;
@@ -973,7 +974,7 @@ switchdone:
 		 *
 		 * data[0] = eip
 		 * data[1] = trapnr | (error_code_valid << 15)
-		 * 	| (error_code << 16);
+		 *	| (error_code << 16);
 		 */
 		XDT_PROBE4(XDT_PV_TRAP, data[0], data[1] & 0x7fff,
 		    (data[1] >> 15) & 1, data[1] >> 16);
@@ -985,7 +986,7 @@ switchdone:
 		 * data[0] = rip(0:31)
 		 * data[1] = rip(32:63)
 		 * data[2] = trapnr | (error_code_valid << 15)
-		 * 	| (error_code << 16);
+		 *	| (error_code << 16);
 		 */
 		rip64 = (((uint64_t)data[1]) << 32) | data[2];
 		XDT_PROBE4(XDT_PV_TRAP, rip64, data[2] & 0x7fff,
diff --git a/usr/src/uts/common/xen/io/xnb.c b/usr/src/uts/common/xen/io/xnb.c
index 761597653b..4bf424c44e 100644
--- a/usr/src/uts/common/xen/io/xnb.c
+++ b/usr/src/uts/common/xen/io/xnb.c
@@ -665,6 +665,7 @@ xnb_to_peer(xnb_t *xnbp, mblk_t *mp)
 	 * to transfer them.
 	 */
 
+	len = 0;
 	mutex_enter(&xnbp->xnb_rx_lock);
 
 	/*
diff --git a/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c b/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c
index af14349807..900d4199c1 100644
--- a/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c
+++ b/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c
@@ -695,12 +695,11 @@ cpupm_plat_domain_id(cpu_t *cp, cpupm_dtype_t type)
 	return (CPUPM_NO_DOMAIN);
 }
 
-/*ARGSUSED*/
 uint_t
 cpupm_plat_state_enumerate(cpu_t *cp, cpupm_dtype_t type,
     cpupm_state_t *states)
 {
-	int	*speeds;
+	int	*speeds = NULL;
 	uint_t	nspeeds, i;
 
 	/*
diff --git a/usr/src/uts/i86pc/os/fakebop.c b/usr/src/uts/i86pc/os/fakebop.c
index 166791b2c1..75c4c618a7 100644
--- a/usr/src/uts/i86pc/os/fakebop.c
+++ b/usr/src/uts/i86pc/os/fakebop.c
@@ -1039,6 +1039,7 @@ xen_vbdroot_props(char *s)
 	short minor;
 	long addr = 0;
 
+	mi = '\0';
 	pnp = vbdpath + strlen(vbdpath);
 	prop_p = s + strlen(lnamefix);
 	while ((*prop_p != '\0') && (*prop_p != 's') && (*prop_p != 'p'))
diff --git a/usr/src/uts/i86pc/vm/htable.c b/usr/src/uts/i86pc/vm/htable.c
index 08e2130117..b201d8cfc4 100644
--- a/usr/src/uts/i86pc/vm/htable.c
+++ b/usr/src/uts/i86pc/vm/htable.c
@@ -2455,7 +2455,7 @@ x86pte_zero(htable_t *dest, uint_t entry, uint_t count)
 	caddr_t dst_va;
 	size_t size;
 #ifdef __xpv
-	int x;
+	int x = 0;
 	x86pte_t newpte;
 #endif
 
diff --git a/usr/src/uts/i86pc/vm/vm_machdep.c b/usr/src/uts/i86pc/vm/vm_machdep.c
index c1326a6643..fe8b806e82 100644
--- a/usr/src/uts/i86pc/vm/vm_machdep.c
+++ b/usr/src/uts/i86pc/vm/vm_machdep.c
@@ -2793,6 +2793,7 @@ page_swap_with_hypervisor(struct vnode *vp, u_offset_t off, caddr_t vaddr,
 	page_t *pp, *expp, *pp_first, **pplist = NULL;
 	mfn_t *mfnlist = NULL;
 
+	extra = 0;
 	contig = flags & PG_PHYSCONTIG;
 	if (minctg == 1)
 		contig = 0;
diff --git a/usr/src/uts/i86xpv/cpu/generic_cpu/gcpu_mca_xpv.c b/usr/src/uts/i86xpv/cpu/generic_cpu/gcpu_mca_xpv.c
index be28a710bf..3fec6adeb1 100644
--- a/usr/src/uts/i86xpv/cpu/generic_cpu/gcpu_mca_xpv.c
+++ b/usr/src/uts/i86xpv/cpu/generic_cpu/gcpu_mca_xpv.c
@@ -82,6 +82,7 @@ gcpu_xpv_proxy_logout(int what, struct mc_info *mi, struct mcinfo_common **micp,
 
 	/* Skip over the MC_TYPE_GLOBAL record */
 	ASSERT(mgi->common.type == MC_TYPE_GLOBAL);
+	mcrp = NULL;
 	mic = x86_mcinfo_next((struct mcinfo_common *)(uintptr_t)mgi);
 	idx++;
 
diff --git a/usr/src/uts/i86xpv/io/privcmd_hcall.c b/usr/src/uts/i86xpv/io/privcmd_hcall.c
index 0c9a6198ab..85ab0ed707 100644
--- a/usr/src/uts/i86xpv/io/privcmd_hcall.c
+++ b/usr/src/uts/i86xpv/io/privcmd_hcall.c
@@ -1067,6 +1067,7 @@ privcmd_HYPERVISOR_mmuext_op(struct mmuext_op *op, int count, uint_t *scount,
 	struct mmuext_op *kop, single_kop;
 	import_export_t op_ie, scnt_ie;
 
+	kop = NULL;
 	op_ie = scnt_ie = null_ie;
 	error = 0;
 
diff --git a/usr/src/uts/i86xpv/io/psm/xpv_psm.c b/usr/src/uts/i86xpv/io/psm/xpv_psm.c
index 94308c3f2f..5e19d7def9 100644
--- a/usr/src/uts/i86xpv/io/psm/xpv_psm.c
+++ b/usr/src/uts/i86xpv/io/psm/xpv_psm.c
@@ -1111,6 +1111,7 @@ xpv_psm_get_msi_vector(dev_info_t *dip, int type, int entry)
 	uchar_t			vector;
 
 	ASSERT((handle != NULL) && (cap_ptr != 0));
+	vector = 0;
 	if (type == DDI_INTR_TYPE_MSI) {
 		msi_ctrl = pci_config_get16(handle, cap_ptr + PCI_MSI_CTRL);
 		/*
diff --git a/usr/src/uts/i86xpv/os/mp_xen.c b/usr/src/uts/i86xpv/os/mp_xen.c
index fb41f72b0b..d430ad8735 100644
--- a/usr/src/uts/i86xpv/os/mp_xen.c
+++ b/usr/src/uts/i86xpv/os/mp_xen.c
@@ -846,6 +846,7 @@ vcpu_config_report(processorid_t id, uint_t newstate, int error)
 	size_t len;
 	char *ps;
 
+	ps = NULL;
 	switch (newstate) {
 	case P_ONLINE:
 		ps = PS_ONLINE;
diff --git a/usr/src/uts/i86xpv/os/xpv_panic.c b/usr/src/uts/i86xpv/os/xpv_panic.c
index 594fcd4c31..3778f526ef 100644
--- a/usr/src/uts/i86xpv/os/xpv_panic.c
+++ b/usr/src/uts/i86xpv/os/xpv_panic.c
@@ -195,6 +195,7 @@ xpv_va_walk(uintptr_t *vaddr)
 	static pfn_t toplevel_pfn;
 	static uintptr_t lastva;
 
+	pte = 0;
 	/*
 	 * If we do anything other than a simple scan through memory, don't
 	 * trust the mapped page tables.