6189 want smbios 3.0 support

6190 libsmbios checks against the wrong version
6191 libsmbios can be a bit more forgiving to the past
6192 smbios misprints extended onboard devices
Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Approved by: Garrett D'Amore <garrett@damore.org>

7 files changed, 181 insertions, 23 deletions

diff --git a/usr/src/cmd/smbios/smbios.c b/usr/src/cmd/smbios/smbios.c
index 1278548fb7..a0bde99ac3 100644
--- a/usr/src/cmd/smbios/smbios.c
+++ b/usr/src/cmd/smbios/smbios.c
@@ -21,6 +21,7 @@
 
 /*
  * Copyright 2015 OmniTI Computer Consulting, Inc.  All rights reserved.
+ * Copyright 2015 Joyent, Inc.
  * Copyright 2010 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
@@ -439,20 +440,38 @@ print_processor(smbios_hdl_t *shp, id_t id, FILE *fp)
 		    (float)SMB_PRV_VOLTAGE(p.smbp_voltage) / 10);
 	}
 
-	if (p.smbp_corecount != 0)
-		oprintf(fp, "  Core Count: %u\n", p.smbp_corecount);
-	else
+	if (p.smbp_corecount != 0) {
+		if (p.smbp_corecount != 0xff || p.smbp_corecount2 == 0)
+			oprintf(fp, "  Core Count: %u\n", p.smbp_corecount);
+		else
+			oprintf(fp, "  Core Count: %u\n", p.smbp_corecount2);
+	} else {
 		oprintf(fp, "  Core Count: Unknown\n");
+	}
 
-	if (p.smbp_coresenabled != 0)
-		oprintf(fp, "  Cores Enabled: %u\n", p.smbp_coresenabled);
-	else
+	if (p.smbp_coresenabled != 0) {
+		if (p.smbp_coresenabled != 0xff || p.smbp_coresenabled2 == 0) {
+			oprintf(fp, "  Cores Enabled: %u\n",
+			    p.smbp_coresenabled);
+		} else {
+			oprintf(fp, "  Cores Enabled: %u\n",
+			    p.smbp_coresenabled2);
+		}
+	} else {
 		oprintf(fp, "  Cores Enabled: Unknown\n");
+	}
 
-	if (p.smbp_threadcount != 0)
-		oprintf(fp, "  Thread Count: %u\n", p.smbp_threadcount);
-	else
+	if (p.smbp_threadcount != 0) {
+		if (p.smbp_threadcount != 0xff || p.smbp_threadcount2 == 0) {
+			oprintf(fp, "  Thread Count: %u\n",
+			    p.smbp_threadcount);
+		} else {
+			oprintf(fp, "  Thread Count: %u\n",
+			    p.smbp_threadcount2);
+		}
+	} else {
 		oprintf(fp, "  Thread Count: Unknown\n");
+	}
 
 	if (p.smbp_cflags) {
 		flag_printf(fp, "Processor Characteristics",
@@ -590,12 +609,23 @@ print_slot(smbios_hdl_t *shp, id_t id, FILE *fp)
 static void
 print_obdevs_ext(smbios_hdl_t *shp, id_t id, FILE *fp)
 {
+	boolean_t enabled;
 	smbios_obdev_ext_t oe;
+	const char *type;
 
 	(void) smbios_info_obdevs_ext(shp, id, &oe);
 
+	/*
+	 * Bit 7 is always whether or not the device is enabled while bits 0:6
+	 * are the actual device type.
+	 */
+	enabled = oe.smboe_dtype >> 7;
+	type = smbios_onboard_type_desc(oe.smboe_dtype & 0x7f);
+
 	oprintf(fp, "  Reference Designator: %s\n", oe.smboe_name);
-	oprintf(fp, "  Device Type: %u\n", oe.smboe_dtype);
+	oprintf(fp, "  Device Enabled: %s\n", enabled == B_TRUE ? "true" :
+	    "false");
+	oprintf(fp, "  Device Type: %s\n", type);
 	oprintf(fp, "  Device Type Instance: %u\n", oe.smboe_dti);
 	oprintf(fp, "  Segment Group Number: %u\n", oe.smboe_sg);
 	oprintf(fp, "  Bus Number: %u\n", oe.smboe_bus);
diff --git a/usr/src/common/smbios/mktables.sh b/usr/src/common/smbios/mktables.sh
index 73537a81f3..0d8f0cf997 100644
--- a/usr/src/common/smbios/mktables.sh
+++ b/usr/src/common/smbios/mktables.sh
@@ -83,6 +83,7 @@ SMB_MDF_	smbios_memdevice_flag_desc	uint_t
 SMB_MDFF_	smbios_memdevice_form_desc	uint_t
 SMB_MDT_	smbios_memdevice_type_desc	uint_t
 SMB_MDR_	smbios_memdevice_rank_desc	uint_t
+SMB_OBT_	smbios_onboard_type_desc	uint_t
 SMB_POC_	smbios_port_conn_desc		uint_t
 SMB_POT_	smbios_port_type_desc		uint_t
 SMB_PRC_	smbios_processor_core_flag_desc	uint_t
diff --git a/usr/src/common/smbios/smb_info.c b/usr/src/common/smbios/smb_info.c
index edd4f312b6..2eb9d8351b 100644
--- a/usr/src/common/smbios/smb_info.c
+++ b/usr/src/common/smbios/smb_info.c
@@ -21,6 +21,7 @@
 
 /*
  * Copyright 2015 OmniTI Computer Consulting, Inc.  All rights reserved.
+ * Copyright 2015 Joyent, Inc.
  * Copyright 2010 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
@@ -45,6 +46,23 @@
  * also to automatically handle the case of a structure that has been extended.
  * When necessary, this code can use smb_gteq() to determine whether the SMBIOS
  * data is of a particular revision that is supposed to contain a new field.
+ *
+ * Note, when trying to bzero the caller's struct you have to be careful about
+ * versions. One can only bzero the initial version that existed in illumos. In
+ * other words, if someone passes an older library handle that doesn't support a
+ * version you cannot assume that their structures have those additional members
+ * in them. Instead, a 'base' version is introduced for such types that have
+ * differences and instead we only bzero out the base version and then handle
+ * the additional members. In general, because all additional members will be
+ * assigned, there's no reason to zero them out unless they are arrays that
+ * won't be entirely filled in.
+ *
+ * Due to history, anything added after the update from version 2.4, in other
+ * words additions from or after '5094 Update libsmbios with recent items'
+ * (4e901881) is currently being used for this. While we don't allow software
+ * compiling against this to get an older form, this was the first major update
+ * and a good starting point for us to enforce this behavior which is useful for
+ * moving forward to making this more public.
  */
 
 #include <sys/smbios_impl.h>
@@ -423,7 +441,10 @@ smbios_info_chassis(smbios_hdl_t *shp, id_t id, smbios_chassis_t *chp)
 		return (smb_set_errno(shp, ESMB_TYPE));
 
 	smb_info_bcopy(stp->smbst_hdr, ch, sizeof (buf));
-	bzero(chp, sizeof (smbios_chassis_t));
+	bzero(chp, sizeof (smb_base_chassis_t));
+	if (shp->sh_libvers >= SMB_VERSION_27) {
+		bzero(chp->smbc_sku, sizeof (chp->smbc_sku));
+	}
 
 	chp->smbc_oemdata = ch->smbch_oemdata;
 	chp->smbc_lock = (ch->smbch_type & SMB_CHT_LOCK) != 0;
@@ -437,7 +458,7 @@ smbios_info_chassis(smbios_hdl_t *shp, id_t id, smbios_chassis_t *chp)
 	chp->smbc_elems = ch->smbch_cn;
 	chp->smbc_elemlen = ch->smbch_cm;
 
-	if (shp->sh_smbvers >= SMB_VERSION_27) {
+	if (shp->sh_libvers >= SMB_VERSION_27) {
 		(void) strlcpy(chp->smbc_sku, SMB_CH_SKU(ch),
 		    sizeof (chp->smbc_sku));
 	}
@@ -458,7 +479,7 @@ smbios_info_processor(smbios_hdl_t *shp, id_t id, smbios_processor_t *pp)
 		return (smb_set_errno(shp, ESMB_TYPE));
 
 	smb_info_bcopy(stp->smbst_hdr, &p, sizeof (p));
-	bzero(pp, sizeof (smbios_processor_t));
+	bzero(pp, sizeof (smb_base_processor_t));
 
 	pp->smbp_cpuid = p.smbpr_cpuid;
 	pp->smbp_type = p.smbpr_type;
@@ -472,16 +493,22 @@ smbios_info_processor(smbios_hdl_t *shp, id_t id, smbios_processor_t *pp)
 	pp->smbp_l2cache = p.smbpr_l2cache;
 	pp->smbp_l3cache = p.smbpr_l3cache;
 
-	if (shp->sh_smbvers >= SMB_VERSION_25) {
+	if (shp->sh_libvers >= SMB_VERSION_25) {
 		pp->smbp_corecount = p.smbpr_corecount;
 		pp->smbp_coresenabled = p.smbpr_coresenabled;
 		pp->smbp_threadcount = p.smbpr_threadcount;
 		pp->smbp_cflags = p.smbpr_cflags;
 	}
 
-	if (shp->sh_smbvers >= SMB_VERSION_26)
+	if (shp->sh_libvers >= SMB_VERSION_26)
 		pp->smbp_family2 = p.smbpr_family2;
 
+	if (shp->sh_libvers >= SMB_VERSION_30) {
+		pp->smbp_corecount2 = p.smbpr_corecount2;
+		pp->smbp_coresenabled2 = p.smbpr_coresenabled2;
+		pp->smbp_threadcount2 = p.smbpr_threadcount2;
+	}
+
 	return (0);
 }
 
@@ -787,7 +814,7 @@ smbios_info_memdevice(smbios_hdl_t *shp, id_t id, smbios_memdevice_t *mdp)
 		return (smb_set_errno(shp, ESMB_TYPE));
 
 	smb_info_bcopy(stp->smbst_hdr, &m, sizeof (m));
-	bzero(mdp, sizeof (smbios_memdevice_t));
+	bzero(mdp, sizeof (smb_base_memdevice_t));
 
 	mdp->smbmd_array = m.smbmdev_array;
 	mdp->smbmd_error = m.smbmdev_error;
@@ -814,13 +841,13 @@ smbios_info_memdevice(smbios_hdl_t *shp, id_t id, smbios_memdevice_t *mdp)
 	mdp->smbmd_dloc = smb_strptr(stp, m.smbmdev_dloc);
 	mdp->smbmd_bloc = smb_strptr(stp, m.smbmdev_bloc);
 
-	if (shp->sh_smbvers >= SMB_VERSION_26)
+	if (shp->sh_libvers >= SMB_VERSION_26)
 		mdp->smbmd_rank = m.smbmdev_attrs & 0x0F;
 
-	if (shp->sh_smbvers >= SMB_VERSION_27)
+	if (shp->sh_libvers >= SMB_VERSION_27)
 		mdp->smbmd_clkspeed = m.smbmdev_clkspeed;
 
-	if (shp->sh_smbvers >= SMB_VERSION_28) {
+	if (shp->sh_libvers >= SMB_VERSION_28) {
 		mdp->smbmd_minvolt = m.smbmdev_minvolt;
 		mdp->smbmd_maxvolt = m.smbmdev_maxvolt;
 		mdp->smbmd_confvolt = m.smbmdev_confvolt;
diff --git a/usr/src/common/smbios/smb_open.c b/usr/src/common/smbios/smb_open.c
index 05c9179c64..242facc161 100644
--- a/usr/src/common/smbios/smb_open.c
+++ b/usr/src/common/smbios/smb_open.c
@@ -21,6 +21,7 @@
 
 /*
  * Copyright 2015 OmniTI Computer Consulting, Inc.  All rights reserved.
+ * Copyright 2015 Joyent, Inc.
  * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
@@ -87,6 +88,7 @@ smbios_bufopen(const smbios_entry_t *ep, const void *buf, size_t len,
 	case SMB_VERSION_26:
 	case SMB_VERSION_27:
 	case SMB_VERSION_28:
+	case SMB_VERSION_30:
 		break;
 	default:
 		return (smb_open_error(shp, errp, ESMB_VERSION));
diff --git a/usr/src/lib/libsmbios/common/mapfile-vers b/usr/src/lib/libsmbios/common/mapfile-vers
index 046b4e298d..c618572a12 100644
--- a/usr/src/lib/libsmbios/common/mapfile-vers
+++ b/usr/src/lib/libsmbios/common/mapfile-vers
@@ -120,6 +120,7 @@ SYMBOL_VERSION SUNWprivate_1.1 {
 	smbios_memdevice_type_desc;
 	smbios_memdevice_rank_desc;
 	smbios_open;
+	smbios_onboard_type_desc;
 	smbios_port_conn_desc;
 	smbios_port_type_desc;
 	smbios_processor_family_desc;
diff --git a/usr/src/uts/common/sys/smbios.h b/usr/src/uts/common/sys/smbios.h
index 75a9173dbe..7e653cb911 100644
--- a/usr/src/uts/common/sys/smbios.h
+++ b/usr/src/uts/common/sys/smbios.h
@@ -21,6 +21,7 @@
 
 /*
  * Copyright 2015 OmniTI Computer Consulting, Inc. All rights reserved.
+ * Copyright 2015 Joyent, Inc.
  * Copyright 2010 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
@@ -345,6 +346,9 @@ typedef struct smbios_chassis {
 #define	SMB_CHT_ATCA		0x1B	/* advanced TCA */
 #define	SMB_CHT_BLADE		0x1C	/* blade */
 #define	SMB_CHT_BLADEENC	0x1D	/* blade enclosure */
+#define	SMB_CHT_TABLET		0x1E	/* tablet */
+#define	SMB_CHT_CONVERTIBLE	0x1F	/* convertible */
+#define	SMB_CHT_DETACHABLE	0x20	/* detachable */
 
 #define	SMB_CHST_OTHER		0x01	/* other */
 #define	SMB_CHST_UNKNOWN	0x02	/* unknown */
@@ -382,14 +386,18 @@ typedef struct smbios_processor {
 	id_t smbp_l1cache;		/* L1 cache handle */
 	id_t smbp_l2cache;		/* L2 cache handle */
 	id_t smbp_l3cache;		/* L3 cache handle */
-	uint8_t smbp_corecount;	/* number of cores per processor socket */
-	uint8_t smbp_coresenabled;
+	uint32_t smbp_corecount;
+		/* number of cores per processor socket */
+	uint32_t smbp_coresenabled;
 		/* number of enabled cores per processor socket */
-	uint8_t smbp_threadcount;
+	uint32_t smbp_threadcount;
 		/* number of threads per processor socket */
 	uint16_t smbp_cflags;
 		/* processor characteristics (SMB_PRC_*) */
 	uint16_t smbp_family2;		/* processor family 2 */
+	uint16_t smbp_corecount2;	/* core count 2 */
+	uint16_t smbp_coresenabled2;	/* cores enabled 2 */
+	uint16_t smbp_threadcount2;	/* thread count 2 */
 } smbios_processor_t;
 
 #define	SMB_PRT_OTHER		0x01	/* other */
@@ -462,6 +470,10 @@ typedef struct smbios_processor {
 #define	SMB_PRU_FM2		0x2A	/* socket FM2 */
 #define	SMB_PRU_LGA20113	0x2B	/* LGA2011-3 */
 #define	SMB_PRU_LGA13563	0x2C	/* LGA1356-3 */
+#define	SMB_PRU_LGA1150		0x2D	/* LGA1150 */
+#define	SMB_PRU_BGA1168		0x2E	/* BGA1168 */
+#define	SMB_PRU_BGA1234		0x2F	/* BGA1234 */
+#define	SMB_PRU_BGA1364		0x30	/* BGA1364 */
 
 #define	SMB_PRC_RESERVED	0x0001	/* reserved */
 #define	SMB_PRC_UNKNOWN		0x0002	/* unknown */
@@ -513,6 +525,7 @@ typedef struct smbios_processor {
 #define	SMB_PRF_CORE_DUO_M	0x29	/* Core Duo mobile */
 #define	SMB_PRF_CORE_SOLO_M	0x2A	/* Core Solo mobile */
 #define	SMB_PRF_ATOM		0x2B	/* Intel Atom */
+#define	SMB_PRF_CORE_M		0x2C	/* Intel Core M */
 #define	SMB_PRF_ALPHA		0x30	/* Alpha */
 #define	SMB_PRF_ALPHA_21064	0x31	/* Alpha 21064 */
 #define	SMB_PRF_ALPHA_21066	0x32	/* Alpha 21066 */
@@ -561,6 +574,9 @@ typedef struct smbios_processor {
 #define	SMB_PRF_68010		0x63	/* 68010 */
 #define	SMB_PRF_68020		0x64	/* 68020 */
 #define	SMB_PRF_68030		0x65	/* 68030 */
+#define	SMB_PRF_ATHLON_X4	0x66	/* AMD Athlon X4 Quad-Core */
+#define	SMB_PRF_OPTERON_X1K	0x67	/* AMD Opteron X1000 */
+#define	SMB_PRF_OPTERON_X2K	0x68	/* AMD Opteron X2000 APU */
 #define	SMB_PRF_HOBBIT		0x70	/* Hobbit */
 #define	SMB_PRF_TM5000		0x78	/* Crusoe TM5000 */
 #define	SMB_PRF_TM3000		0x79	/* Crusoe TM3000 */
@@ -870,6 +886,19 @@ typedef struct smbios_slot {
 #define	SMB_SLT_AGP4X		0x11	/* AGP 4X */
 #define	SMB_SLT_PCIX		0x12	/* PCI-X */
 #define	SMB_SLT_AGP8X		0x13	/* AGP 8X */
+#define	SMB_SLT_M2_1DP		0x14	/* M.2 Socket 1-DP (Mechanical Key A) */
+#define	SMB_SLT_M2_1SD		0x15	/* M.2 Socket 1-SD (Mechanical Key E) */
+#define	SMB_SLT_M2_2		0x16	/* M.2 Socket 2 (Mechanical Key B) */
+#define	SMB_SLT_M2_3		0x17	/* M.2 Socket 3 (Mechanical Key M) */
+#define	SMB_SLT_MXM_I		0x18	/* MXM Type I */
+#define	SMB_SLT_MXM_II		0x19	/* MXM Type II */
+#define	SMB_SLT_MXM_III		0x1A	/* MXM Type III (standard connector) */
+#define	SMB_SLT_MXM_III_HE	0x1B	/* MXM Type III (HE connector) */
+#define	SMB_SLT_MXM_V		0x1C	/* MXM Type IV */
+#define	SMB_SLT_MXM3_A		0x1D	/* MXM 3.0 Type A */
+#define	SMB_SLT_MXM3_B		0x1E	/* MXM 3.0 Type B */
+#define	SMB_SLT_PCIEG2_SFF	0x1F	/* PCI Express Gen 2 SFF-8639 */
+#define	SMB_SLT_PCIEG3_SFF	0x20	/* PCI Express Gen 3 SFF-8639 */
 #define	SMB_SLT_PC98_C20	0xA0	/* PC-98/C20 */
 #define	SMB_SLT_PC98_C24	0xA1	/* PC-98/C24 */
 #define	SMB_SLT_PC98_E		0xA2	/* PC-98/E */
@@ -1124,6 +1153,11 @@ typedef struct smbios_memdevice {
 #define	SMB_MDT_DDR2FBDIMM	0x14	/* DDR2 FBDIMM */
 #define	SMB_MDT_DDR3		0x18	/* DDR3 */
 #define	SMB_MDT_FBD2		0x19	/* FBD2 */
+#define	SMB_MDT_DDR4		0x1A	/* DDR4 */
+#define	SMB_MDT_LPDDR		0x1B	/* LPDDR */
+#define	SMB_MDT_LPDDR2		0x1C	/* LPDDR2 */
+#define	SMB_MDT_LPDDR3		0x1D	/* LPDDR3 */
+#define	SMB_MDT_LPDDR4		0x1E	/* LPDDR4 */
 
 #define	SMB_MDF_OTHER		0x0002	/* other */
 #define	SMB_MDF_UNKNOWN		0x0004	/* unknown */
@@ -1320,7 +1354,8 @@ typedef struct smbios_memdevice_ext {
 #define	SMB_VERSION_26	0x0206		/* SMBIOS encoding for DMTF spec 2.6 */
 #define	SMB_VERSION_27	0x0207		/* SMBIOS encoding for DMTF spec 2.7 */
 #define	SMB_VERSION_28	0x0208		/* SMBIOS encoding for DMTF spec 2.8 */
-#define	SMB_VERSION	SMB_VERSION_28	/* SMBIOS latest version definitions */
+#define	SMB_VERSION_30	0x0300		/* SMBIOS encoding for DMTF spec 3.0 */
+#define	SMB_VERSION	SMB_VERSION_30	/* SMBIOS latest version definitions */
 
 #define	SMB_O_NOCKSUM	0x1		/* do not verify header checksums */
 #define	SMB_O_NOVERS	0x2		/* do not verify header versions */
@@ -1453,6 +1488,8 @@ extern const char *smbios_memdevice_flag_name(uint_t);
 extern const char *smbios_memdevice_flag_desc(uint_t);
 extern const char *smbios_memdevice_rank_desc(uint_t);
 
+extern const char *smbios_onboard_type_desc(uint_t);
+
 extern const char *smbios_port_conn_desc(uint_t);
 extern const char *smbios_port_type_desc(uint_t);
 
diff --git a/usr/src/uts/common/sys/smbios_impl.h b/usr/src/uts/common/sys/smbios_impl.h
index 0013dcba2b..a668d6678f 100644
--- a/usr/src/uts/common/sys/smbios_impl.h
+++ b/usr/src/uts/common/sys/smbios_impl.h
@@ -21,6 +21,7 @@
 
 /*
  * Copyright 2015 OmniTI Computer Consulting, Inc.  All rights reserved.
+ * Copyright 2015 Joyent, Inc.
  * Copyright 2010 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
@@ -145,6 +146,9 @@ typedef struct smb_processor {
 	uint8_t smbpr_threadcount;	/* number of threads per socket */
 	uint16_t smbpr_cflags;	/* cpu characteristics (see <smbios.h>) */
 	uint16_t smbpr_family2;		/* processor family2 (see <smbios.h>) */
+	uint16_t smbpr_corecount2;	/* second number of cores per socket */
+	uint16_t smbpr_coresenabled2;	/* second number of enabled cores */
+	uint16_t smbpr_threadcount2;	/* second number of enabled threads */
 } smb_processor_t;
 
 typedef struct smb_cache {
@@ -506,6 +510,62 @@ extern void smb_dprintf(smbios_hdl_t *, const char *, ...);
 
 extern int _smb_debug;
 
+/*
+ * The following series of structures represent the base versions of public
+ * structures that are used inside by the smbios routines. This allows the
+ * common code to properly know how much it should or should not bzero and how
+ * to handle additions to the spec. Types should only be added here if we need
+ * to extend the public structures in sys/smbios.h due to a change in the spec.
+ *
+ * Types here have the name smb_base_%s which corresponds to smbios_%s.
+ */
+typedef struct smb_base_chassis {
+	uint32_t smbbc_oemdata;		/* OEM-specific data */
+	uint8_t smbbc_lock;		/* lock present? */
+	uint8_t smbbc_type;		/* type */
+	uint8_t smbbc_bustate;		/* boot-up state */
+	uint8_t smbbc_psstate;		/* power supply state */
+	uint8_t smbbc_thstate;		/* thermal state */
+	uint8_t smbbc_security;		/* security status */
+	uint8_t smbbc_uheight;		/* enclosure height in U's */
+	uint8_t smbbc_cords;		/* number of power cords */
+	uint8_t smbbc_elems;		/* number of element records (n) */
+	uint8_t smbbc_elemlen;		/* length of contained element (m) */
+} smb_base_chassis_t;
+
+typedef struct smb_base_processor {
+	uint64_t smbbp_cpuid;		/* processor cpuid information */
+	uint32_t smbbp_family;		/* processor family */
+	uint8_t smbbp_type;		/* processor type (SMB_PRT_*) */
+	uint8_t smbbp_voltage;		/* voltage (SMB_PRV_*) */
+	uint8_t smbbp_status;		/* status (SMB_PRS_*) */
+	uint8_t smbbp_upgrade;		/* upgrade (SMB_PRU_*) */
+	uint32_t smbbp_clkspeed;	/* external clock speed in MHz */
+	uint32_t smbbp_maxspeed;	/* maximum speed in MHz */
+	uint32_t smbbp_curspeed;	/* current speed in MHz */
+	id_t smbbp_l1cache;		/* L1 cache handle */
+	id_t smbbp_l2cache;		/* L2 cache handle */
+	id_t smbbp_l3cache;		/* L3 cache handle */
+} smb_base_processor_t;
+
+typedef struct smb_base_memdevice {
+	id_t smbbmd_array;		/* handle of physical memory array */
+	id_t smbbmd_error;		/* handle of memory error data */
+	uint32_t smbbmd_twidth;		/* total width in bits including ecc */
+	uint32_t smbbmd_dwidth;		/* data width in bits */
+	uint64_t smbbmd_size;		/* size in bytes (see note above) */
+	uint8_t smbbmd_form;		/* form factor */
+	uint8_t smbbmd_set;		/* set (0x00=none, 0xFF=unknown) */
+	uint8_t smbbmd_type;		/* memory type */
+	uint8_t smbbmd_pad;		/* padding */
+	uint32_t smbbmd_flags;		/* flags (see below) */
+	uint32_t smbbmd_speed;		/* speed in MHz */
+	const char *smbbmd_dloc;	/* physical device locator string */
+	const char *smbbmd_bloc;	/* physical bank locator string */
+	uint8_t smbbmd_rank;		/* rank */
+} smb_base_memdevice_t;
+
+
 #ifdef	__cplusplus
 }
 #endif