summaryrefslogtreecommitdiff
path: root/usr/src
diff options
context:
space:
mode:
authorToomas Soome <tsoome@me.com>2017-07-16 17:13:58 +0300
committerDan McDonald <danmcd@joyent.com>2018-08-14 14:05:09 -0400
commit9fed930b55df5aeaba1280325625a29e78199a54 (patch)
tree75fa4d2a83cacc539c931ada5c91e1671ef6067b /usr/src
parent223ffd476e2703f912aa332a875dfb72ab5d7010 (diff)
downloadillumos-joyent-9fed930b55df5aeaba1280325625a29e78199a54.tar.gz
9367 troff: comparison between pointer and zero character constant
Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> Reviewed by: Ken Mays <kmays2000@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>
Diffstat (limited to 'usr/src')
-rw-r--r--usr/src/cmd/troff/n1.c19
1 files changed, 9 insertions, 10 deletions
diff --git a/usr/src/cmd/troff/n1.c b/usr/src/cmd/troff/n1.c
index 889c886418..f1f2f00134 100644
--- a/usr/src/cmd/troff/n1.c
+++ b/usr/src/cmd/troff/n1.c
@@ -37,9 +37,6 @@
* contributors.
*/
-#pragma ident "%Z%%M% %I% %E% SMI"
-
-char *xxxvers = "@(#)roff:n1.c 2.13";
/*
* n1.c
*
@@ -107,7 +104,7 @@ main(int argc, char **argv)
tchar i;
int eileenct; /*count to test for "Eileen's loop"*/
extern void catch(), kcatch();
- char **oargv, *getenv();
+ char **oargv;
(void)setlocale(LC_ALL, "");
#if !defined(TEXT_DOMAIN)
@@ -145,7 +142,7 @@ main(int argc, char **argv)
strcpy(fontfile, &argv[0][2]);
} else {
argv++; argc--;
- if (argv[0] != '\0') {
+ if (argv[0] != NULL) {
strcpy(termtab, argv[0]);
strcpy(fontfile, argv[0]);
} else
@@ -181,11 +178,12 @@ main(int argc, char **argv)
ptid = 1;
continue;
case 'r':
- if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0')
- eibuf = roff_sprintf(ibuf+strlen(ibuf), ".nr %c %s\n",
- argv[0][2], &argv[0][3]);
- else
+ if (strlen(&argv[0][2]) >= 2) {
+ eibuf = roff_sprintf(ibuf+strlen(ibuf),
+ ".nr %c %s\n", argv[0][2], &argv[0][3]);
+ } else {
errprint(gettext("wrong options"));
+ }
continue;
case 'c':
case 'm':
@@ -198,7 +196,8 @@ main(int argc, char **argv)
errprint(gettext("No library provided with -m"));
done(02);
}
- if (getenv("TROFFMACS") != '\0') {
+ p = getenv("TROFFMACS");
+ if (p != NULL && *p != '\0') {
if (tryfile(getenv("TROFFMACS"), &argv[0][2], nmfi))
nmfi++;
} else