diff options
| author | Cody Peter Mello <cody.mello@joyent.com> | 2016-04-19 21:51:24 +0000 |
|---|---|---|
| committer | Robert Mustacchi <rm@joyent.com> | 2016-06-09 16:46:18 -0700 |
| commit | bc07d1fd58f705e3a6d5b418433e42cd8e42b7f1 (patch) | |
| tree | 971bdbc84783d3ebe95fad99edcca6b61d81c4b8 /usr | |
| parent | a76660dbabd3d3b161bdead081ce275af6966d2e (diff) | |
| download | illumos-joyent-bc07d1fd58f705e3a6d5b418433e42cd8e42b7f1.tar.gz | |
7060 mdb -e doesn't properly report exit status for failed writes
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Dan McDonald <danmcd@omniti.com>
Diffstat (limited to 'usr')
| -rw-r--r-- | usr/src/cmd/mdb/common/mdb/mdb_cmds.c | 5 | ||||
| -rw-r--r-- | usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh | 1 | ||||
| -rw-r--r-- | usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh | 1 |
3 files changed, 4 insertions, 3 deletions
diff --git a/usr/src/cmd/mdb/common/mdb/mdb_cmds.c b/usr/src/cmd/mdb/common/mdb/mdb_cmds.c index 829797336f..f8672df76c 100644 --- a/usr/src/cmd/mdb/common/mdb/mdb_cmds.c +++ b/usr/src/cmd/mdb/common/mdb/mdb_cmds.c @@ -253,7 +253,7 @@ write_arglist(mdb_tgt_as_t as, mdb_tgt_addr_t addr, mdb_warn("failed to write %llr at address 0x%llx", value, addr); mdb.m_incr = 0; - break; + return (DCMD_ERR); } mdb.m_incr = naddr - addr; @@ -521,8 +521,7 @@ cmd_print_phys(uintptr_t x, uint_t flags, int argc, const mdb_arg_t *argv) /*ARGSUSED*/ static int -cmd_print_value(uintptr_t addr, uint_t flags, - int argc, const mdb_arg_t *argv) +cmd_print_value(uintptr_t addr, uint_t flags, int argc, const mdb_arg_t *argv) { uintmax_t ndot, dot = mdb_get_dot(); const char *tgt_argv[1]; diff --git a/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh b/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh new file mode 100644 index 0000000000..8f0fda2253 --- /dev/null +++ b/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh @@ -0,0 +1 @@ +$MDB -e '0xbaddcafe/v 0x02' diff --git a/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh b/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh new file mode 100644 index 0000000000..874283f186 --- /dev/null +++ b/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh @@ -0,0 +1 @@ +$MDB -e '0x0/v 0x02' /bin/ls |