summaryrefslogtreecommitdiff
path: root/usr/src/lib/libc/port
AgeCommit message (Collapse)AuthorFilesLines
2022-03-15OS-8361 IPD 4 (man page renumbering) tracking issueDan McDonald9-16/+14
Reviewed by: Brian Bennett <brian.bennett@joyent.com> Approved by: Brian Bennett <brian.bennett@joyent.com>
2022-01-26 [illumos-gate merge]Dan McDonald3-16/+14
commit 70ae9a334a768113a660b21305bf7d2cff941499 14425 want probes for invvpid and invept 14426 expand seg_vmm tests commit 25cdfc4f8d373444e56178d1053ca53f1c3ea928 14428 formatting issues in memory(3c) man page commit ab3f6e90e6b1d8edee27c66beb8e53bc6033fb2a 14419 iprb transmit watchdog somewhat overzealous commit c9b01782224c4b5ea00e251ce64cfbd68ce276d6 14396 Makefile.master: gcc 11 support commit 5528cade4e43d027d848fdca33cccc9faa97823b 14388 des: with mismatched bound commit f4203ebbfd2dce9537b7614c6e37240f406907e8 14389 net80211: mismatched bound commit 2829495d7d810156bdfd454b8a1ef0f54eac9733 14386 libc: build errors with gcc 11 commit 1b863af9bc9a5c76ed773e129889fc19dbf9e41c 14393 stmf_sbd: build errors with gcc 11 commit 050c24f35c93857f1022f99834086ade54e70547 14326 dt_unring_buf: set dtbd_oldest to the start of the first record commit 817002c416c9301664eafbc288940123aa7d6fc9 14442 NVMe theory statement on spec version is confusing
2022-01-2514386 libc: build errors with gcc 11Toomas Soome3-16/+14
Reviewed by: Andy Fiddaman <andy@omnios.org> Approved by: Dan McDonald <danmcd@joyent.com>
2021-09-1514005 eventfd_read/write() don't return failureAndy Fiddaman1-2/+9
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Dan McDonald <danmcd@joyent.com> Approved by: Robert Mustacchi <rm@fingolfin.org>
2021-08-20 [illumos-gate merge]Dan McDonald2-0/+43
commit a2027c5d4c477546faea39a790b019c3480c9b9b 13965 loader: open file list should be dynamic commit d6bf170859287b7b5b26419e266a7e6fdee7ff4d 13997 Want memrchr in libc Conflicts: manifest
2021-08-2013997 Want memrchr in libcRobert Mustacchi2-0/+43
Reviewed by: Joshua M. Clulow <josh@sysmgr.org> Reviewed by: Andy Fiddaman <andy@omnios.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>
2021-08-1114005 eventfd_read/write() don't return failureAndy Fiddaman1-2/+9
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Dan McDonald <danmcd@joyent.com> (Early pull-in for 20210812)
2021-04-19 [illumos-gate merge]Dan McDonald1-3/+49
commit 2282d3b00bd23a5df4dfea0edd5ae737693bd4b7 13713 vm_unmap_mmio() should return non zero on error commit 9558d0b12b2242f8f19a3526ff0656c48b28f657 13712 bhyve allows vmspace mapping inside existing range commit 5920236ba222e7ab53c90f117bfc66be6c043363 13322 build zfs command as 64-bit binary commit 414dafc0a71bccb9c69d6801ed11ba1016a8082b 13714 pcieadm pci check misses renamed nodes 13715 pcieadm save-cfgspace doesn't work with b/d/f 13716 pcieadm save-cfgspace -a can't open files commit 7e85189a2092f2550c3af3a55e22564546838229 13487 want mapfile-based assertions about symbol properties (fix SPARC)
2021-04-1513487 want mapfile-based assertions about symbol properties (fix SPARC)Toomas Soome1-3/+49
Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andy Fiddaman <andy@omnios.org> Reviewed by: Klaus Ziegler <klausz@haus-gisela.de> Approved by: Robert Mustacchi <rm@fingolfin.org>
2021-04-14 [illumos-gate merge]Dan McDonald1-395/+938
commit 15276eb5b5c891978242f14352c27676ed336244 13704 add Ice Lake Xeon to PPIN list 13705 add recent Intel models to x86_archext.h commit 6dcbfae4aa2c2aab7ebd7174bd2f0232528126b7 13201 IPS image re-hydration fails commit 8222814ef8560ee0ba222eca8ca5acffc6cd0e44 13487 want mapfile-based assertions about symbol properties commit 99ea293e719ac006d413e4fde6ac0d5cd4dd6c59 7668 zfs get only outputs 3 columns if "clones" property is empty Conflicts: usr/src/lib/libzfs/common/mapfile-vers
2021-04-0913487 want mapfile-based assertions about symbol propertiesRichard Lowe1-395/+938
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Jason King <jason.brian.king@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>
2021-03-19 [illumos-gate merge]Dan McDonald1-2/+48
commit fc1e9305ae86a296023d90240041e860548ba1bd 13627 chown(2) mixes up chown() and fchown() commit 173f6047c6877d03cbb55428e6ec95f07c9cbb83 13622 Memory leak in coretemp_create_sensor commit 1b1c4b089b04ffa47f04c2923dc78c7fcafcf964 13575 loader: use display pixel density for font autoselection commit 5fbc1fe0da7f34cf8155bf7624c94583cc98e47c 13526 cmd/availdevs always rebuilds commit b2761fb273089c452ca34297d7ab4a1d1c1f1012 13599 ahci(7d) requires alias for HP AHCI SATA controller commit 6edc7986d8c0034d072afac8b25477b983bf8f55 13586 getcwd() should accept a 0 length argument (fix mandoc) commit d6f391ef39bc41c64e16ac5d7b10c1c8d5b1761e 4149 ksh head builtin does not like newlines commit aa15372140b6b509a26742fd85fe78dd77d9a642 13586 getcwd() should accept a 0 length argument commit f38f28fdbc29b3c5020295a6c6cb1ac52e949978 13574 loader.efi: efifb_gop_get_edid() is broken commit 8781de92560745751daa24953330574a84de46e6 13632 smntemp doesn't need smntemp alias commit 7eb8c88abb70697edf48045434d2c18bb82ad2e7 9620 getcwd() syscall has unbounded memory allocation commit f9bbf53b825c087ef99dd9b3e51570ec68a51463 12558 Builtin command "printf" of ksh93 does not behave as specified commit 4162633a7c5961f388fdc51bcecb3016104b359f 3782 ksh93's builtin chown fails with numeric ids
2021-03-1613586 getcwd() should accept a 0 length argumentAndy Fiddaman1-2/+48
Reviewed by: Jason King <jason.king@joyent.com> Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Gordon Ross <gordon.w.ross@gmail.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Rich Lowe <richlowe@richlowe.net>
2021-01-22 [illumos-gate merge]Dan McDonald1-5/+7
commit 4efb20e81cede837b887da28bb6284155a828dab 13456 remove umem check_rtime exception commit 986778a303c760bb2204efc52ea9eba748546342 13356 syslog(3c) should not open syslog_door without LOG_CONS
2021-01-2113356 syslog(3c) should not open syslog_door without LOG_CONSDavid Hanisch1-5/+7
Reviewed by: Marcel Telka <marcel@telka.sk> Approved by: Robert Mustacchi <rm@fingolfin.org>
2020-12-09 [illumos-gate merge]Dan McDonald2-4/+132
commit f2c438c5058c64b7373448f239156bf60009abcb 7024 Add getgrouplist() to illumos commit adc528899caad05412c9b8d397e277900adf786b 13207 Creating an aggr with more than 128 Tx or Rx rings panics
2020-12-087024 Add getgrouplist() to illumosJason King2-4/+132
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>
2020-11-24 [illumos-gate merge]Dan McDonald1-1/+1
commit 273d774d1d685415fd99d31224bdae55e7cfb793 13315 jdk11 makes consistent javadoc generation impossible commit 560dcad7f6059e242335a94501511eae11b1308a 13314 loader: make sure console variable has usable consoles commit 18425b359c7d1e5f7f63fae3ca5245407223a45b 12318 build zpool command as 64-bit binary commit a39905c1c6671c3f44d52e31393ee7cdda7b4f12 13319 Typos in some LDSTACKPROTECT macros commit 059afd40d138a2155e774750e4dcabfd78c9d0be 13312 _thrp_create() should not set the thread name if passed an empty string commit 986529380f11a23c3c6de33e5cea6611d4abe648 13323 CTF forward test needs adjusting after 13278
2020-11-2113312 _thrp_create() should not set the thread name if passed an empty stringRobert Mustacchi1-1/+1
Reviewed by: Jason King <jason.brian.king@gmail.com> Reviewed by: Richard Lowe <richlowe@richlowe.net> Approved by: Dan McDonald <danmcd@joyent.com>
2020-11-17 [illumos-gate merge]release-20201119Dan McDonald5-23/+117
commit 5a0af8165ce9590e7a18f1ef4f9badc4dd72c6e6 13274 enable -fstack-protector-strong by default in user land commit 6a817834d81cc75ce12d0d393320837b1fec1e85 5788 Want support for GCC's stack protector in libc commit 350ffdd54baf880f440ddf9697666e283894ded1 13273 want upanic(2) commit 7fdea60d55a95f0e46066fd021c4ef1b1321bafc 13300 mlxcx_cq_setup() doesn't take required locks for ASSERTs Merge notes: - Manifest changes to match package changes (including shipping libssp_ns.a) - Modified lx_vdso tools to not include SSP, to match other build-only tools.
2020-11-175788 Want support for GCC's stack protector in libcRobert Mustacchi3-0/+80
Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>
2020-11-1713273 want upanic(2)Robert Mustacchi3-23/+37
Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Gordon Ross <gordon.w.ross@gmail.com>
2020-11-16 [illumos-gate merge]Jason King2-7/+7
commit de0f04687a2a3fe3692d9ad1254738343bf9c4eb 13310 Remove auto_ef.3ext as we don't have the software commit 25befe07d3c1488cbbdecdb765cd0558e12cc364 13302 pthread_attr_get_np.3c erroneously refers to pthread_getattr_np commit 509a605d87b8005c687f8d8264f1be379620e886 13304 bhyve ioport handling bungled on reinit commit 83cd75bb2949d26e6eb38ddefc60fdeed1909643 13309 bhyve movs emulation leaks mem refcnt commit b713c91e508f40be7797bedd4ae1146ef0652625 7537 want nextboot (one time boot) support commit 09fcda9fe16a733cc35aa3156a47ef4b909251a6 13172 Port OpenZFS: zfs label bootenv should store data as nvlist commit c4ecba8aa5f13f00c2439c06af2aa1198771ee66 13025 Port OpenZFS: Add support for boot environment data to be stored in the label commit 1a2acdcd3ce765904dbf2bfc511e92d68022d100 13308 testrunner/run needs updates for python 3.9 commit 04573c73a7ab1505c46b2c4db26bfde5176dd6a5 13286 bhyve ins/outs emulation misuses %rax commit 3dfdac06b0c70e672dbe56a2f38ec05fc0254d07 13278 CTF assertion failed cmp->cm_tmap[id].cmt_map == suid commit a676209deb2ce5d0c98f331659de25e2483f8c4c 13252 ctf_update()/ctf_dwarf_convert_function() leak memory commit effb27ee30c48fe502152c38487ced379d9f8693 13247 CTF conversion fails with large files 13251 CTF conversion fails if any CU is missing DWARF data Conflicts: usr/src/test/test-runner/cmd/run usr/src/lib/libctf/common/libctf.h usr/src/lib/libctf/common/ctf_convert.c
2020-11-1413302 pthread_attr_get_np.3c erroneously refers to pthread_getattr_npPeter Tribble2-7/+7
Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Gergő Mihály Doma <domag02@gmail.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2020-09-28 [illumos-gate merge]Jerry Jelinek2-108/+0
commit 28de4f3c3209c81f9a96e2019d44a0b9adcb74cb 13173 loader: add strtoul, strtoull, memmem and abort commit 3e1c5f3a80260eb14c78730bcaca9e6c74f528a0 13030 remove 'retu' pattern from bhyve 13031 bhyve kernel should use proper struct types
2020-09-2513173 loader: add strtoul, strtoull, memmem and abortToomas Soome2-108/+0
Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-24 [illumos-gate merge]Jerry Jelinek1-0/+5
commit 6d40a71ead689b14c68d91a5d92845e5f3daa020 1532 Long-term kernel-resident processes need a way to play fair commit cfd17c15945080ff766acfba4bfbc0ac4d2d31cd 13096 xnf asleep at wheel while freemem smashes into the ground commit baf00aa88d7d535ed115175b04253f5db99a7d0b 13094 systems have more kmem caches than they used to commit 727737b40e05e03cb1b298a96f67258b116ba990 13082 pageout needs a deadman commit 44431c82ebd7ee1d7c240683235e728d70d96cf2 3763 Implement qsort_r(3C) Conflicts: usr/src/uts/common/os/vm_pageout.c
2020-09-233763 Implement qsort_r(3C)Robert Mustacchi1-0/+5
Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-23 [illumos-gate merge]Jerry Jelinek2-4/+5
commit a9e414682948591ec63d5ab2cd11ba55603b59fa 6782 head can't handle embedded nul characters 13150 head -v doesn't work with a single file commit 37337afa1f0c469ab4b7343cf92da8c884b39b8b 13127 libc: for statement not indented commit ae41a23c315570b85d6bf190d7cc51e1bcb161c8 13181 Cleanup cat(1) man page commit 89abd63ca1d1795943e51095a12ea5ce6e035e88 13131 libc: _fgetwc_unlocked_l() warn: was '== &fp->_state' instead of '=' commit c64c5389d6d65f1a8915fd0ff67288100f518172 13141 Man page formatting runs words together commit a7f55c951e21deb266649b41baa71501d3382f4d 13140 Typos in the manual Conflicts: usr/src/test/util-tests/tests/Makefile
2020-09-2213127 libc: for statement not indentedToomas Soome1-3/+3
Reviewed by: Marco van Wieringen <mvw@planets.elm.net> Approved by: Robert Mustacchi <rm@fingolfin.org>
2020-09-2213131 libc: _fgetwc_unlocked_l() warn: was '== &fp->_state' instead of '='Toomas Soome1-1/+2
Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-22 [illumos-gate merge]Jerry Jelinek2-12/+12
commit ce87906fe0d027df0327d283b3423eaf1d3cdda5 13125 libc: unchecked function return 'nvfree' commit 64f188a3e276245cf34a8f6ef0189e1cc568b840 13160 loader: Remove NAND and NANDFS support commit 08a72deac9aaea53335ce22bdbc25eb85de27652 13159 loader: remove common/ufsread.c commit 7e63fc6f405ee1e58ef05d46f92cb5e1c441e8d7 13176 gptzfsboot: rework stage3 loading commit d83a2486bd7b53e4a9741736a076e098071b5cbd 13126 libc: variable dereferenced before check 'found'
2020-09-2113125 libc: unchecked function return 'nvfree'Toomas Soome1-1/+1
Reviewed by: Marco van Wieringen <mvw@planets.elm.net> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-2113126 libc: variable dereferenced before check 'found'Toomas Soome1-11/+11
Reviewed by: Jason King <jason.brian.king@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-18 [illumos-gate merge]Jerry Jelinek2-3/+31
commit 24571f7b017865fbad5f588fb0694b558c94e14d 13075 No console messages after early boot on non-VGA graphics commit 3d21c6bf2078598ab053d382b8a9af3b70b8e995 11064 md_clear is misspelt commit 73439c833efecf3010718112f4fce6bb183a6803 13080 Add support for cxgbe temp/volt sensor commit b7a7784945b3504d0b69ea02a08e1cddb5578907 13111 Want futimes(), lutimes() and timespec/timeval conversion macros
2020-09-1713111 Want futimes(), lutimes() and timespec/timeval conversion macrosAndy Fiddaman2-3/+31
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Marco van Wieringen <mvw@planets.elm.net> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-17 [illumos-gate merge]Jerry Jelinek1-1/+1
commit 260b78324e5b8479cc94f897a36e996f026c3fef 13108 mlxcx fails to attach on system using pcplusmp after 12988 commit 8c5b3a5a518f93629928bd6ed373422602ce74a9 13136 libc: memset_s() error: unchecked function return
2020-09-1713136 libc: memset_s() error: unchecked function returnToomas Soome1-1/+1
Reviewed by: Marco van Wieringen <mvw@planets.elm.net> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Joshua M. Clulow <josh@sysmgr.org>
2020-09-10 [illumos-gate merge]Jerry Jelinek1-1/+4
commit 9dc804b9db4598936de071708cbc40525f06eb5d 13077 bhyve kernel should be -Wformat clean commit 5d2ed7273d684a5ddeb0970c96ef9cf3ddd4e044 13115 libc: variable 'readers' set but not used
2020-09-0913115 libc: variable 'readers' set but not usedToomas Soome1-1/+4
Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Reviewed by: Richard Lowe <richlowe@richlowe.net> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-08 [illumos-gate merge]Jerry Jelinek1-4/+2
commit 93d26c05275be2c44aedd16705237484fc0a0990 13015 fruaccess: comparison between pointer and zero character constant commit ba12489a763ade223e478c59fdc4cb752fcba568 13011 tsalarm: '*' in boolean context, suggest '&&' instead commit 09e6639baaf32231365cb9895bf1e0ea006a2a60 12885 efcode: smatch and build errors commit e4af2f17fac5babc25d094f1bf22dd06515f66c7 13104 zfs: offset_t is signed and can not be > MAXOFFSET_T commit 7aaede4825001926ae223b8c47ef9e4d0d6021ba 12974 libc: left shift of negative value commit 712669c9fa9278704a4ccefe1d96acaf29397d36 13103 zfs: zvol_strategy() warn: unsigned 'off' is never less than zero commit e075c017fe4c71cde62297bcc90d3411c0f4ad1d 12512 dispadmin.1m manpage is missing \fB \fR around FX commit 9b0881404678e5235132f9320785c3f5ce6e71f6 13087 zfs: zfs_ereport_post() and zfs_ereport_start() return values are ignored commit 5365b8a5984eca60a3cedc7f9f738e51fb056bec 12936 bhyve vlapic needs ability to bypass isrvec_stk
2020-09-0812974 libc: left shift of negative valueToomas Soome1-4/+2
Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Approved by: Dan McDonald <danmcd@joyent.com>
2020-09-047709 hrt2ts and friends are too clever for their own goodPatrick Mooney1-4/+8
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Jason King <jason.king@joyent.com> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2020-08-24 [illumos-gate merge]Jerry Jelinek1-6/+6
commit 0a9a25a293d437b1563e1d8479fef8f3795ba817 13021 Invalid state if bindtextdomain() fails during re-binding commit 5fae793b9b02afd1f3f434f3a915a64c08edc7b2 13062 loader: make env_discard() public commit b89fb824168e36795c325b5e0a4d1e71dd2d8d65 13068 gptzfsboot: command from /boot/config should be nul terminated commit 8548ec78d85644539a23c4262ed2b9512a47865e 13065 log when suspending a zpool commit 84971882a96ac0fecd538b02208054a872ff8af3 12996 bhyve kernel should be wscheck clean commit e0c0d44e917080841514d0dd031a696c74e8c435 12989 improve interface boundary for bhyve MMIO 12990 improve interface boundary for bhyve ins/outs 12991 bhyve vlapic should SIPI more carefully commit 76f19f5fdc974fe5be5c82a556e43a4df93f1de1 12983 Want additional prototypes for manual pages commit 341c5f490806c8b3e6e31512923db4c0e1b464b1 13041 i40e_get_available_resources() broken again for X722 part commit dcbbe9e03d9d35c714d909a1f4767ce83c885e80 13049 cstyle should tolerate freebsd headers
2020-08-2313021 Invalid state if bindtextdomain() fails during re-bindingRichard Hansen1-6/+6
Reviewed by: Joshua M. Clulow <josh@sysmgr.org> Approved by: Dan McDonald <danmcd@joyent.com>
2020-07-09 [illumos-gate merge]Jerry Jelinek2-1/+11
commit 4a663bac9c5f9f82a5f633bc9639bbee3c2317ff 12904 Update nvme health logpage and temp thresholds commit 480497bc2ff96b447dc09403a6c187a1593ac1ec 12934 sockfs rights test should close unneeded descriptors commit fdb2a7e9480266dfaa0b5aaa0e1237456552f332 12881 sparcv9: add __multi3 commit 7fc77f3f3f63424c569601711f173702dbfd5c45 12927 loader: move zfs_boot_args to bootargs.h commit 1c0fc4547783fdfd7365d5d483e2750915523d44 6089 The comment for svc_callout_find() should be improved commit 66373fa702508a0a41753138f0b10f985c7e058d 12902 epoll should nominally support EPOLLEXCLUSIVE commit 33f84ecfada5880d94e9bfc5af7954d41e5664d5 12924 blkdev needs to be better at handling attach failures
2020-07-0812881 sparcv9: add __multi3Toomas Soome1-0/+4
Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>
2020-07-0812902 epoll should nominally support EPOLLEXCLUSIVEPatrick Mooney1-1/+7
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>
2020-07-0712912 epoll mishandles excessive timeout negativityPatrick Mooney1-3/+12
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Ryan Zezeski <ryan.zeseski@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>
2020-06-09 [illumos-gate merge]Jerry Jelinek15-36/+417
commit b3263c9871d056ea54cca24eaeedd5a41fd333de 12826 update to smatch 0.6.1-rc1-il-6 commit e1fb6a07e9492184a949d5a3ba446ff53b888a2b 12777 libc unwinding confused by indirect pointer encoding commit eda3ef2de2d15b389090f6ef953edaea3daaace4 12689 Want c11 uchar.h commit e214b19eaa16fec1fa60a97227778103f598336f 12577 px: NULL pointer errors