summaryrefslogtreecommitdiff
path: root/usr/src/test
AgeCommit message (Collapse)AuthorFilesLines
2016-06-22 [illumos-gate merge]release-20160625Jerry Jelinek1-1/+1
commit 01aaaf328842760a1002109b299908a027e94cf8 7051 want id_space(9F) docs commit c1de7575521deda5ee777b8054a9c5b12f15b1ee 7120 mDNS resync was not wsdiff safe commit 9c05409f2b9301e686735887a9573454cceb0331 7069 i386_XARCH should include -m32 commit 406fc5100dac8d225a315a6def6be8d628f34e24 6602 lofi should support labeled devices commit f3a07f941f1be263a48a040c059edbcb722cf436 4712 Prefer 'parsable' over 'parseable' in the manual pages commit 1b2031a95889aea96be6af55dcf31a0d5ffdfed9 7050 Prefer 'subcommand' over 'sub-command' in the manual pages commit 831b40b1c811223fd0b1131791a38e3ae5143377 7049 Prefer 'writable' over 'writeable' in the manual pages commit a716f1a92056bc2e231e57ae2a20725ce606ea73 7047 Fix spelling mistakes in sections 9E, 9F and 9S commit 95e15299a2c42b8014fa27631a6f3be2a93febc2 7048 Fix spelling mistakes in sections 7D, 7I, 7IPP, and 7P commit df23565fe1d0b225f9f898c50dfafea6749b0b7f 7046 Fix spelling mistakes in section 5 commit c855112f85cf71e42f6381a66f3f86f98e2ed24e 7045 Fix spelling mistakes in section 4 commit 843c398e8904ed9d833d2af3103894f909fb4b52 7042 Fix spelling mistakes in library sections commit 0db8de19c0e494758b68b702523a2b0eaffe3b2e 7044 Fix spelling mistakes in sections 1HAS and 2 commit df23d905b96680e56379c5a5ecb4b363f36b9e74 7041 Fix spelling mistakes in sections 1 and 1M commit 71af3be340c57171837478555e2eb0d496318cfc 7040 Detect common spelling errors in manual pages Conflicts: usr/src/uts/common/fs/vfs.c usr/src/man/man7d/cpuid.7d usr/src/man/man5/privileges.5 usr/src/man/man3c/signalfd.3c usr/src/cmd/lofiadm/main.c
2016-06-217069 i386_XARCH should include -m32Richard Lowe1-1/+1
Reviewed by: Jason King <jason.brian.king@gmail.com> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-06-10 [illumos-gate merge]Jerry Jelinek1-20/+12
commit a76660dbabd3d3b161bdead081ce275af6966d2e 7083 create_ramdisk.sh need not check for inuse devices commit 3f85b2aed8a5768f4c20db925cdf8fc072472037 7036 zvol_swap_004_pos test failed commit 10e67aa0db0823d5464aafdd681f3c966155c68e 7082 bptree_iterate() passes wrong args to zfs_dbgmsg() commit 2404c9e6b54f427b32dd0a2d46940d6a4c5299bc 7062 Connections remain in TIME_WAIT too long 7061 local TCP connections should be expediently purged from TIME_WAIT commit 9adfa60d484ce2435f5af77cc99dcd4e692b6660 6314 buffer overflow in dsl_dataset_name commit 0c779ad424a92a84d1e07d47cab7f8009189202b 7054 dmu_tx_hold_t should use refcount_t to track space
2016-06-097036 zvol_swap_004_pos test failedIgor Kozhukhov1-20/+12
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com>
2016-06-06 [illumos-gate merge]Jerry Jelinek1-5/+5
commit 565657ca18725b8f8dbe5b93704cc1d173be9d65 7017 integrate pvscsi commit 99189164df06057fb968ca7be701bb1a0d5da8c9 6940 Cannot unlink directories when over quota commit 002ec3e4c3efa65890ba89d290fe2cc209838c12 6999 fix 'Use of uninitialized value $picky in numeric eq (==)' in cstyle commit 0dd053d7d890618ea1fc697b07de364e69eb4190 7016 arc_available_memory is not 32-bit safe commit 86f617e90f3e06f970c3ea9b32836e29500836ab 7028 avl_destroy_nodes supports emptying, not just destroying, an avl tree commit 48cb8b9720f175ff5ed31ebd96a9f3d6922bdde9 7027 zfs_written_property_001_pos makes unreasonable assumptions about metadata space usage
2016-06-037027 zfs_written_property_001_pos makes unreasonable assumptions about ↵Akash Ayare1-5/+5
metadata space usage Reviewed by: Prakash Surya <prakash.surya@delphix.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Gordon Ross <gordon.ross@nexenta.com>
2016-06-02 [illumos-gate merge]Patrick Mooney7-14/+20
commit 0687de4f0b1d84cc87ddf92c49ceaec0f551670e 7018 illumos-gate build fails with libxml2 2.9.4 commit 1919e1f72d0a8141a10acd516bd1daa5064c8d07 7015 libc tests need to use LINK64 correctly, rather than just passing -m64 commit 258c9c7d86e8c69f1255ce2b5aeda40ac16d36ca 7001 zvol_misc tests should not depend on /sbin or /usr/sbin being in PATH commit 88f61dee20b358671b1b643e9d1dbf220a1d69be 6931 lib/libzfs: cleanup gcc warnings
2016-06-017015 libc tests need to use LINK64 correctly, rather than just passing -m64Richard Lowe1-1/+1
Reviewed by: Dan McDonald <damncd@omniti.com> Reviewed by: Andy Stormont <astormont@racktopsystems.com> Reviewed by: Jason King <jason.brian.king@gmail.com> Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
2016-06-017001 zvol_misc tests should not depend on /sbin or /usr/sbin being in PATHHans Rosenfeld6-13/+19
Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Dan McDonald <danmcd@omniti.com>
2016-05-20fix mismergeJerry Jelinek1-1/+0
2016-05-20 [illumos-gate merge]Jerry Jelinek27-43/+1961
commit 7dc9a163b382daee1ce43b6588dd1b507363dae5 6790 want suite of endian(3C) functions commit e56998eefc33ead0f12b364be915dd6bfc12a3f5 6501 Implement pthread_attr_get_np() interface commit fc2512cfb727d49529d8ed99164db871f4829b73 6951 Initial c11 support 6952 gets should not be visible in C11 6953 add support for c11 threads api 6954 Symbols test should support validating pre-processor symbols commit ea4a67f462de0a39a9adea8197bcdef849de5371 6980 6902 causes zfs send to break due to 32-bit/64-bit struct mismatch Conflicts: usr/src/test/libc-tests/tests/Makefile usr/src/test/libc-tests/runfiles/default.run usr/src/lib/libcmdutils/libcmdutils.h usr/src/lib/libcmdutils/common/custr.c usr/src/lib/libcmdutils/common/mapfile-vers
2016-05-196790 want suite of endian(3C) functionsRobert Mustacchi3-0/+161
Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Richard Lowe <richlowe@richlowe.net> Approved by: Garrett D'Amore <garrett@damore.org>
2016-05-196501 Implement pthread_attr_get_np() interfaceRobert Mustacchi4-0/+403
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net> Approved by: Garrett D'Amore <garrett@damore.org>
2016-05-196951 Initial c11 supportRobert Mustacchi24-43/+1441
6952 gets should not be visible in C11 6953 add support for c11 threads api 6954 Symbols test should support validating pre-processor symbols Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net> Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Garrett D'Amore <garrett@damore.org>
2016-05-17 [illumos-gate merge]Jerry Jelinek9-16/+34
commit 24e268f3071ecc622f716e7801683c84f4d4f9db 6404 zvol_swap_006_pos can occasionally fail due to swaplen being < 16 6405 zvol test setup is non deterministic commit 1825bc56e5a1f7ef6f0dc3137f3b35f5850c1100 6878 Add scrub completion info to "zpool history" commit 5b1627536384deb03449347af9c01bd4fc2d271e 6973 audioens driver does not work on VMWare
2016-05-166404 zvol_swap_006_pos can occasionally fail due to swaplen being < 16Matthew Ahrens9-16/+34
6405 zvol test setup is non deterministic Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: Will Andrews <will@freebsd.org> Approved by: Dan McDonald <danmcd@omniti.com>
2016-05-13 [illumos-gate merge]Jerry Jelinek1-1/+12
commit c971037baa5d64dfecf6d87ed602fc3116ebec41 6876 Stack corruption after importing a pool with a too-long name commit 11ceac77ea8034bf2fe9bdd6d314f5d1e5ceeba3 6844 dnode_next_offset can detect fictional holes commit 43051d2742bbe5911de73322064cb573b6aff975 6955 libproc should be documented and shipped 6956 libproc cannot leave free() to callers
2016-05-126876 Stack corruption after importing a pool with a too-long namePaul Dagnelie1-1/+12
Reviewed by: Prakash Surya <prakash.surya@delphix.com> Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2016-04-21 [illumos-gate merge]Jerry Jelinek11-711/+553
commit 20fea7a47472aceb64d3ed48cc2a3ea268bc4795 6879 incorrect endianness swap for drr_spill.drr_length in libzfs_sendrecv.c commit c5d1600c3eb0a58e493be9019c5fb8eaec72cb81 6880 zdb incorrectly reports feature count mismatch when feature is disabled commit 88a916040716032880a2a28e8f26912aef5426da 6877 zfs_rename_006_pos fails due to missing zvol snapshot device file commit 8fc922875ed266f52ccd5cc6f973b9ad0839c710 6871 libzpool implementation of thread_create should enforce length is 0 commit f83b46baf98d276f5f84fa84c8b461f412ac1f5e 6872 zfs libraries should not allow uninitialized variables commit 80309ff2cfc900b5f6acfe1d7f72cf67baf81fbe 6870 Update zoneinfo to 2016c (zone_sun.tab mismerge) commit 232f5a2e6e6fcc0e7d4f5bd719cd5e6433a24020 6875 fix zfs-tests ACL cases commit da412744bc6f902e4519ae67e92191a2e5d85e2c 6765 zfs_zaccess_delete() comments do not accurately reflect delete permissions for ACLs commit de0f1ddb598506a5d9a02946b67e9300b5f2a7cd 6764 zfs issues with inheritance flags during chmod(2) with aclmode=passthrough commit 851632d6a88d512574719953cc01ae7c2ed66b88 6763 aclinherit=restricted masks inherited permissions by group perms (groupmask) commit 1eb4e906ec75b9bde421954ace46ef137b0fc9eb 6762 POSIX write should imply DELETE_CHILD on directories - and some additional considerations
2016-04-206880 zdb incorrectly reports feature count mismatch when feature is disabledMatthew Ahrens5-5/+57
Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Prakash Surya <prakash.surya@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-04-206877 zfs_rename_006_pos fails due to missing zvol snapshot device fileAkash Ayare1-1/+10
Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-04-206875 fix zfs-tests ACL casesYuri Pankov5-705/+486
Reviewed by: Gordon Ross <gwr@nexenta.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2016-04-15 [illumos-gate merge]Jerry Jelinek15-0/+629
commit 215198a6ad15cf4832370e2f19247abeb36b951a 6736 ZFS per-vdev ZAPs
2016-04-146736 ZFS per-vdev ZAPsJoe Stein15-0/+629
Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Don Brady <don.brady@intel.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2016-04-11 [illumos-gate merge]Jerry Jelinek14-121/+33
commit 9498083eeaed1aacdde41369b7fa6f3b84870791 6580 zfs-tests use undefined variable WRAPPER commit 01ff4119377acad6b30d6f06f2bfd0f982720b10 6754 zfs-tests: get_substr() function is redundant commit 6401734d545a04c18f68b448202f9d9a77216bb9 6418 zpool should have a label clearing command commit fce7ca969a9af519a625582f23fe1cd13e61c1ec 6819 libsysevent documentation incorrect commit 78c0f49e8991772ff264f861afa37ac436bf9b28 6868 Update hwdata - 20160407 Conflicts: usr/src/man/man3sysevent/sysevent_get_vendor_name.3sysevent
2016-04-096580 zfs-tests use undefined variable WRAPPERYuri Pankov10-75/+7
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Matthew Ahrens <mahrens@delphix.com>
2016-04-096754 zfs-tests: get_substr() function is redundantYuri Pankov4-46/+26
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Matthew Ahrens <mahrens@delphix.com>
2016-03-26OS-4089 segfault in putenv + getenvRobert Mustacchi3-2/+123
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com> Reviewed by: Dave Eddy <dave.eddy@joyent.com> Reviewed by: Cody Mello <melloc@joyent.com>
2016-03-236684 Allow sending from IPv6 SLAAC addresses within a zone using IP spoofing ↵Cody Peter Mello3-1/+741
protection Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Dan McDonald <danmcd@omniti.com>
2016-03-10 [illumos-gate merge]Jerry Jelinek8-4/+198
commit 286ef71398fb54b1d5007d6f45aa4320a9e0ede2 6370 ZFS send fails to transmit some holes commit 4549a1bd3fb75b70dd34ba46715014effe21dc07 6727 lofiadm: remove "o:" from getopt argument commit e2e882f7e139a951a52c7f4b5af447c3e6e68398 6691 V490 and V890 symlinks missing on SPARC build commit 2f15e7adf5d6f13b15dfa8f3900a07804cadd86c 6581 cmd/format should be able label virtio BLKDEV drives commit debed2c9e88134586f1a03761f87d8a1d599b854 6733 mh_contents rwlock is not initialised Conflicts: usr/src/cmd/lofiadm/main.c
2016-03-096370 ZFS send fails to transmit some holesPaul Dagnelie8-4/+198
Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Chris Williamson <chris.williamson@delphix.com> Reviewed by: Stefan Ring <stefanrin@gmail.com> Reviewed by: Steven Burgess <sburgess@datto.com> Reviewed by: Arne Jansen <sensille@gmx.net> Approved by: Robert Mustacchi <rm@joyent.com>
2016-03-05OS-5214 SLAAC IP detection should not check Cur Hop Limit fieldCody Peter Mello1-1/+1
2016-02-25 [illumos-gate merge]Jerry Jelinek16-354/+89
commit 633aa8079184298dfc2ae6966d0d9cc897712b57 6575 grow_replicas_001_pos fails intermittently commit 327848f9b50960449ae0e73e0767b617af721690 6578 cifs_attr_002_pos fails to cleanup after itself commit 964a6bd0f9365bb057bceb3cf813be3dbb8de2bf 6577 zfs_copies_004_neg fails trying to expand wildcard characters commit ee0ab62f26fb5723153c0c1b3cb1c5590bd7fb3c 6468 remove iscsi-related cruft from zfs-tests commit 412db4e993a383395d7ff1add4bb97f97ca3d433 6642 testrunner output can be displayed in the wrong order 6643 zfstest should enforce the required privileges before running. commit a6c5c5ca2069d841106ecb240d54632487830200 6663 Driver timerfd not built on SPARC commit 4185ca1d7f22b7d0d04eac3b580dd338274cb432 6671 man(1): document MANWIDTH variable commit 5db531e3faa94427746eae754b11770fd8416b6d 6662 uts should only build the variant requested commit 96088c8326643135b996338d1fe5a68aac181f31 6592 AI_ADDRCONFIG fails all resolutions when only loopback is present Conflicts: usr/src/uts/sparc/Makefile.sparc
2016-02-246575 grow_replicas_001_pos fails intermittentlyYuri Pankov8-177/+71
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-246578 cifs_attr_002_pos fails to cleanup after itselfYuri Pankov1-2/+2
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-246577 zfs_copies_004_neg fails trying to expand wildcard charactersYuri Pankov1-1/+1
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-246468 remove iscsi-related cruft from zfs-testsYuri Pankov4-161/+3
Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-246642 testrunner output can be displayed in the wrong orderJohn Wren Kennedy2-13/+12
6643 zfstest should enforce the required privileges before running. Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Jonathan Mackenzie <jonathan.mackenzie@delphix.com> Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-23 [illumos-gate merge]Jerry Jelinek1-4/+8
commit e014e7f89c5273294b22953615734b04c11b1b4f 6641 deadman fires spuriously when running on VMware commit 8808ac5dae118369991f158b6ab736cb2691ecde 4521 zfstest is trying to execute evil "zfs unmount -a"
2016-02-224521 zfstest is trying to execute evil "zfs unmount -a"Yuri Pankov1-4/+8
Reviewed by: Andriy Gapon <avg@FreeBSD.org> Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com>
2016-02-16 [illumos-gate merge]Jerry Jelinek1-2/+2
commit 7f11fd00fc23e2af7ae21cc8837a2b86380dcfa7 6648 illumos build should be explicit about C standards commit eae164eb03cbb004dcf9154f36352e62f693eb6c 6645 sgsmsg relies on undefined behaviour of loop-scoped variables commit a7317ceb814150d472383df8b987d7e3282ea15b 6639 uhci_qh walker contains whacky boolean logic commit 1665390b481087ca2aaff06a502c62b3ee91d530 6638 ::pfiles walks out of bounds on array of vnode types commit d456640d8a14f0ba35a7ec232f0ce9ebd34541cb 6647 MANSECTS should not require a trailing comma commit 0803e914d3511e82e0b1cc0c888af873a4aaa7d1 6603 zfeature_register() should verify ZFEATURE_FLAG_PER_DATASET implies SPA_FEATURE_EXTENSIBLE_DATASET commit 22b6687e7850d421c61bf433a388b7db306aca00 6586 Whitespace inconsistencies in the spa feature dependency arrays in zfeature_common.c commit 892586e8a147c02d7f4053cc405229a13e796928 6585 sha512, skein, and edonr have an unenforced dependency on extensible dataset commit 971640e6aa954c91b0706543741aa4570299f4d7 6541 Pool feature-flag check defeated if "verify" is included in the dedup property value commit bd94aa560898627952fba8f09dda95c4492e7d9e 6644 MBOOT_SCAN_SIZE in usr/src/cmd/boot/common/mboot_extra.h is wrong
2016-02-146648 illumos build should be explicit about C standardsRichard Lowe1-2/+2
Reviewed by: Andy Stormont <andyjstormont@gmail.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Dan McDonald <danmcd@omniti.com>
2016-02-10 [illumos-gate merge]Jerry Jelinek5-4/+92
commit d189620258b3c9b0e2f7e2104840be2eee7c68e5 6637 replacing "dontclose" with "should_close" commit 5f7a8e6d750cb070a3347f045201c6206caee6aa 6562 Refquota on receive doesn't account for overage
2016-02-096562 Refquota on receive doesn't account for overageDan McDonald5-4/+92
Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gwr@nexenta.com>
2016-02-09 [illumos-gate merge]Jerry Jelinek26-2/+1185
commit d7e7cb9c207e40874f6a4b61ca8ea1526b5555bd 6528 need casesensitivity/normalization test cases for zfs-tests commit c3d26abc9ee97b4f60233556aadeb57e0bd30bb9 5027 zfs large block support (add copyright)
2016-02-086528 need casesensitivity/normalization test cases for zfs-testsYuri Pankov26-2/+1185
Reviewed by: Gordon Ross <gordon.ross@nexenta.com> Reviewed by: Kevin Crowe <kevin.crowe@nexenta.com> Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com>
2016-02-04 [illumos-gate merge]Jerry Jelinek1-85/+22
commit 2e67aa296fc3707ae8e2b532f67387daf0823499 6589 prototypes should bid farewell to 2015 commit 1a7f23d927dad680fa43ca65ed7f86adf49032e2 6595 sdev's devfsadm macros set a bad precedent commit 751609474e831927e5706b37cb08160df31dcd4d 6568 zfs_allow_010_pos and zfs_allow_012_neg fail intermittently
2016-02-036568 zfs_allow_010_pos and zfs_allow_012_neg fail intermittentlyYuri Pankov1-85/+22
Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Approved by: Richard Lowe <richlowe@richlowe.net>
2016-01-25 [illumos-gate merge]Jerry Jelinek12-255/+223
commit c2b09db8b5b01162dadf9205ddd83ccf4f7d5535 6465 zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_007_pos is broken commit 38d61036746e2273cc18f6698392e1e29f87d1bf 6450 scrub/resilver unnecessarily traverses snapshots created after the scrub started commit 7ddce99911fbb5e44b38ac65e991a22e42267ee9 6123 SMF ipfilter support needs improvement
2016-01-236465 zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_007_pos ↵Yuri Pankov12-255/+223
is broken Reviewed by: John Kennedy <john.kennedy@delphix.com> Approved by: Richard Lowe <richlowe@richlowe.net>