From 623c3de4b7886d5d3a70c856a27c13fe534b2b69 Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Mon, 20 Jan 2020 19:01:15 +0200 Subject: 12221 arp: smatch errors Reviewed by: John Levon Reviewed by: Matthias Scheler Approved by: Dan McDonald --- usr/src/uts/common/inet/inetddi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'usr/src/uts/common/inet/inetddi.c') diff --git a/usr/src/uts/common/inet/inetddi.c b/usr/src/uts/common/inet/inetddi.c index a64bf7e978..7f4f7d305d 100644 --- a/usr/src/uts/common/inet/inetddi.c +++ b/usr/src/uts/common/inet/inetddi.c @@ -127,7 +127,7 @@ static struct dev_priv { static int inet_attach(dev_info_t *devi, ddi_attach_cmd_t cmd) { - int i, ndevs; + size_t i, ndevs; if (cmd != DDI_ATTACH) return (DDI_FAILURE); @@ -141,6 +141,12 @@ inet_attach(dev_info_t *devi, ddi_attach_cmd_t cmd) break; } + /* smatch has no idea what VERIFY does. */ + if (i == ndevs) { + VERIFY(i < ndevs); + return (DDI_FAILURE); + } + return (ddi_create_priv_minor_node(devi, INET_NAME, S_IFCHR, INET_DEVMINOR, DDI_PSEUDO, netdev_privs[i].privonly, netdev_privs[i].read_priv, netdev_privs[i].write_priv, -- cgit v1.2.3