From ef9416a894c90df5d46b888dbe2908c7f00fd409 Mon Sep 17 00:00:00 2001 From: Toomas Soome Date: Sat, 18 Jan 2020 11:44:12 -0800 Subject: 12296 unix: access_mask_check() warn: bitwise AND condition is false here Reviewed by: Matthias Scheler Reviewed by: Andrew Stormont Approved by: Gordon Ross --- usr/src/common/acl/acl_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'usr/src') diff --git a/usr/src/common/acl/acl_common.c b/usr/src/common/acl/acl_common.c index 765d6cef12..3b4f9bdec8 100644 --- a/usr/src/common/acl/acl_common.c +++ b/usr/src/common/acl/acl_common.c @@ -875,8 +875,8 @@ access_mask_check(ace_t *acep, int mask_bit, int isowner) set_allow = ACL_WRITE_ATTRS_WRITER_SET_ALLOW; err_allow = ACL_WRITE_ATTRS_WRITER_ERR_ALLOW; } else { - if ((acep->a_access_mask & mask_bit) && - (acep->a_type & ACE_ACCESS_ALLOWED_ACE_TYPE)) { + if (((acep->a_access_mask & mask_bit) != 0) && + (acep->a_type == ACE_ACCESS_ALLOWED_ACE_TYPE)) { return (ENOTSUP); } return (0); -- cgit v1.2.3