[no description] https://git.osdyson.ru/mirror/pkgsrc/atom?h=pkgsrc-pkgsrc-2019Q4 2019-12-17T15:38:43Z 2019-12-17T15:38:43Z rillig rillig@pkgsrc.org 2019-12-17T15:38:43Z urn:sha1:b70cc491afb6921b596eb9227e7ea45b0f747b88 Changes since 0.4: The log output in verbose mode surrounds each test now and says immediately whether that test fails. Before, that information was collected and only shown at the very end of the output, which was inconvenient. 2019-12-16T17:06:05Z rillig rillig@pkgsrc.org 2019-12-16T17:06:05Z urn:sha1:c10fa5f674445d945bbc0b5774de08aaab8bc632 Changes since 19.3.18: Small improvements to edge cases in SUBST blocks. Small improvements to edge cases in variable assignment and alignment of the continuation backslashes. The --source option shows the changes from autofix, even when the --show-autofix option is not given. This is a welcome side-effect of making the autofix logging simpler and more predictable. 2019-12-15T01:29:06Z rillig rillig@pkgsrc.org 2019-12-15T01:29:06Z urn:sha1:ea33fd72a81d3751968a590101e00ee9a58712d0 This is an early prototype that is not used in the pkglint code. It will be included when it is ready and tested. 2019-12-14T18:04:15Z rillig rillig@pkgsrc.org 2019-12-14T18:04:15Z urn:sha1:0ac4d0909f2608e8616576d07d024d079deaabd3 Changes since 19.3.17: The SUBST check has been completely rewritten. It can handle several SUBST classes at the same time now. This reduces the number of wrong warnings. 2019-12-13T07:43:47Z bsiegert bsiegert@pkgsrc.org 2019-12-13T07:43:47Z urn:sha1:f1a480ed5c803dfe022918f4d5ac7c91ce660e29 2019-12-13T01:39:23Z rillig rillig@pkgsrc.org 2019-12-13T01:39:23Z urn:sha1:8883ba866ca1591d9402085623f95caefb53808f Changes since 19.3.16: Pkglint now handles SUBST blocks correctly, even those in which some of the variables are defined conditionally. It correctly reports those that are missing in at least one of the possible branches. PKG_JVM is no longer marked as deprecated. It was once package-settable. Since 2002 it is system-provided, and the package-settable counterpart is PKG_JVM_DEFAULT. This does not fit into pkglint's simple model of deprecating variables since the variable name is still valid, it should just not be defined by packages anymore. The alignment of variable assignments has been fixed in some edge cases. In continuation lines where the backslash is beyond column 72, the whitespace before the continuation backslash is fixed to a single space. 2019-12-12T15:52:53Z jperkin jperkin@pkgsrc.org 2019-12-12T15:52:53Z urn:sha1:133228ed406e5418fb34875ed96c45dca57ab37a ## Version 0.14.0 (2019-12-12) * Ensure reverse dependencies are considered when a "pkgin install" triggers an upgrade of a local package, avoiding potentially nasty bugs. * Minor performance improvement. 2019-12-09T20:38:15Z rillig rillig@pkgsrc.org 2019-12-09T20:38:15Z urn:sha1:6060593e73fde486edfbd3a57f28e6db500decec Changes since 19.3.15: When a package-settable variable gets a default value using the ?= operator, pkglint no longer suggests to include bsd.prefs.mk, since that doesn't make sense. Including bsd.prefs.mk only defines user-settable and system-provided variables. User and group names may be a single character only. While not widely used, it's syntactically valid and there's no reason to prevent this. In variable assignments, when pkglint removes unnecessary whitespace between the variable name and the operator, it keeps the indentation of the variable value the same as before. Previously, the indentation had been changed, which required another run of pkglint --autofix. PREFIX can only be used as a replacement for LOCALBASE after the whole package Makefile has been loaded. This is because PREFIX is defined very late, by bsd.pkg.mk. Therefore, don't suggest to replace LOCALBASE with PREFIX in .if conditions. When pkglint suggests to replace INSTALL_DATA_DIR commands with setting INSTALLATION_DIRS instead, paths with a trailing slash are correctly looked up in the PLIST. This suggests to use AUTO_MKDIRS more often. 2019-12-08T22:03:37Z rillig rillig@pkgsrc.org 2019-12-08T22:03:37Z urn:sha1:294e469401c8ee36a6351e51976a22f5fd757103 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should". 2019-12-08T00:06:37Z rillig rillig@pkgsrc.org 2019-12-08T00:06:37Z urn:sha1:8cc68535e21bb3fc457943dfba45550985186681 Changes since 19.3.13: When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME} == fixed, the exact suggested expression is now part of the diagnostic. The check and the autofix have been improved. They now apply only to the last modifier in the whole chain, everything else was a bug in pkglint. Pkglint now knows the scope of variables better than before. It knows the difference between variables from <sys.mk> like MACHINE_ARCH, which are always in scope, and those from mk/defaults/mk.conf, which only come into scope later, after bsd.prefs.mk has been included. It warns when variables are used too early, for example in .if conditions. The pathnames in ALTERNATIVES files are now checked for absolute pathnames. This mistake doesn't happen in practice, but the code for converting the different path types internally made it necessary to add these checks. At least this prevents typos. The special check for obsolete licenses has been removed since their license files have been removed and that is checked as well. Variables named *_AWK may be appended to. The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they are obsolete now. They are not used in main pkgsrc and pkgsrc-wip anymore. When a package sets a default value for a user-settable variable (which is something that should not happen anyway), it should .include bsd.prefs.mk before, in order to not accidentally overwrite the user-specified value. Variable modifiers of the form :from=to are now parsed like in bmake. They are greedy and eat up any following colons as well. This means that ${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it. Pkglint now warns about such cases. The handling of relative paths in diagnostics is now consistent. All paths that are part of a diagnostic are relative to the line that issues the diagnostic. Fatal errors are no longer suppressed in --autofix mode. Plus lots of refactoring, to prevent accidental mixing of incompatible relative paths.