diff options
| author | rillig <rillig> | 2006-05-11 11:03:16 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2006-05-11 11:03:16 +0000 |
| commit | eaa098037fe6948e4141499c260e73bfbcac1c3c (patch) | |
| tree | 3a8520974c6651458c38b6e0e046f06c98b54d38 | |
| parent | 4b7df64b1c0ec2f4fd6d025d5260fbbcd42469e1 (diff) | |
| download | pkgsrc-eaa098037fe6948e4141499c260e73bfbcac1c3c.tar.gz | |
Removed the "Comment expected" warning from patch files, as suggested by
many people on pkgsrcCon 2006.
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 833fd61b47c..01c4d0f0b7a 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.578 2006/05/11 09:16:53 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.579 2006/05/11 11:03:16 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -4860,12 +4860,12 @@ sub checkfile_patch($) { # }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() { if (!$seen_comment) { - $opt_warn_style and $line->log_warning("Comment expected."); + #$opt_warn_style and $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() { if (!$seen_comment) { - $opt_warn_style and $line->log_warning("Comment expected."); + #$opt_warn_style and $line->log_warning("Comment expected."); } }], [PST_TEXT, re_patch_text, PST_TEXT, sub() { $seen_comment = true; @@ -4877,14 +4877,14 @@ sub checkfile_patch($) { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $opt_warn_style and $line->log_warning("Comment expected."); + #$opt_warn_style and $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $opt_warn_style and $line->log_warning("Comment expected."); + #$opt_warn_style and $line->log_warning("Comment expected."); } }], [PST_CENTER, undef, PST_TEXT, sub() { $opt_warn_space and $line->log_note("Empty line expected."); |