diff options
| author | rillig <rillig@pkgsrc.org> | 2008-01-01 13:44:11 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2008-01-01 13:44:11 +0000 |
| commit | 811346657e213d68be21984b63ee0e65e80981de (patch) | |
| tree | 9ddbb16765ce038e9164f91098f02c4879a6ce07 | |
| parent | 93e17e300c57c502ad01529c2a0aae0452a08f04 (diff) | |
| download | pkgsrc-811346657e213d68be21984b63ee0e65e80981de.tar.gz | |
All characters in PLIST files are relevant, so make trailing white-space
an error. Who would ever want to install files whose name ends in
white-space?
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index d634f4d3cfb..13db7d2b1a9 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.742 2007/12/22 22:27:17 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.743 2008/01/01 13:44:11 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -7403,7 +7403,11 @@ sub checkfile_PLIST($) { foreach my $line (@{$lines}) { my $text = $line->text; - checkline_trailing_whitespace($line); + if ($text =~ /\s$/) { + $line->log_error("pkgsrc does not support filenames ending in white-space."); + $line->explain_error( +"Each character in the PLIST is relevant, even trailing white-space."); + } # @foo directives. if ($text =~ /^(?:\$\{[\w_]+\})?\@([a-z-]+)\s+(.*)/) { |