diff options
| author | rillig <rillig@pkgsrc.org> | 2006-01-29 01:29:38 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-01-29 01:29:38 +0000 |
| commit | 16bdee598ae723ecc46393d67ca05ac36153b2d4 (patch) | |
| tree | 47fa7fe7dc4f7908de2c80f3f6ff43247abe43e7 | |
| parent | fab1e7860ee6531d5a4af9d0872fdba7a2b2dcae (diff) | |
| download | pkgsrc-16bdee598ae723ecc46393d67ca05ac36153b2d4.tar.gz | |
- Variables whose name end in DIR, DIRS, FILE, FILES, as well as PATH,
PREFIX, LOCALBASE and PKGNAME may appear in single quotes.
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index e1ffbfd2084..7edf243374e 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.495 2006/01/28 12:24:20 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.496 2006/01/29 01:29:38 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2243,6 +2243,9 @@ sub checkline_mk_shellword($$$) { } elsif ($state == SWST_PLAIN && defined($mod) && $mod =~ qr":Q$") { # Fine. + } elsif ($state == SWST_SQUOT && $varname =~ qr"(?:DIRS?|FILES?|PATH|^PREFIX|^LOCALBASE|^PKGNAME)$") { + # Fine, too. + } else { $line->log_warning("Possibly misquoted make variable ${varname} in " . user_statename->[$state] . "."); if ($state == SWST_PLAIN && !defined($mod)) { |