diff options
author | rillig <rillig@pkgsrc.org> | 2005-05-18 08:28:06 +0000 |
---|---|---|
committer | rillig <rillig@pkgsrc.org> | 2005-05-18 08:28:06 +0000 |
commit | 859bc7f97443a180af99480ab88f3f23b973de43 (patch) | |
tree | 1396b3e90ac046299a250e9d81e33587cb30b17e | |
parent | a5d1a65835aec1a78565f6abc256909f38742093 (diff) | |
download | pkgsrc-859bc7f97443a180af99480ab88f3f23b973de43.tar.gz |
Removed the check for absolute filenames, as it has produced too many
false positive warnings. Added a reminder to TODO that a similar check
be added to pkglint. Welcome to 4.15.
-rw-r--r-- | pkgtools/pkglint/Makefile | 4 | ||||
-rw-r--r-- | pkgtools/pkglint/TODO | 1 | ||||
-rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
3 files changed, 5 insertions, 10 deletions
diff --git a/pkgtools/pkglint/Makefile b/pkgtools/pkglint/Makefile index 9d4f772e0ed..34f697e1c9b 100644 --- a/pkgtools/pkglint/Makefile +++ b/pkgtools/pkglint/Makefile @@ -1,7 +1,7 @@ -# $NetBSD: Makefile,v 1.235 2005/05/15 02:38:56 rillig Exp $ +# $NetBSD: Makefile,v 1.236 2005/05/18 08:28:06 rillig Exp $ # -DISTNAME= pkglint-4.14 +DISTNAME= pkglint-4.15 CATEGORIES= pkgtools devel MASTER_SITES= # empty DISTFILES= # empty diff --git a/pkgtools/pkglint/TODO b/pkgtools/pkglint/TODO index e539900002b..9e8a67ab3f4 100644 --- a/pkgtools/pkglint/TODO +++ b/pkgtools/pkglint/TODO @@ -9,3 +9,4 @@ * check for C/C++ style comments in Makefiles rm -f *.o /* delete unused files */ .ifdef foo /* xyz */ +* add checking for absolute paths diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 9a596e5091e..8c1eebdd563 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -11,7 +11,7 @@ # Freely redistributable. Absolutely no warranty. # # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp -# $NetBSD: pkglint.pl,v 1.151 2005/05/18 03:48:43 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.152 2005/05/18 08:28:06 rillig Exp $ # # This version contains lots of changes necessary for NetBSD packages # done by Hubert Feyrer <hubertf@netbsd.org>, @@ -362,7 +362,6 @@ sub readmakefile($); sub checkextra($$); sub checkorder($$@); sub checkearlier($@); -sub abspathname($$); sub check_predefined_sites($); sub category_check(); sub check_package(); @@ -960,7 +959,7 @@ sub checkpathname($) { open(IN, "< $opt_packagedir/$file") || return false; { local $/; $whole = <IN>; } close(IN); - return abspathname($whole, $file); + return true; } sub checklastline($) { @@ -1428,11 +1427,6 @@ sub checkfile_Makefile($) { } # - # whole file: full path name - # - &abspathname($whole, $file); - - # # break the makefile into sections. # @sections = split(/\n\n+/, $rawwhole); |