mark packages that fail with -Werror=char-subscripts

These packages are susceptible to bugs when confronted with non-ASCII
characters.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94182.

It takes some time to analyze and fix these individually, therefore they
are only marked as "needs work".

52 files changed, 403 insertions, 52 deletions

diff --git a/audio/goom/Makefile b/audio/goom/Makefile
index 5c42d090ea7..f6e3a7aaf06 100644
--- a/audio/goom/Makefile
+++ b/audio/goom/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2020/01/26 17:30:42 rillig Exp $
+# $NetBSD: Makefile,v 1.13 2020/05/20 06:09:04 rillig Exp $
 
 DISTNAME=		goom-2k4-0-src
 PKGNAME=		goom-2004.0
@@ -18,5 +18,12 @@ GNU_CONFIGURE=		yes
 GCC_REQD+=		3.3
 USE_TOOLS+=		pkg-config
 
+# convolve_fx.c: In function 'create_output_with_brightness':
+# convolve_fx.c:222:20: error: array subscript has type 'char' [-Werror=char-subscripts]
+#        iff2 = ifftab[data->conv_motif[(ytex >>16) & CONV_MOTIF_WMASK][(xtex >> 16) & CONV_MOTIF_WMASK]];
+#                     ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/pthread.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/audio/mpegaudio/Makefile b/audio/mpegaudio/Makefile
index c3efa1f5612..b4e4599889b 100644
--- a/audio/mpegaudio/Makefile
+++ b/audio/mpegaudio/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.9 2015/12/29 04:54:35 dholland Exp $
+# $NetBSD: Makefile,v 1.10 2020/05/20 06:09:06 rillig Exp $
 
 DISTNAME=	mpegaudio
 PKGNAME=	mpegaudio-3.9
@@ -11,6 +11,16 @@ COMMENT=	MPEG/audio Layer 1 and Layer 2 encoder/decoder package
 
 INSTALLATION_DIRS+=	bin ${PKGMANDIR}/man1
 
+# common.c: In function 'aiff_read_headers':
+# common.c:729:28: error: array subscript has type 'char' [-Werror=char-subscripts]
+#              temp_sampleRate[i] = CommChunk.sampleRate[i];
+#                             ^
+# common.c:729:54: error: array subscript has type 'char' [-Werror=char-subscripts]
+#              temp_sampleRate[i] = CommChunk.sampleRate[i];
+#                                                       ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 post-install:
 	${INSTALL_MAN} ${FILESDIR}/mpeg_musicin.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
 	${INSTALL_MAN} ${FILESDIR}/mpeg_musicout.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
diff --git a/biology/lucy/Makefile b/biology/lucy/Makefile
index 8d6446f2f3b..44f353efc46 100644
--- a/biology/lucy/Makefile
+++ b/biology/lucy/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.11 2020/01/26 05:26:15 rillig Exp $
+# $NetBSD: Makefile,v 1.12 2020/05/20 06:09:06 rillig Exp $
 #
 
 DISTNAME=		${PKGNAME:S/-//}
@@ -16,6 +16,13 @@ WRKSRC=			${WRKDIR}/${PKGNAME_NOREV}p
 AUTO_MKDIRS=		yes
 PTHREAD_AUTO_VARS=	yes
 
+# abi.c: In function 'abi_align':
+# abi.c:195:16: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      if (badness[a[i]][b[j]]) {
+#                 ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/lucy ${DESTDIR}${PREFIX}/bin
 	${INSTALL_MAN} ${WRKSRC}/lucy.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
diff --git a/cad/fasthenry/Makefile b/cad/fasthenry/Makefile
index c279e6f9b91..7e30d04aecb 100644
--- a/cad/fasthenry/Makefile
+++ b/cad/fasthenry/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.31 2020/01/26 17:30:47 rillig Exp $
+# $NetBSD: Makefile,v 1.32 2020/05/20 06:09:03 rillig Exp $
 #
 
 DISTNAME=	fasthenry-3.0-12Nov96
@@ -36,6 +36,13 @@ MAKE_ENV+=	LIBS=${LIBS:M*:Q}
 GCC_REQD+=		2.95.3
 .endif
 
+# contact.c: In function 'walk_along_edge':
+# contact.c:1334:40: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    equiv_nodes_on_edge(cell->bndry.nodes[start_node], travel_dir,
+#                                         ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS=	bin
 
 .include "../../mk/bsd.pkg.mk"
diff --git a/cad/magic/Makefile b/cad/magic/Makefile
index 5442edb4679..6d68bbb9f49 100644
--- a/cad/magic/Makefile
+++ b/cad/magic/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.35 2019/06/08 11:04:29 rillig Exp $
+# $NetBSD: Makefile,v 1.36 2020/05/20 06:09:06 rillig Exp $
 #
 
 DISTNAME=	magic-7.5.188
@@ -34,6 +34,12 @@ CPPFLAGS+=	-DIS_BIG_ENDIAN
 CPPFLAGS+=	-DIS_LITTLE_ENDIAN
 .endif
 
+# DBundo.c: In function 'dbUndoPaintForw':
+# DBundo.c:268:42: error: array subscript has type 'char' [-Werror=char-subscripts]
+#         DBNMPaintPlane(dbUndoLastCell->cd_planes[up->pue_plane],
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 USE_TOOLS+=		awk:run
 REPLACE_INTERPRETER+=	awk
 REPLACE.awk.old=	/bin/awk
diff --git a/cad/spice/Makefile b/cad/spice/Makefile
index d187ed7570e..0d6dd5137fc 100644
--- a/cad/spice/Makefile
+++ b/cad/spice/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.48 2019/06/08 11:04:30 rillig Exp $
+# $NetBSD: Makefile,v 1.49 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	sp3f4.kit
 PKGNAME=	spice-3f5.1
@@ -42,6 +42,12 @@ SUBST_STAGE.conf=	pre-configure
 SUBST_FILES.conf=	conf/NetBSD conf/defaults
 SUBST_VARS.conf=	MAKE_PROGRAM CFLAGS LDFLAGS WRKSRC PREFIX X11BASE
 
+# src/lib/cp//modify.c: In function 'cp_init':
+# src/lib/cp//modify.c:26:17: error: array subscript has type 'char' [-Werror=char-subscripts]
+#          cp_chars[*s] = (CPC_BRR | CPC_BRL);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 do-configure:
 	rm -f ${WRKSRC}/makefile
 
diff --git a/cad/veriwell/Makefile b/cad/veriwell/Makefile
index 0534e0db988..276728b2f77 100644
--- a/cad/veriwell/Makefile
+++ b/cad/veriwell/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2020/03/18 17:45:25 joerg Exp $
+# $NetBSD: Makefile,v 1.3 2020/05/20 06:09:09 rillig Exp $
 
 DISTNAME=	veriwell-2.8.7
 CATEGORIES=	cad
@@ -14,5 +14,14 @@ USE_LANGUAGES=	c c++03
 
 TEST_TARGET=	check
 
+# parse.yy:2253:57: error: array subscript has type 'char' [-Werror=char-subscripts]
+# parse.yy:2253:85: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                 $$ = edge_mask[$1[0]][$1[1]];
+# parse.yy:2258:79: error: array subscript has type 'char' [-Werror=char-subscripts]
+# parse.yy:2258:108: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                 $$ = $3 | edge_mask[$1[0]][$1[1]];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/comms/estic/Makefile b/comms/estic/Makefile
index acb81a09d17..2d5641fa8a0 100644
--- a/comms/estic/Makefile
+++ b/comms/estic/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.38 2019/11/03 12:04:12 rillig Exp $
+# $NetBSD: Makefile,v 1.39 2020/05/20 06:09:03 rillig Exp $
 
 DISTNAME=	estic-1.61
 PKGREVISION=	2
@@ -32,6 +32,13 @@ CPPFLAGS+=	-DSOLARIS
 CPPFLAGS+=	-DFREEBSD
 .endif
 
+# str.cc: In function 'String ShowControls(const String&, unsigned int)':
+# str.cc:1145:57: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                      T += (Style & ccOct)? OctCodes [*Str] : HexCodes [*Str];
+#                                                         ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS=	bin
 
 post-extract:
diff --git a/comms/gsmlib/Makefile b/comms/gsmlib/Makefile
index d99486b446c..a20e1154c9d 100644
--- a/comms/gsmlib/Makefile
+++ b/comms/gsmlib/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.27 2018/07/18 00:06:12 joerg Exp $
+# $NetBSD: Makefile,v 1.28 2020/05/20 06:09:04 rillig Exp $
 #
 
 DISTNAME=	gsmlib-1.10
@@ -19,6 +19,13 @@ CONFIGURE_ARGS+=	--without-included-gettext
 PTHREAD_OPTS+=		require
 PTHREAD_AUTO_VARS=	yes
 
+# gsm_util.cc: In function 'std::string gsmlib::gsmToLatin1(std::string)':
+# gsm_util.cc:107:72: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      result[i] = (unsigned char)s[i] > 127 ? NOP : gsmToLatin1Table[s[i]];
+#                                                                         ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../mk/pthread.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/gcvs/Makefile b/devel/gcvs/Makefile
index 3334c098137..650430a72f7 100644
--- a/devel/gcvs/Makefile
+++ b/devel/gcvs/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.45 2020/01/26 05:26:23 rillig Exp $
+# $NetBSD: Makefile,v 1.46 2020/05/20 06:09:04 rillig Exp $
 
 DISTNAME=		gcvs-1.0
 PKGREVISION=		14
@@ -24,6 +24,14 @@ CONFIGURE_ARGS+=	perl_path=${PERL5}
 
 CPPFLAGS+=	-DUSE_INTERP_RESULT
 
+# Uh oh, Pascal-style strings with undefined behavior for length >= 128.
+# ../rf/ustr.h: In member function 'bool UPStr::endsWith(char) const':
+# ../rf/ustr.h:96:75: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   inline bool endsWith(char c) const {return str == 0L ? false : str[str[0]] == c;}
+#                                                                            ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../lang/tcl/buildlink3.mk"
 .include "../../x11/gtk/buildlink3.mk"
 
diff --git a/devel/mcpp/Makefile b/devel/mcpp/Makefile
index 1139526ef88..a830106528e 100644
--- a/devel/mcpp/Makefile
+++ b/devel/mcpp/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2017/09/03 08:53:07 wiz Exp $
+# $NetBSD: Makefile,v 1.3 2020/05/20 06:09:06 rillig Exp $
 
 DISTNAME=	mcpp-2.7.2
 CATEGORIES=	devel
@@ -15,4 +15,10 @@ USE_LIBTOOL=	yes
 
 CONFIGURE_ARGS+=	--enable-mcpplib
 
+# eval.c: In function 'eval_if':
+# eval.c:361:44: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                  , opname[ op], prec, opname[ opp->op], opp->prec, opp->skip);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/prcs/Makefile b/devel/prcs/Makefile
index 9996d851a7f..54a0536e625 100644
--- a/devel/prcs/Makefile
+++ b/devel/prcs/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.60 2020/03/20 11:57:30 nia Exp $
+# $NetBSD: Makefile,v 1.61 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=		prcs-1.3.3
 PKGREVISION=		14
@@ -28,4 +28,14 @@ REPLACE.perl5.old=	.*perl[^[:space:]]*
 REPLACE.perl5.new=	${PERL5}
 REPLACE_FILES.perl5=	emacs/prcs-ediff emacs/prcs-emerge
 
+# attrs.cc: In function 'int is_file_attribute_hash(const char*, int)':
+# attrs.cc:36:39: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    return len + hash_table[str[len - 1]] + hash_table[str[0]];
+#                                        ^
+# attrs.cc:36:60: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    return len + hash_table[str[len - 1]] + hash_table[str[0]];
+#                                                             ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/sdcc/Makefile b/devel/sdcc/Makefile
index 339451a4922..dcb084b2f85 100644
--- a/devel/sdcc/Makefile
+++ b/devel/sdcc/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.57 2020/03/20 11:57:32 nia Exp $
+# $NetBSD: Makefile,v 1.58 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	sdcc-src-2.8.0
 PKGNAME=	${DISTNAME:S/-src//}
@@ -38,6 +38,12 @@ CPPFLAGS+=		-fdollars-in-identifiers
 CONFIGURE_ENV+=		MACHINE_ARCH=${MACHINE_ARCH:Q}
 CONFIGURE_ENV+=		sdcc_cv_CCggdb="no"
 
+# simi.c: In function 'simGetValue':
+# simi.c:616:14: error: array subscript has type 'char' [-Werror=char-subscripts]
+#              b[i] = strtol(resp,&resp,16);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/bsd.prefs.mk"
 
 .if ${OPSYS} == "NetBSD"
diff --git a/devel/sgb/Makefile b/devel/sgb/Makefile
index 69e71658641..0357965ad16 100644
--- a/devel/sgb/Makefile
+++ b/devel/sgb/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.9 2020/01/29 16:04:04 minskim Exp $
+# $NetBSD: Makefile,v 1.10 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	sgb-2007-03.28
 PKGNAME=	sgb-20070328
@@ -27,6 +27,12 @@ SUBST_FILES.paths=	Makefile
 SUBST_VARS.paths=	LOCALBASE
 SUBST_SED.paths+=	-e 's,@PREFIX@,$${DESTDIR}${PREFIX},g'
 
+# gb_io.w: In function 'icode_setup':
+# gb_io.w:217:34: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    for (p=imap,k=0; *p; p++,k++) icode[*p]=k;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 post-install:
 	${INSTALL_DATA_DIR} ${DESTDIR}${PREFIX}/share/doc/sgb
 .for f in abstract.dvi README ERRATA
diff --git a/devel/tvision/Makefile b/devel/tvision/Makefile
index c382facdd71..1adcbb027ce 100644
--- a/devel/tvision/Makefile
+++ b/devel/tvision/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.25 2018/07/18 00:06:13 joerg Exp $
+# $NetBSD: Makefile,v 1.26 2020/05/20 06:09:09 rillig Exp $
 #
 
 DISTNAME=		tvision-0.8
@@ -18,5 +18,12 @@ GNU_CONFIGURE=		YES
 USE_LANGUAGES=		c c++03
 USE_LIBTOOL=		YES
 
+# puzzle.cc: In member function 'virtual void TPuzzleView::draw()':
+# puzzle.cc:134:75: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                  buf.moveStr( (short)(j*3), tmp, color[map[board[i][j]-'A']]);
+#                                                                            ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/curses.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/editors/em/Makefile b/editors/em/Makefile
index 0bf291e2382..2fb8d7546e5 100644
--- a/editors/em/Makefile
+++ b/editors/em/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2017/12/24 09:46:05 wiz Exp $
+# $NetBSD: Makefile,v 1.3 2020/05/20 06:09:03 rillig Exp $
 
 DISTNAME=	em-1.0.0
 CATEGORIES=	editors
@@ -12,4 +12,11 @@ LICENSE=	public-domain
 GNU_CONFIGURE=	yes
 AUTO_MKDIRS=	yes
 
+# em1.c: In function 'advance':
+# em1.c:1554:11: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    braslist[*ep++] = lp;
+#            ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/bsd.pkg.mk"
diff --git a/editors/emacs20/Makefile b/editors/emacs20/Makefile
index 59a372fc7c7..66f3361f4f3 100644
--- a/editors/emacs20/Makefile
+++ b/editors/emacs20/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.61 2020/01/26 17:31:06 rillig Exp $
+# $NetBSD: Makefile,v 1.62 2020/05/20 06:09:03 rillig Exp $
 
 DISTNAME=	emacs-20.7
 PKGNAME=	${DISTNAME:S/emacs/emacs20/}
@@ -84,6 +84,13 @@ MAKEFILECPP=	${CPP} -traditional-cpp
 .endif
 ALL_ENV+=	MAKEFILECPP=${MAKEFILECPP:Q}
 
+# emacs-20.7/lib-src/etags.c: In function 'init':
+# emacs-20.7/lib-src/etags.c:1208:35: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    for (sp = white; *sp; sp++) _wht[*sp] = TRUE;    _wht[0] = _wht['\n'];
+#                                    ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INFO_FILES=	yes
 
 INSTALL_PROGRAM=	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE}
diff --git a/editors/se/Makefile b/editors/se/Makefile
index 77c084adea6..53a57a9bf88 100644
--- a/editors/se/Makefile
+++ b/editors/se/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.4 2015/08/18 07:31:06 wiz Exp $
+# $NetBSD: Makefile,v 1.5 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	se-3.0.1
 PKGREVISION=	1
@@ -12,5 +12,11 @@ LICENSE=	public-domain
 
 GNU_CONFIGURE=	yes
 
+# pat.c: In function 'amatch':
+# pat.c:101:10: error: array subscript has type 'char' [-Werror=char-subscripts]
+#     tagbeg[*(ppat + 1)] = lastc - lin;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/curses.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/filesystems/fuse-afpfs-ng/Makefile b/filesystems/fuse-afpfs-ng/Makefile
index d30e8d2c533..7845f3791e2 100644
--- a/filesystems/fuse-afpfs-ng/Makefile
+++ b/filesystems/fuse-afpfs-ng/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.15 2019/06/22 11:52:31 nia Exp $
+# $NetBSD: Makefile,v 1.16 2020/05/20 06:09:04 rillig Exp $
 
 DISTNAME=	afpfs-ng-0.8.1
 PKGNAME=	fuse-${DISTNAME}
@@ -29,6 +29,13 @@ SUBST_SED.termcap+=	-e 's|ncurses||'
 SUBST_SED.termcap+=	-e 's|ncurses|${BUILDLINK_LIBNAME.termcap}|'
 .endif
 
+# debug.c: In function 'afp_get_command_name':
+# debug.c:62:33: error: array subscript has type 'char' [-Werror=char-subscripts]
+#          return afp_command_names[code];
+#                                  ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../devel/gmp/buildlink3.mk"
 .include "../../security/libgpg-error/buildlink3.mk"
 .include "../../security/libgcrypt/buildlink3.mk"
diff --git a/games/devilutionx/Makefile b/games/devilutionx/Makefile
index 4d71e75de04..e4b8b7dd8a3 100644
--- a/games/devilutionx/Makefile
+++ b/games/devilutionx/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2020/03/30 19:36:39 joerg Exp $
+# $NetBSD: Makefile,v 1.13 2020/05/20 06:09:03 rillig Exp $
 
 DISTNAME=	devilutionx-1.0.1
 CATEGORIES=	games
@@ -37,6 +37,13 @@ CXXFLAGS+=	-DO_LARGEFILE=0 -Dstat64=stat -Dlstat64=lstat -Dlseek64=lseek -Doff64
 # No idea.
 CXXFLAGS.NetBSD+=	-D_NETBSD_SOURCE
 
+# 3rdParty/StormLib/src/SFileFindFile.cpp: In function 'int CheckWildCard(const char*, const char*)':
+# 3rdParty/StormLib/src/SFileFindFile.cpp:72:54: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                  if(AsciiToUpperTable[szWildCardPtr[0]] == AsciiToUpperTable[szString[0]])
+#                                                       ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS+=	bin
 INSTALLATION_DIRS+=	share/applications
 INSTALLATION_DIRS+=	share/icons/hicolor/16x16/apps
diff --git a/games/eboard/Makefile b/games/eboard/Makefile
index c38dc2a0bef..d2fcf5230cd 100644
--- a/games/eboard/Makefile
+++ b/games/eboard/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.56 2020/04/18 22:03:58 joerg Exp $
+# $NetBSD: Makefile,v 1.57 2020/05/20 06:09:03 rillig Exp $
 #
 
 DISTNAME=		eboard-1.1.1
@@ -33,6 +33,15 @@ SUBST_SED.mf+=		-e 's/^LDFLAGS.*=/LDFLAGS += $${CXXFLAGS}/'
 
 BUILDLINK_TRANSFORM+=	rm:-O6
 
+# Can only handle ASCII characters in several places.
+# global.cc: In member function 'void Global::readRC()':
+# global.cc:466:46: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   case  4: p=t.token(sep); TabPos=rev[p->at(0)]; break;
+#                                               ^
+# Also warns a lot about -Wwrite-strings and others.
+# Let's hope that nobody uses this for exploits.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/oss.buildlink3.mk"
 .include "../../x11/gtk2/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/games/golddig/Makefile b/games/golddig/Makefile
index f302acfbe6b..09bf12d020e 100644
--- a/games/golddig/Makefile
+++ b/games/golddig/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2018/01/14 17:33:59 rillig Exp $
+# $NetBSD: Makefile,v 1.18 2020/05/20 06:09:04 rillig Exp $
 #
 
 DISTNAME=	golddigC3.1
@@ -10,6 +10,13 @@ MASTER_SITES=	http://www.NetBSD.org/~chuck/gz/
 MAINTAINER=	pkgsrc-users@NetBSD.org
 COMMENT=	Fast action game designed for use with X
 
+# badguy.c: In function 'move_badguys':
+# badguy.c:321:51: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      if((x & 1) == 0 && (y & 1) == 0 && fast_lookup[below].code & STOPBAD) {
+#                                                    ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS=	bin ${PKGMANDIR}/man6
 INSTALL_MAKE_FLAGS+=	PREFIX=${DESTDIR}${PREFIX} \
 			MAN=${DESTDIR}${PREFIX}/${PKGMANDIR}/man6
diff --git a/games/libretro-craft/Makefile b/games/libretro-craft/Makefile
index 20710284644..09ee8354ccc 100644
--- a/games/libretro-craft/Makefile
+++ b/games/libretro-craft/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.1 2018/08/11 00:48:50 nia Exp $
+# $NetBSD: Makefile,v 1.2 2020/05/20 06:09:06 rillig Exp $
 
 DISTNAME=	libretro-craft-20180803
 CATEGORIES=	games
@@ -16,6 +16,12 @@ USE_TOOLS+=	gmake
 MAKE_FILE=	Makefile.libretro
 MAKE_FLAGS+=	GIT_VERSION=" \(pkgsrc\)"
 
+# src/main.c: In function 'char_width':
+# src/main.c:301:18: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      return lookup[input];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS+=	${PREFIX}/lib/libretro
 
 do-install:
diff --git a/games/libretro-nxengine/Makefile b/games/libretro-nxengine/Makefile
index 9d62eb80c8b..39a84e5ecd9 100644
--- a/games/libretro-nxengine/Makefile
+++ b/games/libretro-nxengine/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.3 2019/09/07 21:18:50 nia Exp $
+# $NetBSD: Makefile,v 1.4 2020/05/20 06:09:06 rillig Exp $
 
 DISTNAME=	libretro-nxengine-20181126
 CATEGORIES=	games
@@ -24,6 +24,12 @@ CFLAGS+=	-DMSB_FIRST
 BUILDLINK_TRANSFORM.SunOS+=	rm:-Wl,--version-script=nxengine/libretro/link.T
 BUILDLINK_TRANSFORM.SunOS+=	rm:-Wl,-no-undefined
 
+# nxengine/graphics/font.cpp: In function 'bool font_init()':
+# nxengine/graphics/font.cpp:69:26: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    if (whitefont.letters[c]->h > fontheight)
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS+=	${PREFIX}/lib/libretro
 
 do-install:
diff --git a/games/scid/Makefile b/games/scid/Makefile
index 2a5f4552b12..7a113fd3620 100644
--- a/games/scid/Makefile
+++ b/games/scid/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.24 2020/03/20 11:57:44 nia Exp $
+# $NetBSD: Makefile,v 1.25 2020/05/20 06:09:08 rillig Exp $
 #
 
 DISTNAME=		scid-3.6.1
@@ -34,6 +34,12 @@ MAKE_ENV+=		X_LDFLAGS=${X11_LDFLAGS:Q}
 
 REPLACE_PYTHON+=	scripts/pgnfix.py
 
+# src/textbuf.h: In member function 'void TextBuffer::ClearTranslation(char)':
+# src/textbuf.h:70:57: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      void     ClearTranslation (char ch) { Translation[ch] = NULL; }
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../lang/python/application.mk"
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../lang/tcl/buildlink3.mk"
diff --git a/games/supertuxkart/Makefile b/games/supertuxkart/Makefile
index 54f3d4ef0b1..f39fe3059a3 100644
--- a/games/supertuxkart/Makefile
+++ b/games/supertuxkart/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.35 2020/05/06 14:04:34 adam Exp $
+# $NetBSD: Makefile,v 1.36 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	supertuxkart-1.1-src
 PKGNAME=	${DISTNAME:S/-src//}
@@ -29,6 +29,13 @@ CMAKE_ARGS+=	-DENABLE_WAYLAND_DEVICE=OFF
 CXXFLAGS+=	-march=i586
 .endif
 
+# lib/mcpp/eval.c: In function 'eval_if':
+# lib/mcpp/eval.c:361:44: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                  , opname[ op], prec, opname[ opp->op], opp->prec, opp->skip);
+#                                             ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../archivers/bzip2/buildlink3.mk"
 .include "../../audio/libvorbis/buildlink3.mk"
 .include "../../audio/openal-soft/buildlink3.mk"
diff --git a/games/xevil/Makefile b/games/xevil/Makefile
index e32aefaa267..8991ef01f86 100644
--- a/games/xevil/Makefile
+++ b/games/xevil/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.25 2019/05/23 19:23:01 rillig Exp $
+# $NetBSD: Makefile,v 1.26 2020/05/20 06:09:09 rillig Exp $
 
 DISTNAME=	xevilsrc2.02r2
 PKGNAME=	xevil-2.02
@@ -22,6 +22,13 @@ MAKE_ENV+=	HOSTTYPE="pkgsrc"
 
 USE_LANGUAGES=	c++03
 
+# draw.cpp: In member function 'void World::draw_square(Drawable, Xvars&, int, const Loc&, int, int, Boolean)':
+# draw.cpp:47:63: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    int blockNum = themes[themeIndex].blockIndices[map[l.r][l.c]];
+#                                                                ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS=	bin
 
 do-install:
diff --git a/games/xnibbles/Makefile b/games/xnibbles/Makefile
index 8dc8f8bb5d5..366a82012e4 100644
--- a/games/xnibbles/Makefile
+++ b/games/xnibbles/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.24 2020/04/27 18:31:36 rillig Exp $
+# $NetBSD: Makefile,v 1.25 2020/05/20 06:09:09 rillig Exp $
 #
 
 DISTNAME=		xnibbles-1.0BETA4
@@ -28,6 +28,12 @@ SUBST_FILES.audio=	Makefile
 SUBST_SED.audio=	-e "s|/dev/dsp|${DEVOSSAUDIO}|"
 .endif
 
+# boni.c: In member function 'void boni::addBonus(char, int)':
+# boni.c:65:21: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    } while (objects[x][y] != 'a' || objects[x + 1][y] != 'a' || objects[x][y + 1] != 'a' || objects[x + 1][y + 1] != 'a');
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../x11/libXpm/buildlink3.mk"
 .include "../../mk/oss.buildlink3.mk"
 
diff --git a/games/xye/Makefile b/games/xye/Makefile
index 3f834654e23..68b5d923ee5 100644
--- a/games/xye/Makefile
+++ b/games/xye/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2020/03/20 11:57:46 nia Exp $
+# $NetBSD: Makefile,v 1.18 2020/05/20 06:09:10 rillig Exp $
 #
 
 DISTNAME=	xye-0.12.1
@@ -20,6 +20,13 @@ SUBST_STAGE.crlf=	post-extract
 SUBST_FILES.crlf=	*/*
 SUBST_FILTER_CMD.crlf=	${TR} -d '\r'
 
+# src/xye.cpp: In static member function 'static void game::start(bool)':
+# src/xye.cpp:1225:23: error: array subscript has type 'char' [-Werror=char-subscripts]
+#              sq=&grid[i][j];
+#                        ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../devel/SDL/buildlink3.mk"
 .include "../../graphics/SDL_image/buildlink3.mk"
 .include "../../devel/SDL_ttf/buildlink3.mk"
diff --git a/graphics/libraw/Makefile b/graphics/libraw/Makefile
index f4252f0b57c..810f5da2053 100644
--- a/graphics/libraw/Makefile
+++ b/graphics/libraw/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.33 2020/04/26 06:38:17 rillig Exp $
+# $NetBSD: Makefile,v 1.34 2020/05/20 06:09:06 rillig Exp $
 
 DISTNAME=	LibRaw-0.19.5
 PKGNAME=	${DISTNAME:tl}
@@ -19,6 +19,12 @@ CONFIGURE_ARGS+=	--disable-examples
 PKGCONFIG_OVERRIDE+=	libraw.pc.in
 PKGCONFIG_OVERRIDE+=	libraw_r.pc.in
 
+# internal/dcraw_common.cpp: In member function 'void LibRaw::xtrans_interpolate(int)':
+# internal/dcraw_common.cpp:5885:27: error: array subscript has type 'char' [-Werror=char-subscripts]
+#        cstat[fcol(row, col)]++;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "options.mk"
 .include "../../graphics/lcms2/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"
diff --git a/graphics/xfig/Makefile b/graphics/xfig/Makefile
index 0d60140f283..56bd3c675a0 100644
--- a/graphics/xfig/Makefile
+++ b/graphics/xfig/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.76 2020/03/20 11:57:53 nia Exp $
+# $NetBSD: Makefile,v 1.77 2020/05/20 06:09:09 rillig Exp $
 
 DISTNAME=	xfig-3.2.6a
 PKGNAME=	${DISTNAME:S/-full//}
@@ -19,6 +19,12 @@ GNU_CONFIGURE=		yes
 
 CONFIGURE_ARGS+=	--with-appdefaultdir=${PREFIX}/lib/X11/app-defaults
 
+# w_cmdpanel.c: In function 'change_orient':
+# w_cmdpanel.c:893:36: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      FirstArg(XtNlabel, orient_items[appres.landscape]);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../mk/jpeg.buildlink3.mk"
 .include "../../graphics/png/buildlink3.mk"
 .include "../../x11/libXi/buildlink3.mk"
diff --git a/lang/objc/Makefile b/lang/objc/Makefile
index b1cc9bdf0d7..e0f9de332a1 100644
--- a/lang/objc/Makefile
+++ b/lang/objc/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2020/04/27 05:17:00 rillig Exp $
+# $NetBSD: Makefile,v 1.19 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=	objc-3.2.10
 CATEGORIES=	lang
@@ -39,6 +39,12 @@ SUBST_SED.mandir=	-e '/$$(TAR)/s,man,${PKGMANDIR},'
 SUBST_FILES.mandir=	Makefile
 SUBST_NOOP_OK.mandir=	yes # PKGMANDIR defaults to man
 
+# ocstring.m: In function 'strtolower':
+# ocstring.m:627:25: error: array subscript has type 'char' [-Werror=char-subscripts]
+#        *s++ = tolower (c);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 pre-configure:
 	${ECHO} >> ${WRKSRC_BS}/configure \
 	'${SETENV} ${MAKE_ENV} ${MAKE_PROGRAM} ${BUILD_MAKE_FLAGS} -f ${MAKE_FILE} ${BUILD_TARGET}'
diff --git a/mail/mush/Makefile b/mail/mush/Makefile
index cc32dd6cb54..0a7dc55cf94 100644
--- a/mail/mush/Makefile
+++ b/mail/mush/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.32 2019/11/02 16:25:23 rillig Exp $
+# $NetBSD: Makefile,v 1.33 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=	mush-7.2.5
 PKGNAME=	mush-7.2.6.b4.pl1
@@ -42,6 +42,12 @@ SUBST_VARS.paths=	PREFIX
 SUBST_SED.paths+=	-e 's,@MANDIR@,${PREFIX}/${PKGMANDIR},g'
 SUBST_STAGE.paths=	pre-configure
 
+# strings.c: In function 'ctrl_strcpy':
+# strings.c:510:24: error: array subscript has type 'char' [-Werror=char-subscripts]
+#       *s_out++ = _unctrl[*s_in][1];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 pre-configure:
 	${CP} ${WRKSRC}/config.h-dist ${WRKSRC}/config.h
 	${CP} ${WRKSRC}/${PLAT_MAKEFILE} ${WRKSRC}/Makefile
diff --git a/mail/pine/Makefile b/mail/pine/Makefile
index 7b8e3b28264..ed27f2a9c79 100644
--- a/mail/pine/Makefile
+++ b/mail/pine/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.138 2020/01/18 21:49:52 jperkin Exp $
+# $NetBSD: Makefile,v 1.139 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=	pine4.64
 PKGNAME=	pine-4.64
@@ -41,6 +41,12 @@ BUILDFILE=	neb
 
 BUILDLINK_TRANSFORM.OpenBSD+=	rm:-lcrypt
 
+# filter.c: In function 'html_entity_collector':
+# filter.c:5570:5: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   buf[len++] = ch;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .if !empty(CC_VERSION:Mgcc-*)
 UNLIMIT_RESOURCES+=	datasize
 .endif
diff --git a/misc/hanzim/Makefile b/misc/hanzim/Makefile
index 425ee2e5f7e..db3d3c3e291 100644
--- a/misc/hanzim/Makefile
+++ b/misc/hanzim/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2018/03/12 11:17:06 wiz Exp $
+# $NetBSD: Makefile,v 1.19 2020/05/20 06:09:04 rillig Exp $
 #
 
 DISTNAME=	hanzim-1.3
@@ -20,6 +20,13 @@ BUILD_TARGET=	hanzim
 # XXX
 #MAKE_ENV+=	SHELL=${SH:Q} LC_CTYPE=en_US.ISO8859-1
 
+# hanwin.c: In function 'charinfo':
+# hanwin.c:481:25: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    strcpy(pinyin,init_str[pinyintbl[cht->pinyins.ent[0]].init]);
+#                          ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS+=	bin ${PKGMANDIR}/man1
 
 .include "../../lang/tcl/buildlink3.mk"
diff --git a/multimedia/libmediainfo/Makefile b/multimedia/libmediainfo/Makefile
index c6cba9d17ff..93e22ce5c90 100644
--- a/multimedia/libmediainfo/Makefile
+++ b/multimedia/libmediainfo/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.6 2017/06/01 13:30:26 jlam Exp $
+# $NetBSD: Makefile,v 1.7 2020/05/20 06:09:05 rillig Exp $
 
 .include "../../multimedia/mediainfo/Makefile.common"
 
@@ -26,6 +26,12 @@ CONFIGURE_ARGS+=	--enable-shared
 
 INSTALLATION_DIRS+=	bin lib/pkgconfig
 
+# ../../../Source/ThirdParty/base64/base64.h: In function 'std::string Base64::encode(const string&)':
+# ../../../Source/ThirdParty/base64/base64.h:53:41: error: array subscript has type 'char'
+#      sResult.append(1, sBase64Table[cCode]);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 pre-configure:
 	cd ${WRKSRC}/${CONFIGURE_DIRS:Q} && autoreconf -i
 
diff --git a/multimedia/libmp4v2/Makefile b/multimedia/libmp4v2/Makefile
index cacd14229b0..80f919f0580 100644
--- a/multimedia/libmp4v2/Makefile
+++ b/multimedia/libmp4v2/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.24 2020/03/20 11:58:04 nia Exp $
+# $NetBSD: Makefile,v 1.25 2020/05/20 06:09:05 rillig Exp $
 
 DISTNAME=		mpeg4ip-1.6.1
 PKGNAME=		libmp4v2-1.6.1
@@ -34,6 +34,12 @@ SUBST_FILES.minmax=	common/video/iso-mpeg4/src/*
 SUBST_SED.minmax=	-e 's,min *(,MIN(,g' -e 's,max *(,MAX(,g'
 SUBST_MESSAGE.minmax=	replace lowercase min,max with uppercase
 
+# util.c: In function 'quicktime_read_pascal':
+# util.c:138:6: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   data[len] = 0;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 pre-configure:
 	${TOUCH} ${WRKSRC}/bootstrapped
 
diff --git a/multimedia/openquicktime/Makefile b/multimedia/openquicktime/Makefile
index e2a9554a495..6c71afe06ad 100644
--- a/multimedia/openquicktime/Makefile
+++ b/multimedia/openquicktime/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.24 2020/03/08 16:48:00 wiz Exp $
+# $NetBSD: Makefile,v 1.25 2020/05/20 06:09:07 rillig Exp $
 #
 
 DISTNAME=		${PKGNAME_NOREV}-src
@@ -24,6 +24,12 @@ CONFIGURE_ENV+=		my_cv_comment=""
 OPSYSVARS+=		USE_TOOLS
 USE_TOOLS.SunOS+=	gsed
 
+# udta.c: In function 'quicktime_write_udta':
+# util.c:213:6: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   data[len] = 0;
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALL_MAKE_FLAGS+=	prefix=${DESTDIR}${PREFIX}
 INSTALLATION_DIRS+=	bin lib
 
diff --git a/net/openag/Makefile b/net/openag/Makefile
index 3e1b39c3c1c..80eb3862f04 100644
--- a/net/openag/Makefile
+++ b/net/openag/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.15 2019/11/03 11:45:46 rillig Exp $
+# $NetBSD: Makefile,v 1.16 2020/05/20 06:09:07 rillig Exp $
 #
 
 DISTNAME=	OpenAG-1.1.1
@@ -18,6 +18,13 @@ USE_TOOLS+=	wget:run
 
 CONFIGURE_ENV+=	WGET=wget
 
+# mp3info/mp3info.cpp: In function 'long int get_length(mp3_file_info*, FILE*, long int)':
+# mp3info/mp3info.cpp:436:52: error: array subscript has type 'char' [-Werror=char-subscripts]
+#       sample_rate = samples_rates_frequencies[mpeg_v][((scan2&0x0c) >> 2)];
+#                                                     ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../devel/zlib/buildlink3.mk"
 
 INSTALLATION_DIRS+=	share/doc/OpenAG
diff --git a/news/nn/Makefile b/news/nn/Makefile
index 05f39e4345a..0fb5724e0c0 100644
--- a/news/nn/Makefile
+++ b/news/nn/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.50 2019/11/04 19:17:11 rillig Exp $
+# $NetBSD: Makefile,v 1.51 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=	nn-6.7.3
 PKGREVISION=	5
@@ -16,6 +16,12 @@ TOOL_DEPENDS+=	tradcpp-[0-9]*:../../devel/tradcpp
 
 CPPFLAGS.IRIX+=	-DHAVE_TERMIO_H
 
+# decode.c: In function 'decode_line':
+# decode.c:132:22: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      if ((blen = trtbl[buf[0]]) < 0) {
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 OPSYSVARS+=	SFILE
 SFILE.SunOS=	s-sunos5.h
 SFILE.Linux=	s-linux.h
diff --git a/security/p5-Digest-Hashcash/Makefile b/security/p5-Digest-Hashcash/Makefile
index abd22a01b76..8b261071765 100644
--- a/security/p5-Digest-Hashcash/Makefile
+++ b/security/p5-Digest-Hashcash/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.28 2019/08/11 13:22:56 wiz Exp $
+# $NetBSD: Makefile,v 1.29 2020/05/20 06:09:07 rillig Exp $
 
 DISTNAME=	Digest-Hashcash-1.1
 PKGNAME=	p5-${DISTNAME}
@@ -15,5 +15,11 @@ DEPENDS+=	p5-Canary-Stability-[0-9]*:../../devel/p5-Canary-Stability
 
 PERL5_PACKLIST=		auto/Digest/Hashcash/.packlist
 
+# Hashcash.xs: In function 'XS_Digest__Hashcash__gentoken':
+# Hashcash.xs:441:28: error: array subscript has type 'char' [-Werror=char-subscripts]
+#                *s = nextenc [*s];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../lang/perl5/module.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/shells/scponly/Makefile b/shells/scponly/Makefile
index bb627dd007a..85e108b49c7 100644
--- a/shells/scponly/Makefile
+++ b/shells/scponly/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2018/03/02 09:02:52 sborrill Exp $
+# $NetBSD: Makefile,v 1.18 2020/05/20 06:09:08 rillig Exp $
 
 DISTNAME=	scponly-4.8
 PKGREVISION=	2
@@ -31,6 +31,12 @@ CONFIGURE_ENV+=		scponly_PROG_RMDIR=${TOOLS_RMDIR:Q}
 CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR:Q}
 CONFIGURE_ARGS+=	--enable-scp-compat
 
+# helper.c: In function 'mysetenv':
+# helper.c:565:14: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   if ((safeenv[count] = strdup(buff))) {
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 PKG_SHELL=		bin/scponly
 PKG_SYSCONFSUBDIR=	scponly
 
diff --git a/sysutils/fs-kit/Makefile b/sysutils/fs-kit/Makefile
index 189f5b4026c..ebf75e4f675 100644
--- a/sysutils/fs-kit/Makefile
+++ b/sysutils/fs-kit/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.8 2012/10/23 19:51:02 asau Exp $
+# $NetBSD: Makefile,v 1.9 2020/05/20 06:09:04 rillig Exp $
 
 DISTNAME=	fs-kit-0.4
 CATEGORIES=	sysutils
@@ -19,6 +19,13 @@ WRKSRC=		${WRKDIR}/fs-kit
 CFLAGS+=	-Dunix=1
 MAKE_FILE=	makefile
 
+# kernel.c: In function 'move_vnode':
+# kernel.c:2225:14: error: array subscript has type 'char' [-Werror=char-subscripts]
+#          lists[vn->inlist].head = vn->list.next;
+#               ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 INSTALLATION_DIRS=	sbin share/doc
 
 do-install:
diff --git a/sysutils/hal/Makefile b/sysutils/hal/Makefile
index 1227701ac37..ab4f35cceb1 100644
--- a/sysutils/hal/Makefile
+++ b/sysutils/hal/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.89 2020/04/29 19:50:02 maya Exp $
+# $NetBSD: Makefile,v 1.90 2020/05/20 06:09:04 rillig Exp $
 
 DISTNAME=		hal-0.5.14
 PKGREVISION=		23
@@ -25,6 +25,12 @@ MAKE_DIRS+=		/media
 MAKE_DIRS+=		${VARBASE}/cache/hald
 SPECIAL_PERMS+=		${VARBASE}/cache/hald ${HAL_USER} ${HAL_GROUP} 0644
 
+# devinfo_mass.c: In function 'devinfo_mass_disklabel_add':
+# devinfo_mass.c:340:28: error: array subscript has type 'char'
+#   part = &label.d_partitions[unit];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 EGDIR=			${PREFIX}/share/examples/hal
 
 CONF_FILES=		${EGDIR}/hal.conf ${PKG_SYSCONFBASE}/dbus-1/system.d/hal.conf
diff --git a/sysutils/xnc/Makefile b/sysutils/xnc/Makefile
index da7573e226e..9b716fa2612 100644
--- a/sysutils/xnc/Makefile
+++ b/sysutils/xnc/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.42 2018/07/18 00:06:23 joerg Exp $
+# $NetBSD: Makefile,v 1.43 2020/05/20 06:09:09 rillig Exp $
 
 DISTNAME=	xnc-5.0.4.src
 PKGNAME=	xnc-5.0.4
@@ -19,6 +19,12 @@ USE_LIBTOOL=	yes
 USE_TOOLS+=	msgfmt
 GNU_CONFIGURE=	yes
 
+# editor.cxx: In member function 'char Editor::trans(int, char)':
+# editor.cxx:624:15: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    sym=rtbl[sym];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 BUILDLINK_DEPMETHOD.libXt?=	build
 
 .include "../../graphics/tiff/buildlink3.mk"
diff --git a/sysutils/xps/Makefile b/sysutils/xps/Makefile
index edc7943be1d..1b6b5d50b6a 100644
--- a/sysutils/xps/Makefile
+++ b/sysutils/xps/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.49 2020/03/20 11:58:23 nia Exp $
+# $NetBSD: Makefile,v 1.50 2020/05/20 06:09:10 rillig Exp $
 
 DISTNAME=	xps-4.2
 PKGREVISION=	10
@@ -15,6 +15,12 @@ CONFIGURE_ARGS+=	x_applibdir=${PREFIX}/lib/X11/app-defaults
 
 CFLAGS.NetBSD+=	-D_KMEMUSER
 
+# os.c: In function 'GetStatus':
+# os.c:176:34: error: array subscript has type 'char' [-Werror=char-subscripts]
+#    EndNode->color = base.nodeColor[pstat];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 post-extract:
 	${LN} -s FreeBSD ${WRKSRC}/src/DragonFly
 
diff --git a/textproc/isearch/Makefile b/textproc/isearch/Makefile
index 6ffd4d33e88..ec1959342b0 100644
--- a/textproc/isearch/Makefile
+++ b/textproc/isearch/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2019/10/12 21:14:22 rillig Exp $
+# $NetBSD: Makefile,v 1.18 2020/05/20 06:09:05 rillig Exp $
 
 DISTNAME=		Isearch-1.47.01
 PKGNAME=		isearch-1.47.01
@@ -18,6 +18,12 @@ USE_LANGUAGES=		c c++
 
 INSTALLATION_DIRS=	bin share/doc/isearch
 
+# string.cxx: In function 'char* transcode(char*, const char**)':
+# string.cxx:1215:29: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      if (transarray[*obufscan]) {
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 post-install:
 	${INSTALL_DATA} ${WRKSRC}/TUTORIAL ${DESTDIR}${PREFIX}/share/doc/isearch
 	${INSTALL_DATA} ${WRKSRC}/doc/DebugFirewall.doc ${DESTDIR}${PREFIX}/share/doc/isearch
diff --git a/textproc/lq-sp/Makefile b/textproc/lq-sp/Makefile
index ffc8413c254..f8d088d34be 100644
--- a/textproc/lq-sp/Makefile
+++ b/textproc/lq-sp/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2020/01/26 17:32:15 rillig Exp $
+# $NetBSD: Makefile,v 1.18 2020/05/20 06:09:06 rillig Exp $
 #
 
 DISTNAME=	lq-sp-1.3.4.12
@@ -19,6 +19,13 @@ SUBST_SED.paths=	-e 's,/usr/local,${PREFIX},g'
 
 INSTALLATION_DIRS+=	bin
 
+# CmdLineApp.cxx: In member function 'StringC CmdLineApp::usageString()':
+# CmdLineApp.cxx:115:35: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      else if (!hadOption[optstr_[i]]) {
+#                                   ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/nsgmls/lq-nsgmls ${DESTDIR}${PREFIX}/bin
 
diff --git a/www/htdig/Makefile b/www/htdig/Makefile
index 896137027a5..8192ba4453c 100644
--- a/www/htdig/Makefile
+++ b/www/htdig/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.46 2020/03/20 11:58:34 nia Exp $
+# $NetBSD: Makefile,v 1.47 2020/05/20 06:09:05 rillig Exp $
 
 DISTNAME=	htdig-3.2.0b6
 PKGREVISION=	1
@@ -24,6 +24,13 @@ CONFIGURE_ARGS+=	--with-search-dir=${PREFIX}/share/examples/htdig
 CONFIGURE_ENV+=		PDF_PARSER="${LOCALBASE}/bin/acroread"
 CXXFLAGS+=		-Wno-deprecated
 
+# StringMatch.cc: In member function 'int StringMatch::Compare(const char*, int&, int&)':
+# StringMatch.cc:314:37: error: array subscript has type 'char' [-Werror=char-subscripts]
+#   new_state = table[trans[string[pos]]][state];
+#                                      ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 PKG_SYSCONFSUBDIR=	htdig
 INSTALLATION_DIRS+=	share/htdig/common
 
diff --git a/x11/fltk/Makefile b/x11/fltk/Makefile
index 7a7c7c4c41f..2c1f32c0733 100644
--- a/x11/fltk/Makefile
+++ b/x11/fltk/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.86 2020/03/06 09:18:40 wiz Exp $
+# $NetBSD: Makefile,v 1.87 2020/05/20 06:09:03 rillig Exp $
 
 DISTNAME=	fltk-1.1.10-source
 PKGNAME=	${DISTNAME:S/-source//}
@@ -34,6 +34,14 @@ CONFIGURE_ARGS+=	--with-links
 PLIST.cs=		yes
 .endif
 
+# Fl_Text_Buffer.cxx: In function 'char chooseNullSubsChar(char*)':
+# Fl_Text_Buffer.cxx:1338:34: error: array subscript has type 'char' [-Werror=char-subscripts]
+#      if ( hist[ replacements[ i ] ] == 0 )
+#                                   ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
+
 BUILDLINK_DEPMETHOD.libXt?=	build
 
 .include "../../graphics/MesaLib/buildlink3.mk"
diff --git a/x11/wxGTK28-contrib/Makefile b/x11/wxGTK28-contrib/Makefile
index 5fdd55ba76b..0bcf4af8198 100644
--- a/x11/wxGTK28-contrib/Makefile
+++ b/x11/wxGTK28-contrib/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.43 2020/03/18 18:03:53 joerg Exp $
+# $NetBSD: Makefile,v 1.44 2020/05/20 06:09:09 rillig Exp $
 
 .include "../../x11/wxGTK28/Makefile.common"
 
@@ -18,6 +18,13 @@ INSTALL_TARGET=		install
 
 BUILDLINK_DEPMETHOD.libXt?=	build
 
+# ../../../../contrib/src/stc/scintilla/src/Editor.cxx: In member function 'void Editor::LayoutLine(int, Surface*, ViewStyle&, LineLayout*, int)':
+# ../../../../contrib/src/stc/scintilla/src/Editor.cxx:2048:47: error: array subscript has type 'char' [-Werror=char-subscripts]
+#         if (ctrlCharWidth[ll->chars[charInLine]] == 0) {
+#                                                ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 .include "../../x11/wxGTK28/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/x11/wxGTK30/Makefile b/x11/wxGTK30/Makefile
index aa54fd6098e..2a2ba5f5dec 100644
--- a/x11/wxGTK30/Makefile
+++ b/x11/wxGTK30/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.37 2020/03/10 22:09:17 wiz Exp $
+# $NetBSD: Makefile,v 1.38 2020/05/20 06:09:09 rillig Exp $
 
 DISTNAME=	wxWidgets-3.0.4
 PKGNAME=	${DISTNAME:S/wxWidgets/wxGTK30/}
@@ -33,6 +33,13 @@ CONFIGURE_ARGS+=	--disable-visibility
 CONFIGURE_ARGS+=	--bindir=${PREFIX}/libexec/wx-3.0
 CONFIGURE_ARGS+=	--datarootdir=${PREFIX}/share/wx-3.0
 
+# ./src/stc/scintilla/src/Editor.cxx: In member function 'void Editor::LayoutLine(int, Surface*, ViewStyle&, LineLayout*, int)':
+# ./src/stc/scintilla/src/Editor.cxx:2200:47: error: array subscript has type 'char' [-Werror=char-subscripts]
+#         if (ctrlCharWidth[ll->chars[charInLine]] == 0) {
+#                                                ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+=	rm:-Werror=char-subscripts
+
 DOCDIR=			share/wx-3.0/doc/wxWidgets
 
 INSTALL_MAKE_FLAGS+=	LN_S="ln -fs"