summaryrefslogtreecommitdiff
path: root/audio/kdemultimedia2
diff options
context:
space:
mode:
authoragc <agc@pkgsrc.org>2002-09-04 14:47:32 +0000
committeragc <agc@pkgsrc.org>2002-09-04 14:47:32 +0000
commitcb0e38446b26c5bb3ee8b10360669165287c6faa (patch)
treec5f617edba6ae81af7be6e5d984ab9fdbe5a97f4 /audio/kdemultimedia2
parente3796adbcd56281dbb92ae41375bc079d3fd02f2 (diff)
downloadpkgsrc-cb0e38446b26c5bb3ee8b10360669165287c6faa.tar.gz
Apply patches from Lubomir Sedlacik <salo@Xtrmntr.org> in PR 18115 to
generalise the linker flags used to export symbols by setting them on a per-OS basis. > many packages force -Wl,-export-dynamic which is not portable outside GNU ld > and cause problems e.g. on Solaris. some of these packages use if > conditionals either only for NetBSD or except SunOS, but the state is not > coherent and it may complicate later when support for new OS is added to > pkgsrc (e.g. ongoing work on HP-UX support). > > jlam proposed the following framework in discussion on tech-pkg: > > http://mail-index.netbsd.org/tech-pkg/2002/06/21/0009.html > > now, ${EXPORT_SYMBOLS_LDFLAGS} is used instead of directly defining > -Wl,-export-dynamic which is set in appropriate defs.*.mk to reasonable > values. packages should be converted to this framework by: > > 1) replacing LDFLAGS+= -Wl,-export-dynamic and LIBS+= -export-dynamic with: > > LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS} > > 2) for use in patchfiles, add this variable to MAKE_ENV if needed: > > MAKE_ENV+= EXPORT_SYMBOLS_LDFLAGS=${EXPORT_SYMBOLS_LDFLAGS} > > 3) replace occurances of -Wl,-export-dynamic and -export-dynamic in patch > files with: > > $(EXPORT_SYMBOLS_LDFLAGS)
Diffstat (limited to 'audio/kdemultimedia2')
-rw-r--r--audio/kdemultimedia2/Makefile9
1 files changed, 3 insertions, 6 deletions
diff --git a/audio/kdemultimedia2/Makefile b/audio/kdemultimedia2/Makefile
index 60f5a47a9e8..d2f0d3dd682 100644
--- a/audio/kdemultimedia2/Makefile
+++ b/audio/kdemultimedia2/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2002/08/01 05:48:04 jlam Exp $
+# $NetBSD: Makefile,v 1.13 2002/09/04 14:47:35 agc Exp $
DISTNAME= kdemultimedia-2.2.2
PKGREVISION= 1
@@ -15,11 +15,8 @@ PTHREAD_OPTS+= require
CONFIGURE_ENV+= ac_cv_path_kde_artsplug_compiles="${ARTSCCONFIG}"
-.include "../../mk/bsd.prefs.mk"
-
-.if ${OPSYS} == "NetBSD"
-LIBS= -Wl,--export-dynamic
-.endif
+# Ensure we export symbols in the linked shared object.
+LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS}
.include "../../x11/kde2/buildlink.mk"
.include "../../x11/kdebase2/buildlink.mk"