geography/gdal-lib: Update to 2.3.3

2.3.3: bug fixes and minor improvements
2.3.2: bug fixes and minor improvements
2.3.1: bug fixes and minor improvements

= GDAL/OGR 2.3.0 Release Notes =

Note: due to the change of SCM during the development, #XXXX still refers to
Trac tickets. GitHub tickets are explicitly indicated with github #XXXX

== In a nutshell... ==

 * New GDAL drivers:
   - PDS4: read/write
   - RDA: DigitalGlobe Raster Data Access (read-only)
 * New OGR drivers:
   - MVT: add read/write driver for Mapbox Vector Tile standalone files or tilesets
   - ESRIJson and TopoJSON: read-only, splitted from existing code of the GeoJSON driver
   - WFS3: *experimental* read-only driver
 * RFC 68: Make C++11 a build requirement
    https://trac.osgeo.org/gdal/wiki/rfc68_cplusplus11
 * RFC 70: Guess output format from extension of output filename, if no explicit format passed to C++ or Python utilities
    https://trac.osgeo.org/gdal/wiki/rfc70_output_format_guess
 * RFC 71: Move to GitHub for source code repository and issue tracker.
    https://trac.osgeo.org/gdal/wiki/rfc71_github_migration
 * Significantly improved drivers:
    - MBTiles (vector tiles support)
    - DXF
    - GRIB (GRIB2 write support)
    - WCS (support WCS 2.0)
 * Improvements in network-based /vsi handlers: /vsicurl, /vsis3, /vsigs. Add:
     - /vsiaz for Microsoft Azure Blobs
     - /vsioss for Alibaba Cloud Object Storage Service
     - /vsiswift/ for OpenStack Swift object storage
 * Command line utilities: use Unicode main on Windows to avoid issues with non-ASCII characters (#7065)
 * Update to EPSG v9.2 (#7125)
 * Update data/esri_extra.wkt and add data/esri_epsg.wkt, taken from https://github.com/Esri/projection-engine-db-doc (Apache v2 license) (#2163)
 * Add support for PROJ.5 new API (requires proj 5.0.1 or later). PROJ 4.X is still supported.
 * More than 1000 fixes for issues/vulnerabilities found by OSS-Fuzz
 * Remove raster OGDI driver (vector OGDI driver still there) (#7087)

== New installed files ==

 * data/pds4_template.xml
 * data/esri_epsg.wkt

== Backward compatibility issues ==

See MIGRATION_GUIDE.TXT



Note that changes are extensive; see NEWS in the distfile.

11 files changed, 75 insertions, 64 deletions

diff --git a/geography/gdal-lib/Makefile b/geography/gdal-lib/Makefile
index 514100b1ffc..97c5976361e 100644
--- a/geography/gdal-lib/Makefile
+++ b/geography/gdal-lib/Makefile
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.109 2019/03/08 20:23:23 gdt Exp $
+# $NetBSD: Makefile,v 1.110 2019/03/09 01:54:59 gdt Exp $
 
-PKGREVISION=	9
+#PKGREVISION=	0
 .include "../../geography/gdal-lib/Makefile.common"
 PKGNAME=	${DISTNAME:S/gdal/gdal-lib/}
 
@@ -10,6 +10,8 @@ HOMEPAGE=	http://www.gdal.org/
 COMMENT=	Translator library for raster geospatial data formats
 LICENSE=	mit
 
+USE_LANGUAGES+=	c99 c++11
+
 # This package intends to link against only libgeos_c, but ends up
 # also linking to the C++ library libgeos, apparently because of a
 # libtool problem.
@@ -17,7 +19,7 @@ LICENSE=	mit
 
 CONFIGURE_ARGS+=	--without-python
 
-CONFIGURE_ARGS+=	--with-static-proj4
+CONFIGURE_ARGS+=	--with-proj
 
 MAKE_FILE=		GNUmakefile
 
diff --git a/geography/gdal-lib/Makefile.common b/geography/gdal-lib/Makefile.common
index 849803862a9..ab51310fed2 100644
--- a/geography/gdal-lib/Makefile.common
+++ b/geography/gdal-lib/Makefile.common
@@ -1,9 +1,10 @@
-# $NetBSD: Makefile.common,v 1.2 2018/03/21 23:20:12 gdt Exp $
+# $NetBSD: Makefile.common,v 1.3 2019/03/09 01:54:59 gdt Exp $
 #
 # used by geography/gdal-lib/Makefile
 # used by geography/py-gdal/Makefile
 
-DISTNAME=	gdal-2.2.4
+VERSION=	2.3.3
+DISTNAME=	gdal-${VERSION}
 CATEGORIES=	geography
 MASTER_SITES=	http://download.osgeo.org/gdal/${PKGVERSION_NOREV}/
 
diff --git a/geography/gdal-lib/PLIST b/geography/gdal-lib/PLIST
index 6e8b47a0b8f..e9b0bd6ba6e 100644
--- a/geography/gdal-lib/PLIST
+++ b/geography/gdal-lib/PLIST
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.14 2018/02/19 12:05:17 ryoon Exp $
+@comment $NetBSD: PLIST,v 1.15 2019/03/09 01:54:59 gdt Exp $
 bin/gdal-config
 bin/gdal_contour
 bin/gdal_grid
@@ -25,16 +25,14 @@ bin/ogrlineref
 bin/ogrtindex
 bin/testepsg
 include/cpl_atomic_ops.h
-include/cpl_aws.h
 include/cpl_config.h
 include/cpl_config_extras.h
 include/cpl_conv.h
-include/cpl_cpu_features.h
 include/cpl_csv.h
 include/cpl_error.h
-include/cpl_google_cloud.h
 include/cpl_hash_set.h
 include/cpl_http.h
+include/cpl_json.h
 include/cpl_list.h
 include/cpl_minixml.h
 include/cpl_minizip_ioapi.h
@@ -45,8 +43,6 @@ include/cpl_odbc.h
 include/cpl_port.h
 include/cpl_progress.h
 include/cpl_quad_tree.h
-include/cpl_sha1.h
-include/cpl_sha256.h
 include/cpl_spawn.h
 include/cpl_string.h
 include/cpl_time.h
@@ -54,8 +50,6 @@ include/cpl_virtualmem.h
 include/cpl_vsi.h
 include/cpl_vsi_error.h
 include/cpl_vsi_virtual.h
-include/cpl_vsil_curl_priv.h
-include/cpl_worker_thread_pool.h
 include/cplkeywordparser.h
 include/gdal.h
 include/gdal_alg.h
@@ -71,22 +65,16 @@ include/gdal_simplesurf.h
 include/gdal_utils.h
 include/gdal_version.h
 include/gdal_vrt.h
-include/gdalexif.h
 include/gdalgeorefpamdataset.h
 include/gdalgrid.h
 include/gdalgrid_priv.h
 include/gdaljp2abstractdataset.h
 include/gdaljp2metadata.h
-include/gdaljp2metadatagenerator.h
 include/gdalpansharpen.h
-include/gdalsse_priv.h
 include/gdalwarper.h
-include/gdalwarpkernel_opencl.h
 include/gnm.h
 include/gnm_api.h
 include/gnmgraph.h
-include/gvgcpfit.h
-include/internal_qhull_headers.h
 include/memdataset.h
 include/ogr_api.h
 include/ogr_core.h
@@ -99,7 +87,6 @@ include/ogr_spatialref.h
 include/ogr_srs_api.h
 include/ogrsf_frmts.h
 include/rawdataset.h
-include/thinplatespline.h
 include/vrtdataset.h
 lib/libgdal.la
 lib/pkgconfig/gdal.pc
@@ -117,6 +104,7 @@ share/gdal/ellipsoid.csv
 share/gdal/epsg.wkt
 share/gdal/esri_StatePlane_extra.wkt
 share/gdal/esri_Wisconsin_extra.wkt
+share/gdal/esri_epsg.wkt
 share/gdal/esri_extra.wkt
 share/gdal/gcs.csv
 share/gdal/gcs.override.csv
@@ -172,6 +160,7 @@ share/gdal/pci_datum.txt
 share/gdal/pci_ellips.txt
 share/gdal/pcs.csv
 share/gdal/pcs.override.csv
+share/gdal/pds4_template.xml
 share/gdal/plscenesconf.json
 share/gdal/prime_meridian.csv
 share/gdal/projop_wparm.csv
@@ -192,3 +181,4 @@ share/gdal/vdv452.xml
 share/gdal/vdv452.xsd
 share/gdal/vertcs.csv
 share/gdal/vertcs.override.csv
+@pkgdir lib/gdalplugins
diff --git a/geography/gdal-lib/distinfo b/geography/gdal-lib/distinfo
index e66fd47880d..4b5df6962ff 100644
--- a/geography/gdal-lib/distinfo
+++ b/geography/gdal-lib/distinfo
@@ -1,10 +1,10 @@
-$NetBSD: distinfo,v 1.35 2018/03/21 23:20:12 gdt Exp $
+$NetBSD: distinfo,v 1.36 2019/03/09 01:54:59 gdt Exp $
 
-SHA1 (gdal-2.2.4.tar.gz) = 39c7d8e7c3d2345491d26acaa8bfed89dd56fd7d
-RMD160 (gdal-2.2.4.tar.gz) = c2a0fbaca8e8895fd8443b535ded768943afa5c8
-SHA512 (gdal-2.2.4.tar.gz) = 82085c4e0aa112fa04c8e2631f6836bd18c396b8a83d1fe87cdd7ed801c9f1f82238e542d22493cfa75eca75e65a805277748229d4a25996c80a87131ffef7e1
-Size (gdal-2.2.4.tar.gz) = 13774304 bytes
-SHA1 (patch-apps_GNUmakefile) = 8e5de1b5bb9eab76a4f50b4ba2bd47573c5b08e2
-SHA1 (patch-frmts_grib_degrib18_degrib_myutil.c) = 584e2e3e73df2001bd377094c28eea4b6a0c31cd
-SHA1 (patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile) = 214d51e0065d5fe3c6a2af5c84f365f22ad39fda
-SHA1 (patch-port_cpl__conv.cpp) = 8a52b21f85b381e70e2a2b3424f072cc5c1d8b3a
+SHA1 (gdal-2.3.3.tar.gz) = 99cd1f4565c38561bd8409ade95209566e9b7f47
+RMD160 (gdal-2.3.3.tar.gz) = 6eb0a04c2144bd0ed9bf3e0838ee73c2e28fbaaa
+SHA512 (gdal-2.3.3.tar.gz) = 23c7fe500f7470a6120b8c30f928808c275376996c07e7491c0fe84b6bc26c72a3f92c4f75f965ee3cfb5e86cbf0fcbb82836dae515c5d5d3ffdf74888ff780b
+Size (gdal-2.3.3.tar.gz) = 14468306 bytes
+SHA1 (patch-apps_gdalserver.cpp) = 4a2b8bac29582c8fc02920840ee498026d87acca
+SHA1 (patch-frmts_grib_degrib_degrib_myutil.c) = 0e046afa236d7e0d6186fe392cb2da05fa5b42c5
+SHA1 (patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile) = 6a5061b6dd8c3a4fa1ad7c10ddc0b815b41a637d
+SHA1 (patch-port_cpl__conv.cpp) = e0c9d2dac25bc6f69f0af13a2c86ab5f0f521445
diff --git a/geography/gdal-lib/patches/patch-apps_GNUmakefile b/geography/gdal-lib/patches/patch-apps_GNUmakefile
deleted file mode 100644
index 813bd9f4abe..00000000000
--- a/geography/gdal-lib/patches/patch-apps_GNUmakefile
+++ /dev/null
@@ -1,15 +0,0 @@
-$NetBSD: patch-apps_GNUmakefile,v 1.1 2018/03/21 22:40:06 gdt Exp $
-
-Avoid setting executable bits on a header file.  Not yet reported
-upstream.
-
---- apps/GNUmakefile.orig	2017-09-15 10:37:46.000000000 +0000
-+++ apps/GNUmakefile
-@@ -216,6 +216,6 @@ gdal-config-inst:	gdal-config.in ../GDAL
- 
- install: default
- 	for f in $(BIN_LIST) ; do $(INSTALL) $$f $(DESTDIR)$(INST_BIN) ; done
--	$(INSTALL) gdal_utils.h $(DESTDIR)$(INST_INCLUDE)
-+	$(INSTALL_DATA) gdal_utils.h $(DESTDIR)$(INST_INCLUDE)
- 	$(INSTALL) gdal-config-inst $(DESTDIR)$(INST_BIN)/gdal-config
- 
diff --git a/geography/gdal-lib/patches/patch-apps_gdalserver.cpp b/geography/gdal-lib/patches/patch-apps_gdalserver.cpp
new file mode 100644
index 00000000000..96a99eece54
--- /dev/null
+++ b/geography/gdal-lib/patches/patch-apps_gdalserver.cpp
@@ -0,0 +1,26 @@
+$NetBSD: patch-apps_gdalserver.cpp,v 1.1 2019/03/09 01:54:59 gdt Exp $
+
+Define _NETBSD_SOURCE on NetBSD to work around a mysterious problem
+with <string>, where apparently too much is hidden because of the
+XOPEN request.  Probably this is not adequate, but I am choosing to
+narrowly fix the case I can debug.
+
+\todo File upstream.
+
+--- apps/gdalserver.cpp.orig	2018-12-14 15:40:20.000000000 +0000
++++ apps/gdalserver.cpp
+@@ -29,6 +29,14 @@
+ // So that __USE_XOPEN2K is defined to have getaddrinfo
+ #ifndef __sun__
+ #define _XOPEN_SOURCE 600
++#ifdef __NetBSD__
++/*
++ * Defining _XOPEN_SOURCE causes other interfaces to be hidden.  Something goes
++ * wrong with /usr/include/g++/string.
++ * \todo Address upstream.
++ */
++#define _NETBSD_SOURCE 1
++#endif
+ #endif
+ 
+ #include "cpl_port.h"
diff --git a/geography/gdal-lib/patches/patch-frmts_grib_degrib18_degrib_myutil.c b/geography/gdal-lib/patches/patch-frmts_grib_degrib18_degrib_myutil.c
deleted file mode 100644
index 983163cdbc6..00000000000
--- a/geography/gdal-lib/patches/patch-frmts_grib_degrib18_degrib_myutil.c
+++ /dev/null
@@ -1,14 +0,0 @@
-$NetBSD: patch-frmts_grib_degrib18_degrib_myutil.c,v 1.2 2018/02/19 12:05:17 ryoon Exp $
-
-fix build on SunOS
---- frmts/grib/degrib18/degrib/myutil.c.orig	2017-11-20 10:45:40.000000000 +0000
-+++ frmts/grib/degrib18/degrib/myutil.c
-@@ -23,7 +23,7 @@
- #ifdef _XOPEN_SOURCE
- #undef _XOPEN_SOURCE
- #endif
--#define _XOPEN_SOURCE 500
-+#define _XOPEN_SOURCE 600
- #endif
- 
- #include <stdlib.h>
diff --git a/geography/gdal-lib/patches/patch-frmts_grib_degrib_degrib_myutil.c b/geography/gdal-lib/patches/patch-frmts_grib_degrib_degrib_myutil.c
new file mode 100644
index 00000000000..0b0028c2507
--- /dev/null
+++ b/geography/gdal-lib/patches/patch-frmts_grib_degrib_degrib_myutil.c
@@ -0,0 +1,17 @@
+$NetBSD: patch-frmts_grib_degrib_degrib_myutil.c,v 1.1 2019/03/09 01:54:59 gdt Exp $
+
+fix build on SunOS
+\todo Explain what's wrong.
+\todo File a ticket and get this fixed upstream.
+
+--- frmts/grib/degrib/degrib/myutil.c.orig	2017-11-20 10:45:40.000000000 +0000
++++ frmts/grib/degrib/degrib/myutil.c
+@@ -23,7 +23,7 @@
+ #ifdef _XOPEN_SOURCE
+ #undef _XOPEN_SOURCE
+ #endif
+-#define _XOPEN_SOURCE 500
++#define _XOPEN_SOURCE 600
+ #endif
+ 
+ #include <stdlib.h>
diff --git a/geography/gdal-lib/patches/patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile b/geography/gdal-lib/patches/patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile
index 1e82b7b48ad..22468d9318d 100644
--- a/geography/gdal-lib/patches/patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile
+++ b/geography/gdal-lib/patches/patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile
@@ -1,6 +1,8 @@
-$NetBSD: patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile,v 1.2 2018/02/19 12:05:17 ryoon Exp $
+$NetBSD: patch-ogr_ogrsf__frmts_geojson_libjson_GNUmakefile,v 1.3 2019/03/09 01:54:59 gdt Exp $
 
 Raise _XOPEN_SOURCE to 600 (for SunOS).
+\todo Explain why this is necessary/correct.
+\todo File ticket and get this fixed upstream.es
 
 --- ogr/ogrsf_frmts/geojson/libjson/GNUmakefile.orig	2017-11-20 10:45:35.000000000 +0000
 +++ ogr/ogrsf_frmts/geojson/libjson/GNUmakefile
diff --git a/geography/gdal-lib/patches/patch-port_cpl__conv.cpp b/geography/gdal-lib/patches/patch-port_cpl__conv.cpp
index bd40f15e226..2641b33abd9 100644
--- a/geography/gdal-lib/patches/patch-port_cpl__conv.cpp
+++ b/geography/gdal-lib/patches/patch-port_cpl__conv.cpp
@@ -1,6 +1,8 @@
-$NetBSD: patch-port_cpl__conv.cpp,v 1.1 2018/02/19 12:05:17 ryoon Exp $
+$NetBSD: patch-port_cpl__conv.cpp,v 1.2 2019/03/09 01:54:59 gdt Exp $
 
-* Fix build under NetBSD
+Fix build under NetBSD
+\todo Explain what is wrong.
+\todo File ticket and get this fixed upstream.
 
 --- port/cpl_conv.cpp.orig	2017-11-20 10:45:32.000000000 +0000
 +++ port/cpl_conv.cpp
diff --git a/geography/py-gdal/Makefile b/geography/py-gdal/Makefile
index 962073df77e..df81b02a7b5 100644
--- a/geography/py-gdal/Makefile
+++ b/geography/py-gdal/Makefile
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.9 2018/12/13 19:51:58 adam Exp $
+# $NetBSD: Makefile,v 1.10 2019/03/09 01:54:59 gdt Exp $
 
-PKGREVISION=	5
+#PKGREVISION=	0
 .include "../../geography/gdal-lib/Makefile.common"
 PKGNAME=	${PYPKGPREFIX}-${DISTNAME}
 
@@ -19,7 +19,7 @@ INSTALLATION_DIRS=	bin
 
 .include "../../mk/bsd.prefs.mk"
 
-EGG_NAME?=		GDAL-2.2.4
+EGG_NAME?=		GDAL-${VERSION}
 EGG_INFODIR?=		${EGG_NAME}-py${PYVERSSUFFIX}.egg-info
 PLIST_SUBST+=		PYSITELIB=${PYSITELIB}
 PLIST_SUBST+=		EGG_NAME=${EGG_NAME}-py${PYVERSSUFFIX}