diff options
| author | wiz <wiz> | 2002-10-24 16:59:48 +0000 |
|---|---|---|
| committer | wiz <wiz> | 2002-10-24 16:59:48 +0000 |
| commit | b4dc7f7aa177f4538b3a5aa2eed1fbbe64094c47 (patch) | |
| tree | 7f4e00a60a47a00c58f2d38ac1f086b0cb1ecd83 /graphics/kdegraphics3/Makefile | |
| parent | 652d793b25258c952619bf488d36a19593d12663 (diff) | |
| download | pkgsrc-b4dc7f7aa177f4538b3a5aa2eed1fbbe64094c47.tar.gz | |
Pull the following up to the 1.6 branch (requested by agc):
Apply patches from Lubomir Sedlacik <salo@Xtrmntr.org> in PR 18115 to
generalise the linker flags used to export symbols by setting them on
a per-OS basis.
> many packages force -Wl,-export-dynamic which is not portable outside GNU ld
> and cause problems e.g. on Solaris. some of these packages use if
> conditionals either only for NetBSD or except SunOS, but the state is not
> coherent and it may complicate later when support for new OS is added to
> pkgsrc (e.g. ongoing work on HP-UX support).
>
> jlam proposed the following framework in discussion on tech-pkg:
>
> http://mail-index.netbsd.org/tech-pkg/2002/06/21/0009.html
>
> now, ${EXPORT_SYMBOLS_LDFLAGS} is used instead of directly defining
> -Wl,-export-dynamic which is set in appropriate defs.*.mk to reasonable
> values. packages should be converted to this framework by:
>
> 1) replacing LDFLAGS+= -Wl,-export-dynamic and LIBS+= -export-dynamic with:
>
> LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS}
>
> 2) for use in patchfiles, add this variable to MAKE_ENV if needed:
>
> MAKE_ENV+= EXPORT_SYMBOLS_LDFLAGS=${EXPORT_SYMBOLS_LDFLAGS}
>
> 3) replace occurances of -Wl,-export-dynamic and -export-dynamic in patch
> files with:
>
> $(EXPORT_SYMBOLS_LDFLAGS)
Diffstat (limited to 'graphics/kdegraphics3/Makefile')
| -rw-r--r-- | graphics/kdegraphics3/Makefile | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/graphics/kdegraphics3/Makefile b/graphics/kdegraphics3/Makefile index d79b78db060..fac20ebb207 100644 --- a/graphics/kdegraphics3/Makefile +++ b/graphics/kdegraphics3/Makefile @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.2 2002/07/17 07:54:05 skrll Exp $ +# $NetBSD: Makefile,v 1.2.6.1 2002/10/24 16:59:51 wiz Exp $ DISTNAME= kdegraphics-3.0.2 CATEGORIES= graphics @@ -14,11 +14,8 @@ USE_BUILDLINK_ONLY= YES CONFIGURE_ARGS+= --without-kamera # requires gPhoto2, gpio -.include "../../mk/bsd.prefs.mk" - -.if ${OPSYS} == "NetBSD" -LIBS= -Wl,--export-dynamic -.endif +# Ensure we export symbols in the linked shared object. +LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS} #.include "../../graphics/tiff/buildlink.mk" #.include "../../graphics/imlib/buildlink.mk" |