diff options
| author | fredb <fredb@pkgsrc.org> | 2003-01-20 22:42:39 +0000 |
|---|---|---|
| committer | fredb <fredb@pkgsrc.org> | 2003-01-20 22:42:39 +0000 |
| commit | 5d3655d1ef32fd6f05bc6c7b37b39ba4531b8559 (patch) | |
| tree | c7b459ec762eb1fdb65a85f4b2cdc45414e2870e /graphics/mplayer-share | |
| parent | 8b21c4ee4b6d1b558011ba7178be741e2d9749c5 (diff) | |
| download | pkgsrc-5d3655d1ef32fd6f05bc6c7b37b39ba4531b8559.tar.gz | |
The ${CFLAGS} fix-up in Makefile.cflags must come after everything, even
bsd.pkg.mk, to completely master all CFLAGS settings. This fixes the build
in the MPLAYER_ENABLE_RUNTIME_CPU_DETECTION=NO case (PR pkg/19946).
This isn't the only way this package wantonly disregards buildlink's rule.
In any case, binary packages are still problematic, even with the runtime
detection, as one of the dependencies (audio/faad2) may not be distributed
as a binary.
Diffstat (limited to 'graphics/mplayer-share')
| -rw-r--r-- | graphics/mplayer-share/Makefile.cflags | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/graphics/mplayer-share/Makefile.cflags b/graphics/mplayer-share/Makefile.cflags index 72326bd166a..38e2aac76fa 100644 --- a/graphics/mplayer-share/Makefile.cflags +++ b/graphics/mplayer-share/Makefile.cflags @@ -1,8 +1,8 @@ -# $NetBSD: Makefile.cflags,v 1.1 2003/01/20 07:10:41 fredb Exp $ +# $NetBSD: Makefile.cflags,v 1.2 2003/01/20 22:42:39 fredb Exp $ -# This must all come after the last "buildink2.mk" inclusion, as -# "buildlink2.mk" munges ${CFLAGS}, and if ${CFLAGS} is non-empty, -# the configure script refuses to add any optimizations at all. +# This must be included after everything else to truly clear ${CFLAGS} +# in the non-runtime-cpu-detection case. If ${CFLAGS} is non-empty, the +# configure script refuses to add any optimizations at all. .if ${MPLAYER_ENABLE_RUNTIME_CPU_DETECTION} == YES .if ${MACHINE_ARCH} == i386 @@ -10,9 +10,9 @@ # is nearly optimal for K6-2 as well. Anything slowler will still run # (but would probably benefit greatly from turning off the run-time # cpu detection). -CFLAGS+= -O3 -ffast-math -fomit-frame-pointer -mcpu=pentiumpro +CFLAGS= -O3 -ffast-math -fomit-frame-pointer -mcpu=pentiumpro .else -CFLAGS+= -O3 -ffast-math -fomit-frame-pointer +CFLAGS= -O3 -ffast-math -fomit-frame-pointer .endif .else CFLAGS= # Let "configure" do its thing. |