summaryrefslogtreecommitdiff
path: root/mk/check
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2006-11-10 07:59:01 +0000
committerrillig <rillig@pkgsrc.org>2006-11-10 07:59:01 +0000
commit1a5108015577ddd35a487dcb9f86c5b5adac01e6 (patch)
tree57168a59db5d216b929477522daad600bf639d2a /mk/check
parent947369945abeb08543b0bd45154650af36aafe19 (diff)
downloadpkgsrc-1a5108015577ddd35a487dcb9f86c5b5adac01e6.tar.gz
Refined the pattern for lines containing bad macros. White-space is
allowed between the "#" and the "define", and the value must be of the form "${varname}/...", that is, starting with a double quote, followed by "${" and a variable name, and directly behind the closing brace must be a slash. This should catch most false positives while still being useful.
Diffstat (limited to 'mk/check')
-rw-r--r--mk/check/check-headers.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/mk/check/check-headers.sh b/mk/check/check-headers.sh
index e337666416a..9926538a4e6 100644
--- a/mk/check/check-headers.sh
+++ b/mk/check/check-headers.sh
@@ -1,4 +1,4 @@
-# $NetBSD: check-headers.sh,v 1.7 2006/11/09 21:07:25 rillig Exp $
+# $NetBSD: check-headers.sh,v 1.8 2006/11/10 07:59:01 rillig Exp $
#
# This program checks the header files for possible problems.
#
@@ -21,7 +21,7 @@ check_header() {
# Check for "${" in macro definitions.
case "$line" in
- "#define"*"\"\${"[a-z]*"}"*"\""*)
+ "#"*define*\"\$\{[A-Za-z]*\}/*\"*)
found_unresolved_variable=yes
cs_error_heading "Found unresolved variable in macro:"
cs_error_msg "$fname: $line"