summaryrefslogtreecommitdiff
path: root/mk/pkgformat
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2020-01-15 20:03:10 +0000
committerrillig <rillig@pkgsrc.org>2020-01-15 20:03:10 +0000
commit96e96974b4920ef20a09d52a8f40c1280c7581c5 (patch)
tree0662d5b8fe6915f9292510e7e8d36df2ed55e6e1 /mk/pkgformat
parent57c2a934cb795179c9debef3317a223ca7303368 (diff)
downloadpkgsrc-96e96974b4920ef20a09d52a8f40c1280c7581c5.tar.gz
mk/pkgformat: include only relevant ident strings in +BUILD_VERSION
Before, not only files containing an RCS Id were recorded in the +BUILD_VERSION file but also files containing text that looked similar to an RCS Id were recorded, even though these didn't contain any valuable version information. The effect was that before this change, pkgtools/pkglint was built over and over again by the bulk builds since pbulk uses a different regular expression for detecting modified files. The regular expression for unexpanded RCS Ids is added to record files that have never been checked in to CVS, just to have them recorded and to distinguish them from the final committed version. See https://mail-index.netbsd.org/tech-pkg/2020/01/11/msg022489.html.
Diffstat (limited to 'mk/pkgformat')
-rw-r--r--mk/pkgformat/pkg/metadata.mk7
1 files changed, 5 insertions, 2 deletions
diff --git a/mk/pkgformat/pkg/metadata.mk b/mk/pkgformat/pkg/metadata.mk
index 7e721298e41..ee549a4e632 100644
--- a/mk/pkgformat/pkg/metadata.mk
+++ b/mk/pkgformat/pkg/metadata.mk
@@ -1,4 +1,4 @@
-# $NetBSD: metadata.mk,v 1.20 2020/01/13 06:52:57 taca Exp $
+# $NetBSD: metadata.mk,v 1.21 2020/01/15 20:03:10 rillig Exp $
######################################################################
### The targets below are all PRIVATE.
@@ -200,7 +200,10 @@ ${_BUILD_VERSION_FILE}:
${AWK} '{ t=$$0; sub("^${PKGSRCDIR}/", ""); \
printf "%s %s\n", t, $$0 }' | \
while read file relfile; do \
- ${GREP} '\$$NetBSD' $$file 2>/dev/null | \
+ ${GREP} \
+ -e '\$$NetBSD: metadata.mk,v 1.21 2020/01/15 20:03:10 rillig Exp $$]*[$$]' \
+ -e '\$$NetBSD\$$' \
+ $$file 2>/dev/null | \
${SED} -e "s|^|$$file:|;q"; \
done | \
${AWK} '{ sub("^${PKGSRCDIR}/", ""); \