diff options
| author | rillig <rillig@pkgsrc.org> | 2006-03-10 22:30:25 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-03-10 22:30:25 +0000 |
| commit | 2099d2013d18685031884220896a158fcbcfb4af (patch) | |
| tree | 69ff273261337cc887ade659f764e34c7a4880cd /pkgtools/pkglint | |
| parent | 708c88e007057a7d3cabd56c76b52f19d0ab597e (diff) | |
| download | pkgsrc-2099d2013d18685031884220896a158fcbcfb4af.tar.gz | |
Don't check the quoting in backticks. This is a misdesign of pkglint.
Diffstat (limited to 'pkgtools/pkglint')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 8fce6ad1ba4..ef754f2ff30 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.545 2006/03/09 17:34:17 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.546 2006/03/10 22:30:25 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2529,6 +2529,10 @@ sub checkline_mk_shellword($$$) { if ($state == SWST_PLAIN && defined($mod) && $mod =~ qr":Q$") { # Fine. + } elsif ($state == SWST_BACKT) { + # Don't check here, to avoid false positives + # for tool names. + } elsif (($state == SWST_SQUOT || $state == SWST_DQUOT) && $varname =~ qr"^(?:.*DIR|.*FILE|.*PATH|.*_VAR|PREFIX|.*BASE|PKGNAME)$") { # This is ok if we don't allow these # variables to have embedded [\$\\\"\'\`]. |