diff options
| author | rillig <rillig@pkgsrc.org> | 2008-01-05 18:04:06 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2008-01-05 18:04:06 +0000 |
| commit | 90e88a8d2d070a05a0038985d28ed1a1fcb1bc80 (patch) | |
| tree | d0cf4f5d76fec5e099d93486d467a28a61121856 /pkgtools/pkglint | |
| parent | cd9cd3d50b3492e000a8c9a72e22c93ab89eac64 (diff) | |
| download | pkgsrc-90e88a8d2d070a05a0038985d28ed1a1fcb1bc80.tar.gz | |
Reactivated the code to warn about missing comments in patches. It seems
that the time has come that we can no longer find out what a patch does,
unless we document it. The CVS history is not of great help in many
cases, patches get moved in the repository and so on.
To not scare casual pkglint users, these warnings are only shown if
pkglint is run with the -Wstyle or -Wall option.
Diffstat (limited to 'pkgtools/pkglint')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 25295ccba15..de5fb6a1c6c 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.749 2008/01/05 11:13:37 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.750 2008/01/05 18:04:06 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -7248,12 +7248,12 @@ sub checkfile_patch($) { # }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() { if (!$seen_comment) { - #$opt_warn_style and $line->log_warning("Comment expected."); + $opt_warn_style and $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() { if (!$seen_comment) { - #$opt_warn_style and $line->log_warning("Comment expected."); + $opt_warn_style and $line->log_warning("Comment expected."); } }], [PST_TEXT, re_patch_text, PST_TEXT, sub() { $seen_comment = true; @@ -7265,14 +7265,14 @@ sub checkfile_patch($) { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - #$opt_warn_style and $line->log_warning("Comment expected."); + $opt_warn_style and $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - #$opt_warn_style and $line->log_warning("Comment expected."); + $opt_warn_style and $line->log_warning("Comment expected."); } }], [PST_CENTER, undef, PST_TEXT, sub() { $opt_warn_space and $line->log_note("Empty line expected."); |